GolfLeague\Services\MatchRoundService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	4
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	all()	0	4	1
A	getByMatch()	0	4	1
A	getByMatchAndGroup()	0	6	1

<?php namespace GolfLeague\Services;

use GolfLeague\Storage\Match\MatchRepository;
use GolfLeague\Storage\MatchRound\MatchRoundRepository;
use GolfLeague\Storage\Round\RoundRepository;

/**
* Our MatchService, containing all useful methods for business logic around Matches
*/
class MatchRoundService
{
    // Containing our pokemonRepository to make all our database calls to
    protected $matchRepo;

    /**
    * Loads our $matchRepo
    *
    * @param MatchRepository $matchRepo

There is no parameter named $matchRepo. Was it maybe removed?

    * @return MatchService

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

    */
    public function __construct(MatchRoundRepository $matchRoundRepo, RoundRepository $roundRepo, MatchRepository $match)
    {
        $this->matchRoundRepo = $matchRoundRepo;

The property matchRoundRepo does not exist. Did you maybe forget to declare it?

        $this->roundRepo = $roundRepo;

The property roundRepo does not seem to exist. Did you mean matchRoundRepo?

        $this->match = $match;

The property match does not exist. Did you maybe forget to declare it?

    }

    public function all()
    {
        return $this->matchRoundRepo->all();
    }
    /**
    * Method to get match data from input Match id
    *
    * @param mixed $matchdata

There is no parameter named $matchdata. Was it maybe removed?

    * @return JSON object
    */
    public function getByMatch($matchId)
    {
        return $this->matchRoundRepo->getByMatch($matchId);
    }

    public function getByMatchAndGroup($matchdata)
    {
        //Retrieve players in group
        $players = $this->matchRoundRepo->matchGroup($matchdata['match_id'], $matchdata['group']);
        return $players;
    }
}