Completed
Push — 1.3 ( 3e3254...d693e1 )
by Daniel
01:39
created
code/GoogleMapField.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -200,6 +200,9 @@
 block discarded – undo
200 200
 		return $fieldNames[$name];
201 201
 	}
202 202
 
203
+	/**
204
+	 * @param string $name
205
+	 */
203 206
 	protected function recordFieldData($name) {
204 207
 		$fieldName = $this->childFieldName($name);
205 208
 		return $this->data->$fieldName ?: $this->getDefaultValue($name);
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
 	 */
68 68
 	public function setupOptions(array $options) {
69 69
 		$this->options = static::config()->default_options;
70
-		foreach($this->options as $name => &$value) {
71
-			if(isset($options[$name])) {
72
-				if(is_array($value)) {
70
+		foreach ($this->options as $name => &$value) {
71
+			if (isset($options[$name])) {
72
+				if (is_array($value)) {
73 73
 					$value = array_merge($value, $options[$name]);
74 74
 				}
75 75
 				else {
@@ -88,19 +88,19 @@  discard block
 block discarded – undo
88 88
 
89 89
 		// Create the latitude/longitude hidden fields
90 90
 		$this->latField = HiddenField::create(
91
-			$name.'[Latitude]',
91
+			$name . '[Latitude]',
92 92
 			'Lat',
93 93
 			$this->recordFieldData('Latitude')
94 94
 		)->addExtraClass('googlemapfield-latfield');
95 95
 
96 96
 		$this->lngField = HiddenField::create(
97
-			$name.'[Longitude]',
97
+			$name . '[Longitude]',
98 98
 			'Lng',
99 99
 			$this->recordFieldData('Longitude')
100 100
 		)->addExtraClass('googlemapfield-lngfield');
101 101
 
102 102
 		$this->zoomField = HiddenField::create(
103
-			$name.'[Zoom]',
103
+			$name . '[Zoom]',
104 104
 			'Zoom',
105 105
 			$this->recordFieldData('Zoom')
106 106
 		)->addExtraClass('googlemapfield-zoomfield');
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 			$this->zoomField
112 112
 		);
113 113
 
114
-		if($this->options['show_search_box']) {
114
+		if ($this->options['show_search_box']) {
115 115
 			$this->children->push(
116 116
 				TextField::create('Search')
117 117
 				->addExtraClass('googlemapfield-searchfield')
@@ -153,11 +153,11 @@  discard block
 block discarded – undo
153 153
 		$gmapsParams = array(
154 154
 			'callback' => 'googlemapfieldInit',
155 155
 		);
156
-		if($key = $this->getOption('api_key')) {
156
+		if ($key = $this->getOption('api_key')) {
157 157
 			$gmapsParams['key'] = $key;
158 158
 		}
159
-		Requirements::css(GOOGLEMAPFIELD_BASE .'/css/GoogleMapField.css');
160
-		Requirements::javascript(GOOGLEMAPFIELD_BASE .'/javascript/GoogleMapField.js');
159
+		Requirements::css(GOOGLEMAPFIELD_BASE . '/css/GoogleMapField.css');
160
+		Requirements::javascript(GOOGLEMAPFIELD_BASE . '/javascript/GoogleMapField.js');
161 161
 		Requirements::javascript('//maps.googleapis.com/maps/api/js?' . http_build_query($gmapsParams));
162 162
 	}
163 163
 
@@ -240,8 +240,8 @@  discard block
 block discarded – undo
240 240
 
241 241
 			$var = $this->options;
242 242
 
243
-			foreach($names as $n) {
244
-				if(!isset($var[$n])) {
243
+			foreach ($names as $n) {
244
+				if (!isset($var[$n])) {
245 245
 					return null;
246 246
 				}
247 247
 				$var = $var[$n];
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 	 */
260 260
 	public function setOption($name, $val) {
261 261
 		// Quicker execution path for "."-free names
262
-		if(strpos($name,'.') === false) {
262
+		if (strpos($name, '.') === false) {
263 263
 			$this->options[$name] = $val;
264 264
 		} else {
265 265
 			$names = explode('.', $name);
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
 			// We still want to do this even if we have strict path checking for legacy code
268 268
 			$var = &$this->options;
269 269
 
270
-			foreach($names as $n) {
270
+			foreach ($names as $n) {
271 271
 				$var = &$var[$n];
272 272
 			}
273 273
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,8 +71,7 @@  discard block
 block discarded – undo
71 71
 			if(isset($options[$name])) {
72 72
 				if(is_array($value)) {
73 73
 					$value = array_merge($value, $options[$name]);
74
-				}
75
-				else {
74
+				} else {
76 75
 					$value = $options[$name];
77 76
 				}
78 77
 			}
@@ -234,7 +233,9 @@  discard block
 block discarded – undo
234 233
 	public function getOption($name) {
235 234
 		// Quicker execution path for "."-free names
236 235
 		if (strpos($name, '.') === false) {
237
-			if (isset($this->options[$name])) return $this->options[$name];
236
+			if (isset($this->options[$name])) {
237
+				return $this->options[$name];
238
+			}
238 239
 		} else {
239 240
 			$names = explode('.', $name);
240 241
 
Please login to merge, or discard this patch.