Completed
Pull Request — master (#177)
by Ciaran
11:45
created
src/Behat/Gherkin/Loader/GherkinFileLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
     /**
50 50
      * Checks if current loader supports provided resource.
51 51
      *
52
-     * @param mixed $path Resource to load
52
+     * @param string $path Resource to load
53 53
      *
54 54
      * @return Boolean
55 55
      */
Please login to merge, or discard this patch.
tests/Behat/Gherkin/Keywords/KeywordsTest.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -13,8 +13,16 @@
 block discarded – undo
13 13
 
14 14
 abstract class KeywordsTest extends \PHPUnit_Framework_TestCase
15 15
 {
16
+    /**
17
+     * @return \Behat\Gherkin\Keywords\KeywordsInterface
18
+     */
16 19
     abstract protected function getKeywords();
17 20
     abstract protected function getKeywordsArray();
21
+
22
+    /**
23
+     * @param string $text
24
+     * @param string $keywordType
25
+     */
18 26
     abstract protected function getSteps($keywords, $text, &$line, $keywordType);
19 27
 
20 28
     public function translationTestDataProvider()
Please login to merge, or discard this patch.
src/Behat/Gherkin/Loader/YamlFileLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
     /**
50 50
      * Checks if current loader supports provided resource.
51 51
      *
52
-     * @param mixed $path Resource to load
52
+     * @param string $path Resource to load
53 53
      *
54 54
      * @return Boolean
55 55
      */
Please login to merge, or discard this patch.
tests/Behat/Gherkin/Parsica/Asserts.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 /** @todo upgrade phpunit and use Parsica traits */
9 9
 trait Asserts
10 10
 {
11
+    /**
12
+     * @param string $expected
13
+     */
11 14
     private function assertParse($expected, Parser $parser, string $input)
12 15
     {
13 16
         $actual = $parser->tryString("$input")->output();
Please login to merge, or discard this patch.
tests/Behat/Gherkin/Parsica/EmptyFeatureTest.php 2 patches
Doc Comments   +1 added lines, -21 removed lines patch added patch discarded remove patch
@@ -147,24 +147,4 @@
 block discarded – undo
147 147
         $parser = token(string('Foo'));
148 148
         $expected = 'Foo';
149 149
 
150
-        $this->assertParse($expected, $parser, $input);
151
-    }
152
-}
153
-
154
-/*
155
-Feature: This thing
156
-
157
-   This feature will be super awesome
158
-
159
-   Example: Example text
160
-    Given I have a cat when it's raining
161
-    When I kill the cat
162
-    Then I no longer have the cat
163
-
164
-FeatureKeyword: FeatureTitle
165
-
166
-    ScenarioKeyword: ScenarioTitle
167
-        StepKeyword StepText
168
-        StepKeyword StepText
169
-        StepKeyword StepText
170
- */
150
+        $this->assertParse($expected, $parser, $input
171 151
\ No newline at end of file
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -21 removed lines patch added patch discarded remove patch
@@ -147,24 +147,4 @@
 block discarded – undo
147 147
         $parser = token(string('Foo'));
148 148
         $expected = 'Foo';
149 149
 
150
-        $this->assertParse($expected, $parser, $input);
151
-    }
152
-}
153
-
154
-/*
155
-Feature: This thing
156
-
157
-   This feature will be super awesome
158
-
159
-   Example: Example text
160
-    Given I have a cat when it's raining
161
-    When I kill the cat
162
-    Then I no longer have the cat
163
-
164
-FeatureKeyword: FeatureTitle
165
-
166
-    ScenarioKeyword: ScenarioTitle
167
-        StepKeyword StepText
168
-        StepKeyword StepText
169
-        StepKeyword StepText
170
- */
150
+        $this->assertParse($expected, $parser, $input
171 151
\ No newline at end of file
Please login to merge, or discard this patch.