Passed
Pull Request — master (#5920)
by David
10:15
created
html/user/submit_rpc_handler.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     if ($template) {
60 60
         $t = (double)$template->workunit->rsc_fpops_est;
61 61
     }
62
-    foreach($r->batch->job as $job) {
62
+    foreach ($r->batch->job as $job) {
63 63
         $y = (double)$job->rsc_fpops_est;
64 64
         if ($y) {
65 65
             $x += $y;
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 function est_elapsed_time($r, $template) {
86 86
     // crude estimate: batch FLOPs / project FLOPS
87 87
     //
88
-    return batch_flop_count($r, $template) / project_flops();
88
+    return batch_flop_count($r, $template)/project_flops();
89 89
 }
90 90
 
91 91
 // if batch-level input template filename was given, read it;
@@ -95,9 +95,9 @@  discard block
 block discarded – undo
95 95
 //
96 96
 function read_input_template($app, $r) {
97 97
     if ((isset($r->batch)) && (isset($r->batch->workunit_template_file)) && ($r->batch->workunit_template_file)) {
98
-        $path = project_dir() . "/templates/".$r->batch->workunit_template_file;
98
+        $path = project_dir()."/templates/".$r->batch->workunit_template_file;
99 99
     } else {
100
-        $path = project_dir() . "/templates/$app->name"."_in";
100
+        $path = project_dir()."/templates/$app->name"."_in";
101 101
     }
102 102
     if (file_exists($path)) {
103 103
         $x = simplexml_load_file($path);
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 function validate_batch($jobs, $template) {
146 146
     $i = 0;
147 147
     $n = count($template->file_info);
148
-    foreach($jobs as $job) {
148
+    foreach ($jobs as $job) {
149 149
         $m = count($job->input_files);
150 150
         if ($n != $m) {
151 151
             log_write("wrong # of input files for job $i: need $n, got $m");
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
 // stage all the files
215 215
 //
216 216
 function stage_files(&$jobs, $user) {
217
-    foreach($jobs as $job) {
217
+    foreach ($jobs as $job) {
218 218
         foreach ($job->input_files as $file) {
219 219
             if ($file->mode != "remote") {
220 220
                 $file->name = stage_file($file, $user);
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 //
228 228
 function submit_jobs(
229 229
     $jobs, $job_params, $app, $batch_id, $priority, $app_version_num,
230
-    $input_template_filename,        // batch-level; can also specify per job
230
+    $input_template_filename, // batch-level; can also specify per job
231 231
     $output_template_filename,
232 232
     $user
233 233
 ) {
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
     // one line per job
238 238
     //
239 239
     $x = "";
240
-    foreach($jobs as $job) {
240
+    foreach ($jobs as $job) {
241 241
         if ($job->name) {
242 242
             $x .= " --wu_name $job->name";
243 243
         }
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
         $x .= "\n";
273 273
     }
274 274
 
275
-    $cmd = "cd " . project_dir() . "; ./bin/create_work --appname $app->name --batch $batch_id";
275
+    $cmd = "cd ".project_dir()."; ./bin/create_work --appname $app->name --batch $batch_id";
276 276
 
277 277
     if ($user->seti_id) {
278 278
         $cmd .= " --target_user $user->id ";
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
 //
381 381
 function xml_get_jobs($r) {
382 382
     $jobs = array();
383
-    foreach($r->batch->job as $j) {
383
+    foreach ($r->batch->job as $j) {
384 384
         $job = new StdClass;
385 385
         $job->input_files = array();
386 386
         $job->command_line = (string)$j->command_line;
@@ -431,16 +431,16 @@  discard block
 block discarded – undo
431 431
 //
432 432
 function logical_end_time($r, $jobs, $user, $app) {
433 433
     $total_flops = 0;
434
-    foreach($jobs as $job) {
434
+    foreach ($jobs as $job) {
435 435
         //print_r($job);
436 436
         if ($job->rsc_fpops_est) {
437 437
             $total_flops += $job->rsc_fpops_est;
438 438
         } else if ($job->input_template && $job->input_template->workunit->rsc_fpops_est) {
439
-            $total_flops += (double) $job->input_template->workunit->rsc_fpops_est;
439
+            $total_flops += (double)$job->input_template->workunit->rsc_fpops_est;
440 440
         } else if ($r->batch->job_params->rsc_fpops_est) {
441
-            $total_flops += (double) $r->batch->job_params->rsc_fpops_est;
441
+            $total_flops += (double)$r->batch->job_params->rsc_fpops_est;
442 442
         } else {
443
-            $x = (double) $template->workunit->rsc_fpops_est;
443
+            $x = (double)$template->workunit->rsc_fpops_est;
444 444
             if ($x) {
445 445
                 $total_flops += $x;
446 446
             } else {
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
             }
449 449
         }
450 450
     }
451
-    $cmd = "cd " . project_dir() . "/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
451
+    $cmd = "cd ".project_dir()."/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
452 452
     $x = exec($cmd);
453 453
     if (!is_numeric($x) || (double)$x == 0) {
454 454
         xml_error(-1, "$cmd returned $x");
@@ -533,15 +533,15 @@  discard block
 block discarded – undo
533 533
     }
534 534
 
535 535
     $job_params = new StdClass;
536
-    $job_params->rsc_disk_bound = (double) $r->batch->job_params->rsc_disk_bound;
537
-    $job_params->rsc_fpops_est = (double) $r->batch->job_params->rsc_fpops_est;
538
-    $job_params->rsc_fpops_bound = (double) $r->batch->job_params->rsc_fpops_bound;
539
-    $job_params->rsc_memory_bound = (double) $r->batch->job_params->rsc_memory_bound;
540
-    $job_params->delay_bound = (double) $r->batch->job_params->delay_bound;
536
+    $job_params->rsc_disk_bound = (double)$r->batch->job_params->rsc_disk_bound;
537
+    $job_params->rsc_fpops_est = (double)$r->batch->job_params->rsc_fpops_est;
538
+    $job_params->rsc_fpops_bound = (double)$r->batch->job_params->rsc_fpops_bound;
539
+    $job_params->rsc_memory_bound = (double)$r->batch->job_params->rsc_memory_bound;
540
+    $job_params->delay_bound = (double)$r->batch->job_params->delay_bound;
541 541
         // could add quorum-related stuff
542 542
 
543
-    $input_template_filename = (string) $r->batch->input_template_filename;
544
-    $output_template_filename = (string) $r->batch->output_template_filename;
543
+    $input_template_filename = (string)$r->batch->input_template_filename;
544
+    $output_template_filename = (string)$r->batch->output_template_filename;
545 545
         // possibly empty
546 546
 
547 547
     submit_jobs(
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
634 634
 }
635 635
 
636 636
 function n_outfiles($wu) {
637
-    $path = project_dir() . "/$wu->output_template_filename";
637
+    $path = project_dir()."/$wu->output_template_filename";
638 638
     $r = simplexml_load_file($path);
639 639
     return count($r->file_info);
640 640
 }
@@ -841,7 +841,7 @@  discard block
 block discarded – undo
841 841
 ";
842 842
         if ($result->server_state == 5) {   // over?
843 843
             $paths = get_outfile_paths($result);
844
-            foreach($paths as $path) {
844
+            foreach ($paths as $path) {
845 845
                 if (is_file($path)) {
846 846
                     $size = filesize($path);
847 847
                     echo "        <outfile>
@@ -885,7 +885,7 @@  discard block
 block discarded – undo
885 885
     } else {
886 886
         $results = BoincResult::enum("workunitid=$job_id");
887 887
         foreach ($results as $r) {
888
-            switch($r->outcome) {
888
+            switch ($r->outcome) {
889 889
             case 1:
890 890
             case 3:
891 891
             case 6:
@@ -1000,8 +1000,8 @@  discard block
 block discarded – undo
1000 1000
     }
1001 1001
 
1002 1002
     $user = check_remote_submit_permissions($r, $app);
1003
-    $in = file_get_contents(project_dir() . "/templates/".$app->name."_in");
1004
-    $out = file_get_contents(project_dir() . "/templates/".$app->name."_out");
1003
+    $in = file_get_contents(project_dir()."/templates/".$app->name."_in");
1004
+    $out = file_get_contents(project_dir()."/templates/".$app->name."_out");
1005 1005
     if ($in === false || $out === false) {
1006 1006
         log_write("template file missing");
1007 1007
         xml_error(-1, "template file missing");
@@ -1013,7 +1013,7 @@  discard block
 block discarded – undo
1013 1013
 
1014 1014
 function ping($r) {
1015 1015
     xml_start_tag("ping");
1016
-    BoincDb::get();     // errors out if DB down or web disabled
1016
+    BoincDb::get(); // errors out if DB down or web disabled
1017 1017
     echo "<success>1</success>
1018 1018
         </ping>
1019 1019
     ";
@@ -1080,9 +1080,9 @@  discard block
 block discarded – undo
1080 1080
 $request_log = parse_config(get_config(), "<remote_submit_request_log>");
1081 1081
 if ($request_log) {
1082 1082
     $log_dir = parse_config(get_config(), "<log_dir>");
1083
-    $request_log = $log_dir . "/" . $request_log;
1083
+    $request_log = $log_dir."/".$request_log;
1084 1084
     if ($file = fopen($request_log, "a")) {
1085
-        fwrite($file, "\n<submit_rpc_handler date=\"" . date(DATE_ATOM) . "\">\n" . $_POST['request'] . "\n</submit_rpc_handler>\n");
1085
+        fwrite($file, "\n<submit_rpc_handler date=\"".date(DATE_ATOM)."\">\n".$_POST['request']."\n</submit_rpc_handler>\n");
1086 1086
         fclose($file);
1087 1087
     }
1088 1088
 }
Please login to merge, or discard this patch.