BOINC / boinc

html/user/buda.php

Spacing +6 added lines, -6 removed lines

@@ -36,7 +36,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -224,7 +224,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = count($desc->input_file_names);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <sticky/>\n      <no_delete/>\n      <executable/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";
@@ -245,7 +245,7 @@ 
     );
 
     $x .= sprintf("      <max_delay>%f</max_delay>\n",
-        $desc->max_delay_days * 86400.
+        $desc->max_delay_days*86400.
     );
 
     $x .= "      <buda_app_name>$app</buda_app_name>\n";
@@ -318,7 +318,7 @@ 
     } else {
         $creating = true;
     }
-    $variant = sprintf('%s_%s', $cpu_type, $plan_class?$plan_class:'cpu');
+    $variant = sprintf('%s_%s', $cpu_type, $plan_class ? $plan_class : 'cpu');
     if (!is_valid_filename($variant)) {
         error_page(filename_rules());
     }
@@ -463,8 +463,8 @@ 
     }
 }
 
-function app_form($desc=null) {
-    page_head_select2($desc?"Edit BUDA app $desc->name":'Create BUDA app');
+function app_form($desc = null) {
+    page_head_select2($desc ? "Edit BUDA app $desc->name" : 'Create BUDA app');
     form_start('buda.php');
     form_input_hidden('action', 'app_action');
     if ($desc) {

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -195,7 +195,7 @@ 
         );
     }
     form_input_text("Plan class$pc", 'plan_class', $variant_desc->plan_class);
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems, $variant_desc->dockerfile);
+    form_select("dockerfile$sb", 'dockerfile', $sbitems, $variant_desc->dockerfile);
     form_select2_multi("Application files$sb", 'app_files', $sbitems, $variant_desc->app_files);
     form_submit('OK');
     form_end();
@@ -393,7 +393,7 @@ 
     // Note: we don't currently allow indirect file access.
     // If we did, we'd need to create job.toml to mount project dir
 
-    app_list("Variant $variant added for app $app.");
+    app_list("variant $variant added for app $app.");
 }
 
 function variant_delete() {
@@ -420,7 +420,7 @@ 
         if ($ret) {
             error_page("delete failed");
         }
-        $notice = "Variant $variant of app $app removed.";
+        $notice = "variant $variant of app $app removed.";
         app_list($notice);
     } else {
         page_head("Confirm");
@@ -450,7 +450,7 @@ 
         if ($ret) {
             error_page('delete failed');
         }
-        $notice = "App $app removed.";
+        $notice = "app $app removed.";
         app_list($notice);
     } else {
         page_head('Confirm');
@@ -547,7 +547,7 @@ 
         }
         $dir = "$buda_root/$app_name";
         if (file_exists($dir)) {
-            error_page("App $app_name already exists.");
+            error_page("app $app_name already exists.");
         }
         mkdir($dir);
         $desc->user_id = $user->id;

html/user/submit.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -639,7 +639,7 @@ 
 
     $is_assim_move = is_assim_move($app);
 
-    page_head("Batch $batch_id");
+    page_head("batch $batch_id");
     text_start(800);
     start_table();
     row2("name", $batch->name);
@@ -923,7 +923,7 @@ 
 
     if (get_int('confirmed', true)) {
         abort_batch($batch);
-        page_head("Batch $batch_id aborted");
+        page_head("batch $batch_id aborted");
         return_link();
         page_tail();
     } else {
@@ -952,7 +952,7 @@ 
 
     if (get_int('confirmed', true)) {
         retire_batch($batch);
-        page_head("Batch $batch_id retired");
+        page_head("batch $batch_id retired");
         return_link();
         page_tail();
     } else {

html/user/buda_submit.php

Spacing +7 added lines, -7 removed lines

@@ -82,7 +82,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -133,7 +133,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -187,7 +187,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -197,7 +197,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -236,7 +236,7 @@ 
         $job_cmds .= "$job_cmd\n";
     }
     $wrapper_cmdline = sprintf('"%s %s"',
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(
@@ -283,7 +283,7 @@ 
     $max_runtime_days = (double)$max_runtime_days;
     if ($max_runtime_days <= 0) error_page('bad runtime limit');
     if ($max_runtime_days > 100) error_page('bad runtime limit');
-    $max_fpops = $max_runtime_days * 4.3e9 * 86400;
+    $max_fpops = $max_runtime_days*4.3e9*86400;
 
     $exp_runtime_days = get_str('exp_runtime_days');
     if (!is_numeric($exp_runtime_days)) error_page('bad expected runtime');
@@ -293,7 +293,7 @@ 
     if ($exp_runtime_days > $max_runtime_days) {
         error_page('exp must be < max runtime');
     }
-    $exp_fpops = $exp_runtime_days * 4.3e9 * 86400;
+    $exp_fpops = $exp_runtime_days*4.3e9*86400;
 
     $app_desc = get_buda_app_desc($app);