Passed
Pull Request — master (#5432)
by David
08:33
created
html/inc/db_ops.inc 1 patch
Spacing   +105 added lines, -105 removed lines patch added patch discarded remove patch
@@ -42,27 +42,27 @@  discard block
 block discarded – undo
42 42
 // @return String A user readable DateTime-String in UTC
43 43
 // @param Integer $x The mysql-Timestamp to convert
44 44
 function mysqltime_str($x) {
45
-    if(strpos($x,"-")==4) {
45
+    if (strpos($x, "-") == 4) {
46 46
         // Syntax of supplied mysql-timestamp is YYYY-MM-DD HH:MM:SS
47
-        $year = substr($x,0,4);
48
-        $month = substr($x,5,2);
49
-        $day = substr($x,8,2);
50
-        $hour = substr($x,11,2);
51
-        $minute = substr($x,14,2);
52
-        $second = substr($x,17,2);
47
+        $year = substr($x, 0, 4);
48
+        $month = substr($x, 5, 2);
49
+        $day = substr($x, 8, 2);
50
+        $hour = substr($x, 11, 2);
51
+        $minute = substr($x, 14, 2);
52
+        $second = substr($x, 17, 2);
53 53
     } else {
54 54
         // Syntax of supplied mysql-timestamp is YYYYMMDDHHMMSS
55
-        $year = substr($x,0,4);
56
-        $month = substr($x,4,2);
57
-        $day = substr($x,6,2);
58
-        $hour = substr($x,8,2);
59
-        $minute = substr($x,10,2);
60
-        $second = substr($x,12,2);
55
+        $year = substr($x, 0, 4);
56
+        $month = substr($x, 4, 2);
57
+        $day = substr($x, 6, 2);
58
+        $hour = substr($x, 8, 2);
59
+        $minute = substr($x, 10, 2);
60
+        $second = substr($x, 12, 2);
61 61
 
62 62
     }
63 63
     //make a Unix-Timestamp
64 64
     // echo "Time string is " . "$x";
65
-    $time = mktime($hour,$minute,$second,$month,$day,$year);
65
+    $time = mktime($hour, $minute, $second, $month, $day, $year);
66 66
     return time_str($time);
67 67
 }
68 68
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         $constants = get_defined_constants(true);
101 101
         foreach ($constants['mysqli'] as $c => $n) if (preg_match('/^MYSQLI_TYPE_(.*)/', $c, $m)) $types[$n] = $m[1];
102 102
     }
103
-    return array_key_exists($type_id, $types)? strtolower($types[$type_id]) : "unknown";
103
+    return array_key_exists($type_id, $types) ? strtolower($types[$type_id]) : "unknown";
104 104
 }
105 105
 
106 106
 // Function prints a description of $table
@@ -110,38 +110,38 @@  discard block
 block discarded – undo
110 110
     $result = $db->do_query("SELECT * from $table LIMIT 1");
111 111
     $fields = $result->field_count;
112 112
 
113
-    $avgnum=(int)($fields/$columns);
114
-    if ($avgnum*$columns<$fields) {
113
+    $avgnum = (int)($fields/$columns);
114
+    if ($avgnum*$columns < $fields) {
115 115
         $avgnum++;
116 116
     }
117 117
 
118
-    $actualcolumns=0;
119
-    while ($avgnum*$actualcolumns<$fields) {
118
+    $actualcolumns = 0;
119
+    while ($avgnum*$actualcolumns < $fields) {
120 120
         $actualcolumns++;
121 121
     }
122 122
 
123
-    if ($which>$actualcolumns) {
123
+    if ($which > $actualcolumns) {
124 124
         return 0;
125 125
     }
126 126
 
127
-    $bot=($which-1)*$avgnum;
128
-    $top=$which*$avgnum;
127
+    $bot = ($which - 1)*$avgnum;
128
+    $top = $which*$avgnum;
129 129
 
130
-    $width=100.0/$actualcolumns;
130
+    $width = 100.0/$actualcolumns;
131 131
 
132 132
     echo "<td>";
133 133
     start_table('table-striped');
134 134
     echo "<tr><th align=\"left\">NAME</th><th align=\"left\">Type</th><th align=\"left\">Bytes</th>\n";
135
-    for ($count=$bot; $count<$top; $count++) {
136
-        if ($count<$fields) {
135
+    for ($count = $bot; $count < $top; $count++) {
136
+        if ($count < $fields) {
137 137
             $x = $result->fetch_field_direct($count);
138 138
             $name = $x->name;
139 139
             $type = mysql_fieldtype_str($x->type);
140 140
             $length = $x->length;
141 141
         } else {
142
-            $name="<br/> ";
143
-            $type="<br/>";
144
-            $length="<br/>";
142
+            $name = "<br/> ";
143
+            $type = "<br/>";
144
+            $length = "<br/>";
145 145
         }
146 146
         echo "\t<tr><td><b>$name</b></td><td>$type</td><td>$length</td></tr>\n";
147 147
     }
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
     echo "<h2>Description of <b>$table</b> table fields:</h2>\n";
157 157
     start_table();
158 158
     echo "<tr>";
159
-    for ($i=1; $i<=$how_many_columns; $i++) {
159
+    for ($i = 1; $i <= $how_many_columns; $i++) {
160 160
         print_describe_table_onecol($table, $i, $how_many_columns);
161 161
     }
162 162
     echo "</tr>";
@@ -175,10 +175,10 @@  discard block
 block discarded – undo
175 175
 }
176 176
 
177 177
 function print_query_field() {
178
-    $currenttime=time();
179
-    $hourago=$currenttime-3600;
180
-    $dayago=$currenttime-24*3600;
181
-    $weekago=$currenttime-7*24*3600;
178
+    $currenttime = time();
179
+    $hourago = $currenttime - 3600;
180
+    $dayago = $currenttime - 24*3600;
181
+    $weekago = $currenttime - 7*24*3600;
182 182
     echo "
183 183
         <tr>
184 184
         <td align=\"right\">Additional clauses</td>
@@ -202,11 +202,11 @@  discard block
 block discarded – undo
202 202
     }
203 203
 }
204 204
 
205
-function append_sql_query($original,$addition,$first) {
205
+function append_sql_query($original, $addition, $first) {
206 206
     if ($first == 1) {
207
-        return $original . " where " . $addition;
207
+        return $original." where ".$addition;
208 208
     } else {
209
-        return $original . " and " . $addition;
209
+        return $original." and ".$addition;
210 210
     }
211 211
 }
212 212
 
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
         if (isset($_GET[$name])) {
308 308
             $value = $_GET[$name];
309 309
         } else {
310
-            $value=null;
310
+            $value = null;
311 311
         }
312 312
         if (isset($_GET[$order])) {
313 313
              $order = $_GET[$order];
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
     }
349 349
 
350 350
     function get_url($base = "db_action.php") {
351
-        $s = $base . "?table=$this->table$this->urlquery";
351
+        $s = $base."?table=$this->table$this->urlquery";
352 352
         return $s;
353 353
     }
354 354
 
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
         $this->addeq('app_version_id');
364 364
         $this->addeq('exit_status');
365 365
         if (isset($_GET['nsecs'])) {
366
-            $_GET['mod_time'] = date("YmdHis",time() - $_GET['nsecs']);
366
+            $_GET['mod_time'] = date("YmdHis", time() - $_GET['nsecs']);
367 367
         }
368 368
         $this->addgt('mod_time');
369 369
         $this->addeq_not_CHOOSE_ALL('server_state');
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
     if ($n == '0') { // intentional compare by string
385 385
         return "0";
386 386
     } else {
387
-        if(strlen($clauses)) {
387
+        if (strlen($clauses)) {
388 388
             return "<a href=\"db_action.php?table=result&query=$mq&$query&clauses=".urlencode($clauses)."&sort_by=mod_time&detail=low\">$n</a>";
389 389
         }
390 390
         else {
@@ -397,13 +397,13 @@  discard block
 block discarded – undo
397 397
 // Determines if in stderr_out is an error reported and prints as human readable String
398 398
 // @return String A human readable string if error otherwise FALSE
399 399
 // @param String $stderr_out the stderr_out value to parse
400
-function stderr_error_string($stderr_out){
400
+function stderr_error_string($stderr_out) {
401 401
     $y = parse_element($stderr_out, "<error_code>");
402 402
     $x = 0;
403 403
     if ($y) {
404 404
         $x = (int)$y;
405 405
     }
406
-    if (0<=$x && $x<=9) {
406
+    if (0 <= $x && $x <= 9) {
407 407
         return FALSE;
408 408
     } else {
409 409
         return "$x ".error_code_str($x);
@@ -411,8 +411,8 @@  discard block
 block discarded – undo
411 411
 }
412 412
 
413 413
 function admin_show_result_summary() {
414
-    $ntotal =0;     // TODO: how to count $result?
415
-    $nvalid = 0;    // for SUCCESS results
414
+    $ntotal = 0; // TODO: how to count $result?
415
+    $nvalid = 0; // for SUCCESS results
416 416
     $ninvalid = 0;
417 417
     $nfile_deleted = 0;
418 418
 
@@ -420,20 +420,20 @@  discard block
 block discarded – undo
420 420
     $outcome = array();
421 421
     $client_state = array();
422 422
 
423
-    for ($ss=1; $ss<6; $ss++) {
423
+    for ($ss = 1; $ss < 6; $ss++) {
424 424
         $server_state[$ss] = 0;
425 425
     }
426
-    for ($ro=0; $ro<8; $ro++) {
426
+    for ($ro = 0; $ro < 8; $ro++) {
427 427
         $outcome[$ro] = 0;
428 428
     }
429
-    for ($cs=1; $cs<7; $cs++) {
429
+    for ($cs = 1; $cs < 7; $cs++) {
430 430
         $client_state[$cs] = 0;
431 431
     }
432
-    for ($fds=0; $fds<4; $fds++) {
432
+    for ($fds = 0; $fds < 4; $fds++) {
433 433
         $delete_state[$fds] = 0;
434 434
     }
435
-    for ($vs=0; $vs<NVALIDATE_STATES; $vs++) {
436
-        $validate_state[$vs]=0;
435
+    for ($vs = 0; $vs < NVALIDATE_STATES; $vs++) {
436
+        $validate_state[$vs] = 0;
437 437
     }
438 438
 
439 439
     $_GET['table'] = 'result';
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
         //
509 509
         $delay = parse_config(get_config(), "<delete_delay_hours>");
510 510
         if ($delay) {
511
-            $start2 = $start - $delay*3600;;
511
+            $start2 = $start - $delay*3600; ;
512 512
             $main_query .= " and ((file_delete_state>1 and mod_time>FROM_UNIXTIME($start2)) or (mod_time>FROM_UNIXTIME($start)))";
513 513
         } else {
514 514
             $main_query .= " and mod_time > FROM_UNIXTIME($start)";
@@ -567,20 +567,20 @@  discard block
 block discarded – undo
567 567
 
568 568
     start_table();
569 569
     echo "<tr valign=\"top\">";
570
-    echo "<td><h2>" . link_results("$ntotal results", $urlquery, '', '') . "</h2></td>";
571
-    echo "<td><h2>" . link_results("'Over' results", $urlquery, "server_state=5", '') . "</h2></td>";
572
-    echo "<td><h2>" . link_results("'Success' results", $urlquery, "outcome=1", '') . "</h2></td>";
573
-    echo "<td><h2>" . link_results("'Client error' results", $urlquery, "outcome=3", '') . "</h2></td>";
570
+    echo "<td><h2>".link_results("$ntotal results", $urlquery, '', '')."</h2></td>";
571
+    echo "<td><h2>".link_results("'Over' results", $urlquery, "server_state=5", '')."</h2></td>";
572
+    echo "<td><h2>".link_results("'Success' results", $urlquery, "outcome=1", '')."</h2></td>";
573
+    echo "<td><h2>".link_results("'Client error' results", $urlquery, "outcome=3", '')."</h2></td>";
574 574
     echo "</tr>";
575 575
     echo "<tr valign=\"top\">";
576 576
     echo "<td>";
577 577
     start_table('table-striped');
578 578
     echo "<tr><th>Server state</th><th># results</th></tr>\n";
579
-    for ($ss=1; $ss<6; $ss++) {
579
+    for ($ss = 1; $ss < 6; $ss++) {
580 580
         $res = new StdClass;
581 581
         $res->server_state = $ss;
582 582
         row2(result_server_state_string($res),
583
-             link_results("$server_state[$ss]",  $urlquery,"server_state=$ss", '')
583
+             link_results("$server_state[$ss]", $urlquery, "server_state=$ss", '')
584 584
         );
585 585
     }
586 586
     end_table();
@@ -590,11 +590,11 @@  discard block
 block discarded – undo
590 590
     start_table('table-striped');
591 591
     echo "<tr><th>Outcome</th><th># results</th></tr>\n";
592 592
 
593
-    for ($ro=0; $ro<8; $ro++) {
593
+    for ($ro = 0; $ro < 8; $ro++) {
594 594
         $res = new StdClass;
595 595
         $res->outcome = $ro;
596 596
         $res->exit_status = 0;
597
-        c_row2($outcome[$ro]?outcome_color($ro):'', result_outcome_string($res),
597
+        c_row2($outcome[$ro] ?outcome_color($ro) : '', result_outcome_string($res),
598 598
             link_results("$outcome[$ro]", $urlquery, "outcome=$ro", '')
599 599
         );
600 600
     }
@@ -604,18 +604,18 @@  discard block
 block discarded – undo
604 604
     echo "<td>";
605 605
     start_table('table-striped');
606 606
     echo "<tr><th>Validate state</th><th># results</th></tr>\n";
607
-    for ($vs=0; $vs<NVALIDATE_STATES; $vs++) {
607
+    for ($vs = 0; $vs < NVALIDATE_STATES; $vs++) {
608 608
         $res = new StdClass;
609 609
         $res->validate_state = $vs;
610 610
         $res->exit_status = 0;
611
-        c_row2($validate_state[$vs]?validate_color($vs):'', validate_state_str($res),
611
+        c_row2($validate_state[$vs] ?validate_color($vs) : '', validate_state_str($res),
612 612
         link_results("$validate_state[$vs]", $urlquery, "validate_state=$vs", "outcome=1"));
613 613
     }
614 614
     end_table();
615 615
     start_table('table-striped');
616 616
     echo "<tr><th>File Delete state</th><th># results</th></tr>\n";
617 617
 
618
-    for ($fds=0; $fds<4; $fds++) {
618
+    for ($fds = 0; $fds < 4; $fds++) {
619 619
         row2(file_delete_state_str($fds),
620 620
         link_results("$file_delete[$fds]", $urlquery, "outcome=1", "file_delete_state=$fds"));
621 621
     }
@@ -627,7 +627,7 @@  discard block
 block discarded – undo
627 627
     echo "<td>";
628 628
     start_table('table-striped');
629 629
     echo "<tr><th>Client state</th><th># results</th></tr>\n";
630
-    for ($cs=1; $cs<7; $cs++) {
630
+    for ($cs = 1; $cs < 7; $cs++) {
631 631
         $res = new StdClass;
632 632
         $res->client_state = $cs;
633 633
         $res->exit_status = 0;
@@ -646,9 +646,9 @@  discard block
 block discarded – undo
646 646
         <select name=\"server_state\">
647 647
         <option value=\"CHOOSE_ALL\" selected=\"selected\"> Any </option>
648 648
     ";
649
-    for ($i=1; $i<6; $i++) {
649
+    for ($i = 1; $i < 6; $i++) {
650 650
         $res = new StdClass;
651
-        $res->server_state=$i;
651
+        $res->server_state = $i;
652 652
         echo "<option value=\"$i\"> "."[$i]&nbsp;&nbsp;".'   '.result_server_state_string($res)."</option>\n";
653 653
     }
654 654
     echo "</select>\n";
@@ -659,7 +659,7 @@  discard block
 block discarded – undo
659 659
         <select name=\"outcome\">
660 660
         <option value=\"CHOOSE_ALL\" selected=\"selected\"> Any </option>
661 661
     ";
662
-    for ($i=0; $i<8; $i++) {
662
+    for ($i = 0; $i < 8; $i++) {
663 663
         $res = new StdClass;
664 664
         $res->outcome = $i;
665 665
         $res->exit_status = 0;
@@ -673,7 +673,7 @@  discard block
 block discarded – undo
673 673
         <select name=\"validate_state\">
674 674
         <option value=\"CHOOSE_ALL\" selected=\"selected\"> Any </option>
675 675
         ";
676
-    for ($vs=0; $vs<NVALIDATE_STATES; $vs++) {
676
+    for ($vs = 0; $vs < NVALIDATE_STATES; $vs++) {
677 677
         $res = new StdClass;
678 678
         $res->validate_state = $vs;
679 679
         $res->exit_status = 0;
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
         <select name=\"client_state\">
688 688
         <option value=\"CHOOSE_ALL\" selected=\"selected\"> Any </option>
689 689
     ";
690
-    for ($i=0; $i<7; $i++) {
690
+    for ($i = 0; $i < 7; $i++) {
691 691
         $res = new StdClass;
692 692
         $res->client_state = $i;
693 693
         $res->exit_status = 0;
@@ -724,7 +724,7 @@  discard block
 block discarded – undo
724 724
 }
725 725
 
726 726
 function table_title($table) {
727
-    switch($table) {
727
+    switch ($table) {
728 728
     case "platform": return "Platforms";
729 729
     case "app": return "Applications";
730 730
     case "app_version": return "Application Versions";
@@ -744,7 +744,7 @@  discard block
 block discarded – undo
744 744
     row("Created", time_str($platform->create_time));
745 745
     row("Name", $platform->name);
746 746
     row("User friendly name", $platform->user_friendly_name);
747
-    row("","<a href=\"db_action.php?table=app_version&platformid=$platform->id\">App versions for this platform</a>");
747
+    row("", "<a href=\"db_action.php?table=app_version&platformid=$platform->id\">App versions for this platform</a>");
748 748
     end_table();
749 749
 }
750 750
 
@@ -756,8 +756,8 @@  discard block
 block discarded – undo
756 756
     row("User-friendly name", $app->user_friendly_name);
757 757
     row("Deprecated", $app->deprecated);
758 758
     row("Homogeneous redundancy", $app->homogeneous_redundancy);
759
-    row("","<a href=\"db_action.php?table=app_version&appid=$app->id\">App Versions for this application</a>");
760
-    row("","<a href=\"db_action.php?table=workunit&appid=$app->id&detail=low\">Workunits for this application</a>");
759
+    row("", "<a href=\"db_action.php?table=app_version&appid=$app->id\">App Versions for this application</a>");
760
+    row("", "<a href=\"db_action.php?table=workunit&appid=$app->id&detail=low\">Workunits for this application</a>");
761 761
     end_table();
762 762
 }
763 763
 
@@ -765,9 +765,9 @@  discard block
 block discarded – undo
765 765
     start_table();
766 766
     row("ID", $app_version->id);
767 767
     row("Created", time_str($app_version->create_time));
768
-    row("Application", "<a href=\"db_action.php?table=app&id=$app_version->appid\">" . app_name_by_id($app_version->appid) . "</a>");
768
+    row("Application", "<a href=\"db_action.php?table=app&id=$app_version->appid\">".app_name_by_id($app_version->appid)."</a>");
769 769
     row("Version num", $app_version->version_num);
770
-    row("Platform", "<a href=\"db_action.php?table=platform&id=$app_version->platformid\">" . platform_name_by_id($app_version->platformid) . "</a>" );
770
+    row("Platform", "<a href=\"db_action.php?table=platform&id=$app_version->platformid\">".platform_name_by_id($app_version->platformid)."</a>");
771 771
     row("Plan Class", $app_version->plan_class);
772 772
     row("XML doc", "<pre>".htmlspecialchars($app_version->xml_doc)."</pre>");
773 773
     row("min_core_version", $app_version->min_core_version);
@@ -901,7 +901,7 @@  discard block
 block discarded – undo
901 901
     row("External IP address", "$host->external_ip_addr<br>");
902 902
     row("Domain name", $host->domain_name);
903 903
     $x = $host->timezone/3600;
904
-    if ($x >= 0) $x="+$x";
904
+    if ($x >= 0) $x = "+$x";
905 905
     row("Local Standard Time", "UTC $x hours");
906 906
     row("Number of CPUs", $host->p_ncpus);
907 907
     row("CPU", "$host->p_vendor $host->p_model");
@@ -953,10 +953,10 @@  discard block
 block discarded – undo
953 953
     start_table();
954 954
     row("Created", time_str($wu->create_time));
955 955
     row("Transition Time", time_str($wu->transition_time));
956
-    row("Last time modified",mysqltime_str($wu->mod_time));
956
+    row("Last time modified", mysqltime_str($wu->mod_time));
957 957
     row("Name", $wu->name);
958 958
     row("XML doc", "<pre>".htmlspecialchars($wu->xml_doc)."</pre>");
959
-    row("Application", "<a href=\"db_action.php?table=app&id=$wu->appid\">" . app_name_by_id($wu->appid) . " [".$wu->appid."]</a>");
959
+    row("Application", "<a href=\"db_action.php?table=app&id=$wu->appid\">".app_name_by_id($wu->appid)." [".$wu->appid."]</a>");
960 960
     row("Application version number", $wu->app_version_num);
961 961
     row("Batch", $wu->batch);
962 962
     $x = number_format($wu->rsc_fpops_est/1e9, 2);
@@ -969,12 +969,12 @@  discard block
 block discarded – undo
969 969
     $x = $wu->rsc_disk_bound/(1024*1024);
970 970
     $y = number_format($x, 2);
971 971
     row("Max Disk Usage", "$y MB");
972
-    row("Need validate?", ($wu->need_validate?"yes [":"no [").$wu->need_validate."]");
972
+    row("Need validate?", ($wu->need_validate ? "yes [" : "no [").$wu->need_validate."]");
973 973
     row("Canonical resultid",
974 974
             "<a href=\"db_action.php?table=result&id=$wu->canonical_resultid\">".$wu->canonical_resultid."</a>");
975 975
     row("Canonical credit", $wu->canonical_credit);
976 976
     //row("Timeout check time", time_str($wu->timeout_check_time));
977
-    row("Delay bound", "$wu->delay_bound" . " =  " . time_diff($wu->delay_bound) );
977
+    row("Delay bound", "$wu->delay_bound"." =  ".time_diff($wu->delay_bound));
978 978
     row("Error mask", wu_error_mask_str($wu->error_mask, true));
979 979
     row("File delete state", file_delete_state_str($wu->file_delete_state)." [".$wu->file_delete_state."]");
980 980
     row("Assimilation state", assimilate_state_str($wu->assimilate_state)." [".$wu->assimilate_state."]");
@@ -984,7 +984,7 @@  discard block
 block discarded – undo
984 984
     row("max error results", $wu->max_error_results);
985 985
     row("max total results", $wu->max_total_results);
986 986
     row("max success results", $wu->max_success_results);
987
-    row("result template file",$wu->result_template_file);
987
+    row("result template file", $wu->result_template_file);
988 988
     row("hr_class", $wu->hr_class);
989 989
     row("opaque", $wu->opaque);
990 990
     row("Priority", $wu->priority);
@@ -1062,7 +1062,7 @@  discard block
 block discarded – undo
1062 1062
 }
1063 1063
 
1064 1064
 function outcome_color($outcome) {
1065
-    switch($outcome) {
1065
+    switch ($outcome) {
1066 1066
     case 0: return '9900cc'; // "Init", purple
1067 1067
     case 1: return '33cc33'; // "Success", green
1068 1068
     case 3: return 'ff3333'; // "Client error", red
@@ -1089,18 +1089,18 @@  discard block
 block discarded – undo
1089 1089
     row("Sent", time_str($result->sent_time));
1090 1090
     row("Report deadline", time_str($result->report_deadline));
1091 1091
     row("Received", time_str($result->received_time));
1092
-    row("Last time modified",mysqltime_str($result->mod_time));
1092
+    row("Last time modified", mysqltime_str($result->mod_time));
1093 1093
     row("Name", $result->name);
1094
-    row("Workunit", "<a href=\"db_action.php?table=workunit&id=$result->workunitid\">" . wu_name_by_id($result->workunitid) . "</a> [$result->workunitid]" );
1094
+    row("Workunit", "<a href=\"db_action.php?table=workunit&id=$result->workunitid\">".wu_name_by_id($result->workunitid)."</a> [$result->workunitid]");
1095 1095
     row("Server state", result_server_state_string($result)." [$result->server_state]");
1096 1096
     row("Outcome", result_outcome_string($result)." [$result->outcome]");
1097 1097
     row("Client state", result_client_state_string($result)." [$result->client_state]");
1098 1098
     row("Exit status", exit_status_string($result->exit_status));
1099
-    row("Host ID", "<a href=\"db_action.php?table=host&id=$result->hostid\">" . host_name_by_id($result->hostid) . "</a> [$result->hostid]");
1100
-    row("User ID", "<a href=\"db_action.php?table=user&id=$result->userid\">" . user_name_by_id($result->userid) . "</a> [$result->userid]");
1099
+    row("Host ID", "<a href=\"db_action.php?table=host&id=$result->hostid\">".host_name_by_id($result->hostid)."</a> [$result->hostid]");
1100
+    row("User ID", "<a href=\"db_action.php?table=user&id=$result->userid\">".user_name_by_id($result->userid)."</a> [$result->userid]");
1101 1101
     row("CPU time", $result->cpu_time);
1102 1102
     row("Elapsed time", $result->elapsed_time);
1103
-    if($error=stderr_error_string($result->stderr_out)) {
1103
+    if ($error = stderr_error_string($result->stderr_out)) {
1104 1104
         row("error in stderr out", $error);
1105 1105
     }
1106 1106
     row("Batch", $result->batch);
@@ -1117,16 +1117,16 @@  discard block
 block discarded – undo
1117 1117
     row("App version", $x1.app_version_string($result).$x2);
1118 1118
     row("App version ID", $result->app_version_id);
1119 1119
     row("Estimated GFLOPS", number_format($result->flops_estimate/1e9, 2));
1120
-    row("Random",$result->random);
1121
-    row("Opaque",$result->opaque);
1122
-    row("Teamid",$result->teamid);
1123
-    row("Priority",$result->priority);
1120
+    row("Random", $result->random);
1121
+    row("Opaque", $result->opaque);
1122
+    row("Teamid", $result->teamid);
1123
+    row("Priority", $result->priority);
1124 1124
     row("XML doc in", "<pre>".htmlspecialchars($result->xml_doc_in)."</pre>");
1125 1125
     row("XML doc out", "<pre>".htmlspecialchars($result->xml_doc_out)."</pre>");
1126 1126
     row("stderr out", "<pre>"
1127 1127
         .htmlspecialchars(
1128 1128
             $result->stderr_out,
1129
-            ENT_QUOTES | (defined('ENT_SUBSTITUTE')?ENT_SUBSTITUTE:0),
1129
+            ENT_QUOTES|(defined('ENT_SUBSTITUTE') ?ENT_SUBSTITUTE:0),
1130 1130
             'utf-8'
1131 1131
         )
1132 1132
         ."</pre>"
@@ -1174,23 +1174,23 @@  discard block
 block discarded – undo
1174 1174
     } else {
1175 1175
         // result has not been received yet, so show report deadline either
1176 1176
         // in green if in the future or in red if in the past.
1177
-        $timenow=time();
1178
-        if ($result->report_deadline==0)  {
1177
+        $timenow = time();
1178
+        if ($result->report_deadline == 0) {
1179 1179
             // not sent -- show create time in purple
1180
-            $received = "<font color=\"9900cc\">". time_str($result->create_time) . "</font>";
1181
-        } else if ($result->report_deadline>=$timenow) {
1180
+            $received = "<font color=\"9900cc\">".time_str($result->create_time)."</font>";
1181
+        } else if ($result->report_deadline >= $timenow) {
1182 1182
             // overdue -- show deadline in red
1183
-            $received = "<font color=\"#33cc33\">". time_str($result->report_deadline) . "</font>";
1183
+            $received = "<font color=\"#33cc33\">".time_str($result->report_deadline)."</font>";
1184 1184
         } else {
1185 1185
             // in progress and not overdue -- show deadline in green
1186
-            $received = "<font color=\"#ff3333\">". time_str($result->report_deadline) . "</font>";
1186
+            $received = "<font color=\"#ff3333\">".time_str($result->report_deadline)."</font>";
1187 1187
         }
1188 1188
     }
1189 1189
     $version = app_version_string($result)." (<a href=\"db_action.php?table=app_version&id=$result->app_version_id\">$result->app_version_id</a>)";
1190 1190
     $outcome_color = outcome_color($result->outcome);
1191 1191
     $validate_color = validate_color($result->validate_state);
1192 1192
     $host_user = host_user_link($result->hostid);
1193
-    $cpu_hours = sprintf("%.1f",$result->cpu_time / 3600);
1193
+    $cpu_hours = sprintf("%.1f", $result->cpu_time/3600);
1194 1194
     $granted_credit = "<a href=credit.php?wu_id=$result->workunitid>".credit_str($result->granted_credit)."</a>";
1195 1195
     $delete_state = file_delete_state_str($result->file_delete_state);
1196 1196
 
@@ -1218,7 +1218,7 @@  discard block
 block discarded – undo
1218 1218
     row("ID", $user->id);
1219 1219
     row("Created", time_str($user->create_time));
1220 1220
     row("Name", $user->name);
1221
-    if(!in_rops()) {
1221
+    if (!in_rops()) {
1222 1222
         row("Authenticator", $user->authenticator);
1223 1223
     }
1224 1224
     row("Email address", $user->email_addr);
@@ -1233,7 +1233,7 @@  discard block
 block discarded – undo
1233 1233
     row("Default venue", $user->venue);
1234 1234
     row("Hosts", "<a href=\"db_action.php?table=host&userid=$user->id&detail=low\">click</a>");
1235 1235
     row("Cross project ID", $user->cross_project_id);
1236
-    if(!in_rops()) {
1236
+    if (!in_rops()) {
1237 1237
         row("Password Hash", $user->passwd_hash);
1238 1238
     }
1239 1239
     row("Donated", $user->donated);
@@ -1284,7 +1284,7 @@  discard block
 block discarded – undo
1284 1284
     echo "</table></td>";
1285 1285
     echo "<td><table border=\"2\">\n";
1286 1286
     echo "<tr><th>User</th><th># posts</th></tr>\n";
1287
-    for ($p=1; $p<=10; $p++) {
1287
+    for ($p = 1; $p <= 10; $p++) {
1288 1288
         row2_plain(user_links_ops($top10poster[$p]), $top10poster[$p]->posts);
1289 1289
     }
1290 1290
     echo "</table></td>";
@@ -1323,10 +1323,10 @@  discard block
 block discarded – undo
1323 1323
 function admin_show_team($team) {
1324 1324
     start_table();
1325 1325
     row("ID", $team->id);
1326
-    row("Team Founder", "<a href=\"db_action.php?table=user&id=$team->userid\">" . user_name_by_id($team->userid) . "</a>");
1326
+    row("Team Founder", "<a href=\"db_action.php?table=user&id=$team->userid\">".user_name_by_id($team->userid)."</a>");
1327 1327
     row("Name", $team->name);
1328
-    row("Name (HTML Formatted)", "<pre>" . htmlspecialchars($team->name_html) . "</pre>" );
1329
-    row("Url", "<a href=\"http://$team->url\">" . $team->url . "</a>");
1328
+    row("Name (HTML Formatted)", "<pre>".htmlspecialchars($team->name_html)."</pre>");
1329
+    row("Url", "<a href=\"http://$team->url\">".$team->url."</a>");
1330 1330
     row("Type", team_type_string($team->type));
1331 1331
     row("Description", $team->description);
1332 1332
     row("", "<a href=\"db_action.php?table=user&teamid=$team->id\">List All Members</a>");
@@ -1369,7 +1369,7 @@  discard block
 block discarded – undo
1369 1369
     if (!strlen($host->domain_name) && !strlen($host->last_ip_addr)) {
1370 1370
         return "(blank)";
1371 1371
     } else {
1372
-        return $host->domain_name . " (" . $host->last_ip_addr . ")";
1372
+        return $host->domain_name." (".$host->last_ip_addr.")";
1373 1373
     }
1374 1374
 }
1375 1375
 
Please login to merge, or discard this patch.
html/inc/result.inc 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
53 53
     return $platforms[$id];
54 54
 }
55 55
 
56
-function anon_platform_string($result, $rsc_name=null) {
56
+function anon_platform_string($result, $rsc_name = null) {
57 57
     $app = get_app($result->appid);
58
-    $n = $app->user_friendly_name."<br>".  tra("Anonymous platform");
58
+    $n = $app->user_friendly_name."<br>".tra("Anonymous platform");
59 59
     if ($rsc_name) {
60 60
         $n .= " ($rsc_name)";
61 61
     }
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         return $string_to_show;
98 98
     }
99 99
     if ($result->server_state <> RESULT_SERVER_STATE_OVER) return "---";
100
-    switch($result->outcome) {
100
+    switch ($result->outcome) {
101 101
     case RESULT_OUTCOME_SUCCESS:
102 102
         switch ($result->validate_state) {
103 103
         case VALIDATE_STATE_INIT:
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
             ) {
213 213
                 return tra("Not started by deadline - canceled");
214 214
             }
215
-            switch($result->client_state) {
215
+            switch ($result->client_state) {
216 216
             case RESULT_FILES_DOWNLOADING: return tra("Error while downloading");
217 217
             case RESULT_FILES_DOWNLOADED:
218 218
             case RESULT_COMPUTE_ERROR: return tra("Error while computing");
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 }
232 232
 
233 233
 function result_server_state_string($result) {
234
-    switch($result->server_state) {
234
+    switch ($result->server_state) {
235 235
     case RESULT_SERVER_STATE_INACTIVE: return tra("Inactive");
236 236
     case RESULT_SERVER_STATE_UNSENT: return tra("Unsent");
237 237
     case RESULT_SERVER_STATE_IN_PROGRESS: return tra("In progress");
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 }
242 242
 
243 243
 function result_outcome_string($result) {
244
-    switch($result->outcome) {
244
+    switch ($result->outcome) {
245 245
     case RESULT_OUTCOME_INIT: return "---";
246 246
     case RESULT_OUTCOME_SUCCESS: return tra("Success");
247 247
     case RESULT_OUTCOME_COULDNT_SEND: return tra("Couldn't send");
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 }
260 260
 
261 261
 function result_client_state_string($result) {
262
-    switch($result->client_state) {
262
+    switch ($result->client_state) {
263 263
     case RESULT_NEW: return tra("New");
264 264
     case RESULT_FILES_DOWNLOADING: return tra("Downloading");
265 265
     case RESULT_FILES_DOWNLOADED: return tra("Processing");
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 }
278 278
 
279 279
 function validate_state_str($result) {
280
-    switch($result->validate_state) {
280
+    switch ($result->validate_state) {
281 281
     case VALIDATE_STATE_INIT: return tra("Initial");
282 282
     case VALIDATE_STATE_VALID: return tra("Valid");
283 283
     case VALIDATE_STATE_INVALID:
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 }
294 294
 
295 295
 function assimilate_state_str($s) {
296
-    switch($s) {
296
+    switch ($s) {
297 297
     case ASSIMILATE_INIT: return "Initial";
298 298
     case ASSIMILATE_READY: return "Ready to assimilate";
299 299
     case ASSIMILATE_DONE: return "Assimilated";
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 }
303 303
 
304 304
 function file_delete_state_str($s) {
305
-    switch($s) {
305
+    switch ($s) {
306 306
     case FILE_DELETE_INIT: return "Initial";
307 307
     case FILE_DELETE_READY: return "Ready to delete";
308 308
     case FILE_DELETE_DONE: return "Deleted";
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 // convert WU error bitmask to str.
315 315
 // If $color, add HTML red color
316 316
 //
317
-function wu_error_mask_str($s, $color=false) {
317
+function wu_error_mask_str($s, $color = false) {
318 318
     $x = "";
319 319
     if ($s & WU_ERROR_COULDNT_SEND_RESULT) {
320 320
         $x = $x." ".tra("Couldn't send result");
@@ -428,10 +428,10 @@  discard block
 block discarded – undo
428 428
     if ($result->received_time) {
429 429
         $r = time_str($result->received_time);
430 430
     } else if ($result->report_deadline) {
431
-        if ($result->report_deadline>time()) {
432
-            $r = "<font color='#33cc33'>" . time_str($result->report_deadline) . "</font>";
431
+        if ($result->report_deadline > time()) {
432
+            $r = "<font color='#33cc33'>".time_str($result->report_deadline)."</font>";
433 433
         } else {
434
-            $r = "<font color='#ff3333'>" . time_str($result->report_deadline) . "</font>";
434
+            $r = "<font color='#ff3333'>".time_str($result->report_deadline)."</font>";
435 435
         }
436 436
     } else {
437 437
         $r = "---";
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
 // @param Integer $dec A signed integer
493 493
 //
494 494
 function int2hex($dec) {
495
-    return "0x".strtoupper(substr(sprintf("%08x",$dec), -8));
495
+    return "0x".strtoupper(substr(sprintf("%08x", $dec), -8));
496 496
 }
497 497
 
498 498
 // Decode a windows error number into semi-human-readable,
@@ -502,9 +502,9 @@  discard block
 block discarded – undo
502 502
 // @return String A human readable error message
503 503
 // @param Integer $x An error number
504 504
 //
505
-function windows_error_code_str($x){
506
-    $h=int2hex($x);
507
-    switch($h){
505
+function windows_error_code_str($x) {
506
+    $h = int2hex($x);
507
+    switch ($h) {
508 508
     case "0xC0000005": return "STATUS_ACCESS_VIOLATION";
509 509
     case "0xC000001D": return "STATUS_ILLEGAL_INSTRUCTION";
510 510
     case "0xC0000094": return "STATUS_INTEGER_DIVIDE_BY_ZERO";
@@ -525,10 +525,10 @@  discard block
 block discarded – undo
525 525
 // @return String A human readable error message
526 526
 // @param Integer $x An error number
527 527
 //
528
-function error_code_str($x){
528
+function error_code_str($x) {
529 529
     // severe Windows error numbers are always large negative integers
530
-    if ($x<-400) return windows_error_code_str($x);
531
-    switch($x){
530
+    if ($x < -400) return windows_error_code_str($x);
531
+    switch ($x) {
532 532
     case 0: return "";
533 533
     case 192: return "EXIT_STATEFILE_WRITE";
534 534
     case 193: return "EXIT_SIGNAL";
@@ -689,7 +689,7 @@  discard block
 block discarded – undo
689 689
     return $x." (".int2hex($x).") ".error_code_str($x);
690 690
 }
691 691
 
692
-function show_result($result, $show_outfile_links=false) {
692
+function show_result($result, $show_outfile_links = false) {
693 693
     start_table();
694 694
     row2(tra("Name"), $result->name);
695 695
     row2(tra("Workunit"), "<a href=\"workunit.php?wuid=$result->workunitid\">$result->workunitid</a>");
@@ -740,7 +740,7 @@  discard block
 block discarded – undo
740 740
     echo "<h3>".tra("Stderr output")."</h3> <pre>"
741 741
         .htmlspecialchars(
742 742
             $result->stderr_out,
743
-            ENT_QUOTES | (defined('ENT_SUBSTITUTE')?ENT_SUBSTITUTE:0),
743
+            ENT_QUOTES|(defined('ENT_SUBSTITUTE') ?ENT_SUBSTITUTE:0),
744 744
             'utf-8'
745 745
         )
746 746
         ."</pre>"
@@ -755,7 +755,7 @@  discard block
 block discarded – undo
755 755
 
756 756
     $apps = BoincApp::enum('deprecated=0 ORDER BY user_friendly_name');
757 757
 
758
-    for ($i=0; $i<NSTATES; $i++) {
758
+    for ($i = 0; $i < NSTATES; $i++) {
759 759
         $state_count[$i] = 0;
760 760
     }
761 761
     foreach ($apps as $app) {
@@ -798,7 +798,7 @@  discard block
 block discarded – undo
798 798
         $x .= "<a href=$url>".tra("Next")." ".$info->results_per_page."</a>";
799 799
     }
800 800
     $x .= "<br>".tra("State").": ";
801
-    for ($i=0; $i<NSTATES; $i++) {
801
+    for ($i = 0; $i < NSTATES; $i++) {
802 802
         if ($i) $x .= " &middot; ";
803 803
         if ($info->state == $i) {
804 804
             $x .= $state_name[$i];
@@ -843,6 +843,6 @@  discard block
 block discarded – undo
843 843
     return $x;
844 844
 }
845 845
 
846
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
846
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
847 847
 
848 848
 ?>
Please login to merge, or discard this patch.