BOINC / boinc

html/user/submit.php

Spacing +5 added lines, -5 removed lines

@@ -477,7 +477,7 @@ 
     if ($owner) {
         row2('submitter', $owner->name);
     }
-    row2("application", $app?$app->name:'---');
+    row2("application", $app ? $app->name : '---');
     row2("state", batch_state_string($batch->state));
     //row2("# jobs", $batch->njobs);
     //row2("# error jobs", $batch->nerror_jobs);
@@ -536,9 +536,9 @@ 
         "status"
     ];
     row_heading_array($x);
-    foreach($wus as $wu) {
+    foreach ($wus as $wu) {
         $y = '';
-        switch($wu->status) {
+        switch ($wu->status) {
         case WU_SUCCESS:
             $resultid = $wu->canonical_resultid;
             $y = '<font color="green">completed</font>';
@@ -611,7 +611,7 @@ 
     $results = BoincResult::enum("workunitid=$wuid");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         $x = [
             "<a href=result.php?resultid=$result->id>$result->id</a>",
             state_string($result)
@@ -620,7 +620,7 @@ 
         if ($result->server_state == RESULT_SERVER_STATE_OVER) {
             $phys_names = get_outfile_phys_names($result);
             $log_names = get_outfile_log_names($result);
-            for ($i=0; $i<count($phys_names); $i++) {
+            for ($i = 0; $i < count($phys_names); $i++) {
                 if ($is_assim_move) {
                     // file is in
                     // project/results/<batchid>/<wu_name>__file_<log_name>

html/user/buda_submit.php

Spacing +6 added lines, -6 removed lines

@@ -64,7 +64,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -115,7 +115,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -165,7 +165,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -175,7 +175,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -223,7 +223,7 @@ 
     }
     $wrapper_cmdline = sprintf('"--dockerfile %s %s %s"',
         $variant_desc->dockerfile,
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(
@@ -304,7 +304,7 @@ 
 
 // show list of BUDA apps and variants, with submission buttons
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     page_head('Submit BUDA jobs');
     text_start();

html/user/manage_project.php

Spacing +6 added lines, -6 removed lines

@@ -36,7 +36,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $sub = $names?implode(', ', $names):'---';
+        $sub = $names ?implode(', ', $names) : '---';
     }
     if ($u->manage_all) {
         $admin = 'All applications';
@@ -47,7 +47,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $admin = $names?implode(', ', $names):'---';
+        $admin = $names ?implode(', ', $names) : '---';
     }
 
     table_row(
@@ -59,7 +59,7 @@ 
         $admin,
         $u->quota,
         $u->max_jobs_in_progress,
-        ($u->logical_start_time > time())?local_time_str($u->logical_start_time):'---'
+        ($u->logical_start_time > time()) ?local_time_str($u->logical_start_time) : '---'
     );
 }
 
@@ -184,18 +184,18 @@ 
     $manage_apps = array_map('intval', $manage_apps);
     foreach ($apps as $app) {
         $s = in_array($app->id, $submit_apps);
-        $m = in_array($app->id, $manage_apps)?1:0;
+        $m = in_array($app->id, $manage_apps) ? 1 : 0;
         if ($s || $m) {
             BoincUserSubmitApp::insert(
                 "(user_id, app_id, manage) values ($user_id, $app->id, $m)"
             );
         }
     }
-    $quota = (double) get_str('quota');
+    $quota = (double)get_str('quota');
     if ($quota != $us->quota) {
         $us->update("quota=$quota");
     }
-    $mj = (int) get_str('max_jobs_in_progress');
+    $mj = (int)get_str('max_jobs_in_progress');
     if ($mj != $us->max_jobs_in_progress) {
         $us->update("max_jobs_in_progress=$mj");
     }

html/user/buda.php

Spacing +9 added lines, -9 removed lines

@@ -54,7 +54,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -256,7 +256,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <sticky/>\n      <no_delete/>\n      <executable/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";
@@ -286,7 +286,7 @@ 
     );
 
     $x .= sprintf("      <max_delay>%f</max_delay>\n",
-        $variant_desc->max_delay * 86400.
+        $variant_desc->max_delay*86400.
     );
 
     $x .= "   </workunit>\n<input_template>\n";
@@ -467,8 +467,8 @@ 
     }
 }
 
-function app_form($desc=null) {
-    page_head_select2($desc?"Edit BUDA app $desc->name":'Create BUDA app');
+function app_form($desc = null) {
+    page_head_select2($desc ? "Edit BUDA app $desc->name" : 'Create BUDA app');
     form_start('buda.php');
     form_input_hidden('action', 'app_action');
     if ($desc) {
@@ -479,22 +479,22 @@ 
         form_input_text('Internal name<br><small>No spaces</small>', 'name');
     }
     form_input_text('User-visible name', 'long_name',
-        $desc?$desc->long_name:null
+        $desc ? $desc->long_name : null
     );
     form_input_textarea(
         'Description<br><small>... of what the app does and of the research goals</small>',
         'description',
-        $desc?$desc->description:null
+        $desc ? $desc->description : null
     );
     form_select2_multi('Science keywords',
         'sci_kw',
         keyword_select_options(KW_CATEGORY_SCIENCE),
-        $desc?$desc->sci_kw:null
+        $desc ? $desc->sci_kw : null
     );
     form_input_text(
         'URL of web page describing app',
         'url',
-        $desc?$desc->url:''
+        $desc ? $desc->url : ''
     );
     // don't include location keywords;
     // various people may submit jobs to this app

html/inc/bootstrap.inc

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
                                 ];
                             } else {
                                 $x[] = [
-                                    "Manage $app->name",
+                                    "manage $app->name",
                                     "manage_project.php"
                                 ];
                             }

html/inc/submit_util.inc

Spacing +4 added lines, -4 removed lines

@@ -178,7 +178,7 @@ 
     foreach ($res_in_prog as $res) {
         $wus_in_prog[$res->workunitid] = true;
     }
-    unset($res_in_progress);    // does this do anything?
+    unset($res_in_progress); // does this do anything?
 
     $fp_total = 0;
     $fp_done = 0;
@@ -320,7 +320,7 @@ 
 // get the total size of output files of a batch
 //
 function batch_output_file_size($batchid) {
-    $batch_td_size=0;
+    $batch_td_size = 0;
     $wus = BoincWorkunit::enum("batch=$batchid");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
@@ -350,7 +350,7 @@ 
 }
 
 function boinc_get_wu_output_files_url($user, $wu_id) {
-    $auth_str =  md5($user->authenticator.$wu_id);
+    $auth_str = md5($user->authenticator.$wu_id);
     return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str";
 }
 
@@ -384,7 +384,7 @@ 
     if (!file_exists($path)) return null;
     $x = file_get_contents($path);
     $n = sscanf($x, "%s %d", $md5, $size);
-    if ($n != 2 || strlen($md5)!=32) {
+    if ($n != 2 || strlen($md5) != 32) {
         return null;
     }
     return [$md5, $size];

html/inc/boinc_db.inc

Indentation +3 added lines, -3 removed lines

@@ -362,12 +362,12 @@
         $db = BoincDb::get();
         return $db->enum('result', 'BoincResult', $where_clause);
     }
-	static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause=null) {
         $db = BoincDb::get();
-		return $db->enum_fields(
+        return $db->enum_fields(
             'result', 'BoincResult', $fields, $where_clause, $order_clause
         );
-	}
+    }
     function update($clause) {
         $db = BoincDb::get();
         return $db->update($this, 'result', $clause);

Spacing +20 added lines, -20 removed lines

@@ -44,8 +44,8 @@ 
 // close() closes the connection.
 
 class BoincDb {
-    static $instance;       // a DbConn object, or null
-    static $dbnum;          // which replica we're connected to
+    static $instance; // a DbConn object, or null
+    static $dbnum; // which replica we're connected to
 
     // connect to DB $dbnum (0, 1, ...)
     // If the requested DB doesn't exist or connection fails, connect to DB 0.
@@ -56,7 +56,7 @@ 
         self::$instance = null;
         $config = get_config();
         if ($dbnum) {
-            $r = $dbnum==1?'':strval($dbnum);
+            $r = $dbnum == 1 ? '' : strval($dbnum);
             $host = parse_config($config, sprintf('<replica%s_db_host>', $r));
             $name = parse_config($config, sprintf('<replica%s_db_name>', $r));
             $user = parse_config($config, sprintf('<replica%s_db_user>', $r));
@@ -204,11 +204,11 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'user', $clause);
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('user', 'BoincUser', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'user', 'BoincUser', $fields, $where_clause, $order_clause
@@ -258,7 +258,7 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'team', $clause);
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('team', 'BoincTeam', $where_clause, $order_clause);
     }
@@ -283,7 +283,7 @@ 
         $db = BoincDb::get();
         return $db->max('team', $field);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'team', 'BoincTeam', $fields, $where_clause, $order_clause
@@ -321,11 +321,11 @@ 
         $db = BoincDb::get();
         return $db->delete($this, 'host');
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('host', 'BoincHost', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'host', 'BoincHost', $fields, $where_clause, $order_clause
@@ -362,7 +362,7 @@ 
         $db = BoincDb::get();
         return $db->enum('result', 'BoincResult', $where_clause);
     }
-	static function enum_fields($fields, $where_clause, $order_clause=null) {
+	static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
 		return $db->enum_fields(
             'result', 'BoincResult', $fields, $where_clause, $order_clause
@@ -449,7 +449,7 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'app', $clause);
     }
-    static function sum($field, $clause=null) {
+    static function sum($field, $clause = null) {
         $db = BoincDb::get();
         return $db->sum('app', $field, $clause);
     }
@@ -507,11 +507,11 @@ 
         $db = BoincDb::get();
         return $db->insert('profile', $clause);
     }
-    static function enum($where_clause=null, $order_clause=null) {
+    static function enum($where_clause = null, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('profile', 'BoincProfile', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause=null, $order_clause=null) {
+    static function enum_fields($fields, $where_clause = null, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields('profile', 'BoincProfile', $fields, $where_clause, $order_clause);
     }
@@ -906,12 +906,12 @@ 
         return $db->enum('consent', 'BoincConsent', $where_clause);
     }
 
-    static function insert ($clause) {
+    static function insert($clause) {
         $db = BoincDb::get();
         return $db->insert('consent', $clause);
     }
 
-    static function update ($clause) {
+    static function update($clause) {
         $db = BoincDb::get();
         return $db->update_aux('consent', $clause);
     }
@@ -936,17 +936,17 @@ 
         return $db->lookup('consent_type', 'BoincConsentType', $clause);
     }
 
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('consent_type', 'BoincConsentType', $where_clause, $order_clause);
     }
 
-    static function insert ($clause) {
+    static function insert($clause) {
         $db = BoincDb::get();
         return $db->insert('consent_type', $clause);
     }
 
-    static function update ($clause) {
+    static function update($clause) {
         $db = BoincDb::get();
         return $db->update_aux('consent_type', $clause);
     }
@@ -972,7 +972,7 @@ 
         return $db->lookup('latest_consent', 'BoincLatestConsent', $clause);
     }
 
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('latest_consent', 'BoincLatestConsent', $where_clause, $order_clause);
     }
@@ -983,7 +983,7 @@ 
 // apply this to any user-supplied strings used in queries
 //
 function boinc_real_escape_string($x) {
-    if (version_compare(phpversion(),"4.3.0")>=0) {
+    if (version_compare(phpversion(), "4.3.0") >= 0) {
         return BoincDb::escape_string($x);
     } else {
         $x = str_replace("'", "\'", $x);