Passed
Push — dpa_buda10 ( f7dc44 )
by David
09:11
created
html/user/buda.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 // show list of BUDA apps and variants,
59 59
 // w/ buttons for adding and deleting
60 60
 //
61
-function app_list($notice=null) {
61
+function app_list($notice = null) {
62 62
     global $buda_root;
63 63
     if (!is_dir($buda_root)) {
64 64
         mkdir($buda_root);
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     $dir = "$buda_root/$app/$variant";
123 123
     start_table();
124 124
     table_header('name', 'size', 'md5');
125
-    foreach(scandir($dir) as $f) {
125
+    foreach (scandir($dir) as $f) {
126 126
         if ($f[0] == '.') continue;
127 127
         [$md5, $size] = parse_info_file("$dir/.md5/$f");
128 128
         table_row(
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     //
200 200
     $x = "<input_template>\n";
201 201
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
202
-    for ($i=0; $i<$ninfiles; $i++) {
202
+    for ($i = 0; $i < $ninfiles; $i++) {
203 203
         $x .= "   <file_info>\n      <sticky/>\n      <no_delete/>\n      <executable/>\n   </file_info>\n";
204 204
     }
205 205
     $x .= "   <workunit>\n";
Please login to merge, or discard this patch.
Upper-Lower-Casing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     if (!is_valid_filename($app)) die('bad arg');
119 119
     $variant = get_str('variant');
120 120
     if (!is_valid_filename($variant)) die('bad arg');
121
-    page_head("App $app variant $variant");
121
+    page_head("app $app variant $variant");
122 122
     $dir = "$buda_root/$app/$variant";
123 123
     start_table();
124 124
     table_header('name', 'size', 'md5');
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
     form_input_hidden('app', $app);
164 164
     form_input_hidden('action', 'variant_action');
165 165
     form_input_text('Plan class', 'variant');
166
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems);
166
+    form_select("dockerfile$sb", 'dockerfile', $sbitems);
167 167
     form_select_multiple("Application files$sb$sb2", 'app_files', $sbitems, null, 12);
168 168
     form_input_text(
169 169
         'Input file names<br><small>Space-separated</small>',
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     // Note: we don't currently allow indirect file access.
309 309
     // If we did, we'd need to create job.toml to mount project dir
310 310
 
311
-    app_list("Variant $variant added for app $app.");
311
+    app_list("variant $variant added for app $app.");
312 312
 }
313 313
 
314 314
 function variant_delete() {
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
         if ($ret) {
336 336
             error_page("delete failed");
337 337
         }
338
-        $notice = "Variant $variant of app $app removed.";
338
+        $notice = "variant $variant of app $app removed.";
339 339
         app_list($notice);
340 340
     } else {
341 341
         page_head("Confirm");
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
         if ($ret) {
365 365
             error_page('delete failed');
366 366
         }
367
-        $notice = "App $app removed.";
367
+        $notice = "app $app removed.";
368 368
         app_list($notice);
369 369
     } else {
370 370
         page_head('Confirm');
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
     }
396 396
     $dir = "$buda_root/$name";
397 397
     if (file_exists($dir)) {
398
-        error_page("App $name already exists.");
398
+        error_page("app $name already exists.");
399 399
     }
400 400
     mkdir($dir);
401 401
     header("Location: buda.php");
Please login to merge, or discard this patch.
html/inc/bootstrap.inc 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -141,12 +141,12 @@  discard block
 block discarded – undo
141 141
         // prefix for links; needed for pages not in top dir
142 142
     $user,
143 143
         // logged-in user, if any
144
-    $fixed=false,
144
+    $fixed = false,
145 145
         // if true, navbar is fixed at top of page.
146 146
         // NOTE: if you do this, you must set a global var $fixed_navbar
147 147
         // to true at compile time
148 148
         // (it needs to be set when page_head() is called).
149
-    $inverse=false
149
+    $inverse = false
150 150
         // white on black?
151 151
 ) {
152 152
     global $master_url;
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 // output a panel.
216 216
 // $content_func is a function that generates the panel contents
217 217
 //
218
-function panel($title, $content_func, $class="panel-primary", $body_class="") {
218
+function panel($title, $content_func, $class = "panel-primary", $body_class = "") {
219 219
     echo sprintf('<div class="panel %s">
220 220
         ', $class
221 221
     );
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 // $left_width is the width of left column in 1/12 units.
243 243
 // $arg is passed to the functions.
244 244
 //
245
-function grid($top_func, $left_func, $right_func, $left_width=6, $arg=null) {
245
+function grid($top_func, $left_func, $right_func, $left_width = 6, $arg = null) {
246 246
     echo '
247 247
         <div class="container-fluid">
248 248
     ';
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
             </div>
258 258
         ';
259 259
     }
260
-    $right_width = 12-$left_width;
260
+    $right_width = 12 - $left_width;
261 261
     echo '
262 262
         <div class="row">
263 263
         <div class="col-sm-'.$left_width.'">
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 //      use extra = "name=x"
282 282
 //      call forum_focus(x, foo) after defining the field
283 283
 //
284
-function form_start($action, $method='get', $extra='') {
284
+function form_start($action, $method = 'get', $extra = '') {
285 285
     echo sprintf(
286 286
         '<div class="container-fluid">
287 287
         <form class="form-horizontal" method="%s" action="%s" %s>'
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 // just the input field
314 314
 //
315 315
 function form_input_text_field(
316
-    $name, $value='', $type='text', $attrs='', $extra=''
316
+    $name, $value = '', $type = 'text', $attrs = '', $extra = ''
317 317
 ) {
318 318
     return sprintf(
319 319
         '<input %s type="%s" class="form-control" name="%s" value="%s">%s',
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 // the whole row
325 325
 //
326 326
 function form_input_text(
327
-    $label, $name, $value='', $type='text', $attrs='', $extra=''
327
+    $label, $name, $value = '', $type = 'text', $attrs = '', $extra = ''
328 328
 ) {
329 329
     echo sprintf('
330 330
         <div class="form-group">
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
     );
353 353
 }
354 354
 
355
-function form_input_textarea($label, $name, $value='', $nrows=4) {
355
+function form_input_textarea($label, $name, $value = '', $nrows = 4) {
356 356
     echo sprintf('
357 357
         <div class="form-group">
358 358
             <label align=right class="%s" for="%s">%s</label>
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
 
369 369
 // $items is either a string of <option> elements, or an array
370 370
 //
371
-function form_select($label, $name, $items, $selected=null) {
371
+function form_select($label, $name, $items, $selected = null) {
372 372
     echo sprintf('
373 373
         <div class="form-group">
374 374
             <label align=right class="%s" for="%s">%s</label>
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
         foreach ($items as $i) {
382 382
             echo sprintf(
383 383
                 '<option %s value=%s>%s</option>',
384
-                ($i[0]==$selected)?'selected':'',
384
+                ($i[0] == $selected) ? 'selected' : '',
385 385
                 $i[0], $i[1]
386 386
             );
387 387
         }
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 // same, for multiple select.
395 395
 // $selected, if non-null, is a list of selected values
396 396
 //
397
-function form_select_multiple($label, $name, $items, $selected=null, $size=0) {
397
+function form_select_multiple($label, $name, $items, $selected = null, $size = 0) {
398 398
     echo sprintf('
399 399
         <div class="form-group">
400 400
             <label align=right class="%s" for="%s">%s</label>
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
     foreach ($items as $i) {
407 407
         echo sprintf(
408 408
             '<option %s value=%s>%s</option>',
409
-            ($selected && in_array($i[0], $selected))?'selected':'',
409
+            ($selected && in_array($i[0], $selected)) ? 'selected' : '',
410 410
             $i[0], $i[1]
411 411
         );
412 412
     }
@@ -415,12 +415,12 @@  discard block
 block discarded – undo
415 415
 
416 416
 // return a list of string for checkbox items
417 417
 //
418
-function checkbox_item_strings($items, $attrs='') {
418
+function checkbox_item_strings($items, $attrs = '') {
419 419
     $x = [];
420 420
     foreach ($items as $i) {
421 421
         $x[] = sprintf('<input %s type="checkbox" name="%s" %s> %s
422 422
             ',
423
-            $attrs, $i[0], $i[2]?"checked":"", $i[1]
423
+            $attrs, $i[0], $i[2] ? "checked" : "", $i[1]
424 424
         );
425 425
     }
426 426
     return $x;
@@ -428,7 +428,7 @@  discard block
 block discarded – undo
428 428
 
429 429
 // $items is list of (name, label, checked)
430 430
 //
431
-function form_checkboxes($label, $items, $attrs='') {
431
+function form_checkboxes($label, $items, $attrs = '') {
432 432
     echo sprintf('
433 433
         <div class="form-group">
434 434
             <label align=right class="%s">%s</label>
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
         FORM_LEFT_CLASS, $label, FORM_RIGHT_CLASS
455 455
     );
456 456
     foreach ($items as $i) {
457
-        $checked = ($selected == $i[0])?"checked":"";
457
+        $checked = ($selected == $i[0]) ? "checked" : "";
458 458
         echo sprintf('<input type="radio" name="%s" value="%s" %s> %s <br>
459 459
             ',
460 460
             $name, $i[0], $checked, $i[1]
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
 ';
488 488
 }
489 489
 
490
-function form_submit($text, $attrs='') {
490
+function form_submit($text, $attrs = '') {
491 491
     form_general(
492 492
         "",
493 493
         sprintf(
@@ -497,7 +497,7 @@  discard block
 block discarded – undo
497 497
     );
498 498
 }
499 499
 
500
-function form_checkbox($label, $name, $checked=false) {
500
+function form_checkbox($label, $name, $checked = false) {
501 501
     echo sprintf('
502 502
         <div class="form-group">
503 503
             <label align=right class="%s">%s</label>
@@ -508,6 +508,6 @@  discard block
 block discarded – undo
508 508
     echo sprintf('
509 509
         <input type="checkbox" name="%s" %s>
510 510
         </div>
511
-        ', $name, $checked?"checked":""
511
+        ', $name, $checked ? "checked" : ""
512 512
     );
513 513
 }
Please login to merge, or discard this patch.