Passed
Pull Request — master (#5960)
by David
29:08 queued 18:37
created
html/user/buda_submit.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 //
62 62
 function unzip_batch_file($user, $batch_file) {
63 63
     @mkdir("../../buda_batches");
64
-    for ($i=0; $i<1000; $i++) {
64
+    for ($i = 0; $i < 1000; $i++) {
65 65
         $batch_dir = "../../buda_batches/$i";
66 66
         $batch_dir_name = $i;
67 67
         $ret = @mkdir($batch_dir);
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
         }
113 113
         $job_files = [];
114 114
         $cmdline = '';
115
-        foreach(scandir("$batch_dir/$fname") as $f2) {
115
+        foreach (scandir("$batch_dir/$fname") as $f2) {
116 116
             if ($f2[0] == '.') continue;
117 117
             if ($f2 == 'cmdline') {
118 118
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
163 163
     $n = count($batch_desc->shared_files);
164 164
     $batch_desc->shared_files_phys_names = [];
165
-    for ($i=0; $i<$n; $i++) {
165
+    for ($i = 0; $i < $n; $i++) {
166 166
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
167 167
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
168 168
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     foreach ($batch_desc->jobs as $job) {
173 173
         $n = count($batch_desc->unshared_files);
174 174
         $job->phys_names = [];
175
-        for ($i=0; $i<$n; $i++) {
175
+        for ($i = 0; $i < $n; $i++) {
176 176
             $path = sprintf('%s/%s/%s',
177 177
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
178 178
             );
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
     }
221 221
     $cw_cmdline = sprintf('"--dockerfile %s %s %s"',
222 222
         $variant_desc->dockerfile,
223
-        $wrapper_verbose?'--verbose':'',
223
+        $wrapper_verbose ? '--verbose' : '',
224 224
         $cmdline
225 225
     );
226 226
     $cmd = sprintf(
Please login to merge, or discard this patch.
html/user/buda.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 // show list of BUDA apps and variants,
33 33
 // w/ buttons for adding and deleting
34 34
 //
35
-function app_list($notice=null) {
35
+function app_list($notice = null) {
36 36
     global $buda_root;
37 37
     if (!is_dir($buda_root)) {
38 38
         mkdir($buda_root);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     $dir = "$buda_root/$app/$variant";
97 97
     start_table();
98 98
     table_header('name', 'size', 'md5');
99
-    foreach(scandir($dir) as $f) {
99
+    foreach (scandir($dir) as $f) {
100 100
         if ($f[0] == '.') continue;
101 101
         [$md5, $size] = parse_info_file("$dir/.md5/$f");
102 102
         table_row(
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     //
173 173
     $x = "<input_template>\n";
174 174
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
175
-    for ($i=0; $i<$ninfiles; $i++) {
175
+    for ($i = 0; $i < $ninfiles; $i++) {
176 176
         $x .= "   <file_info>\n      <no_delete/>\n   </file_info>\n";
177 177
     }
178 178
     $x .= "   <workunit>\n";
Please login to merge, or discard this patch.
html/inc/prefs_project.inc 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 }
71 71
 
72 72
 if ($app_types->cpu) {
73
-    $project_pref_descs[] = new PREF_BOOL (
73
+    $project_pref_descs[] = new PREF_BOOL(
74 74
         tra("Allow CPU-only tasks"),
75 75
         "Request CPU-only tasks from this project.",
76 76
         "no_cpu",
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     );
80 80
 }
81 81
 if ($app_types->ati) {
82
-    $project_pref_descs[] = new PREF_BOOL (
82
+    $project_pref_descs[] = new PREF_BOOL(
83 83
         tra("Use AMD GPU"),
84 84
         "Request AMD GPU tasks from this project.",
85 85
         "no_ati",
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     );
89 89
 }
90 90
 if ($app_types->cuda) {
91
-    $project_pref_descs[] = new PREF_BOOL (
91
+    $project_pref_descs[] = new PREF_BOOL(
92 92
         tra("Use NVIDIA GPU"),
93 93
         "Request NVIDIA GPU tasks from this project.",
94 94
         "no_cuda",
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     );
98 98
 }
99 99
 if ($app_types->intel_gpu) {
100
-    $project_pref_descs[] = new PREF_BOOL (
100
+    $project_pref_descs[] = new PREF_BOOL(
101 101
         tra("Use Intel GPU"),
102 102
         "Request Intel GPU tasks from this project.",
103 103
         "no_intel_gpu",
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     );
107 107
 }
108 108
 if ($app_types->apple_gpu) {
109
-    $project_pref_descs[] = new PREF_BOOL (
109
+    $project_pref_descs[] = new PREF_BOOL(
110 110
         tra("Use Apple GPU"),
111 111
         "Request Apple GPU tasks from this project.",
112 112
         "no_apple_gpu",
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     $x = "";
132 132
 }
133 133
 
134
-$privacy_pref_descs = array (
134
+$privacy_pref_descs = array(
135 135
     new PREF_BOOL(
136 136
         tra("Is it OK for %1 and your team (if any) to email you?", PROJECT).$x,
137 137
         "",
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     global $in_project_specific;
180 180
     global $venue_name;
181 181
 
182
-    switch($name) {
182
+    switch ($name) {
183 183
     case "venue":
184 184
         $venue_name = $attrs["name"];
185 185
         $top_parse_result = $parse_result;
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
         break;
192 192
     default:
193 193
         if ($in_project_specific) {
194
-            $text= $text."<$name>";
194
+            $text = $text."<$name>";
195 195
         } else {
196 196
             $text = "";
197 197
         }
@@ -206,12 +206,12 @@  discard block
 block discarded – undo
206 206
     global $venue_name;
207 207
     global $project_pref_descs;
208 208
 
209
-    foreach($project_pref_descs as $p) {
209
+    foreach ($project_pref_descs as $p) {
210 210
         if ($p->xml_parse($parse_result, $name, $text)) {
211 211
             return;
212 212
         }
213 213
     }
214
-    switch($name) {
214
+    switch ($name) {
215 215
     case "venue":
216 216
         $top_parse_result->$venue_name = $parse_result;
217 217
         $parse_result = $top_parse_result;
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     return $parse_result;
256 256
 }
257 257
 
258
-function prefs_show_project($prefs, $columns=false) {
258
+function prefs_show_project($prefs, $columns = false) {
259 259
     global $project_pref_descs;
260 260
     if ($columns) {
261 261
         foreach ($project_pref_descs as $p) {
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
     }
295 295
 }
296 296
 
297
-function prefs_show_project_specific($prefs, $columns=false) {
297
+function prefs_show_project_specific($prefs, $columns = false) {
298 298
     if ($columns) {
299 299
         $project_specific_prefs = project_specific_prefs_parse($prefs->project_specific);
300 300
         $project_specific_prefs->home = isset($prefs->home) ? project_specific_prefs_parse($prefs->home->project_specific) : "";
@@ -306,10 +306,10 @@  discard block
 block discarded – undo
306 306
     project_specific_prefs_show($project_specific_prefs, $columns);
307 307
 }
308 308
 
309
-function print_prefs_display_project($user, $columns=false) {
309
+function print_prefs_display_project($user, $columns = false) {
310 310
     $project_prefs = prefs_parse_project($user->project_prefs);
311 311
 
312
-    $switch_link = " <font size=\"-1\"><a href=prefs.php?subset=project&cols=". (int)!$columns .">".tra("(Switch View)")."</a></font>";
312
+    $switch_link = " <font size=\"-1\"><a href=prefs.php?subset=project&cols=".(int)!$columns.">".tra("(Switch View)")."</a></font>";
313 313
     if ($columns) {
314 314
         start_table();
315 315
         row_heading(tra("Combined preferences").$switch_link);
@@ -360,14 +360,14 @@  discard block
 block discarded – undo
360 360
     }
361 361
 }
362 362
 
363
-function prefs_form_project($prefs, $error=false) {
363
+function prefs_form_project($prefs, $error = false) {
364 364
     global $project_pref_descs;
365 365
     foreach ($project_pref_descs as $p) {
366 366
         $p->show_form_row($prefs, $error);
367 367
     }
368 368
 }
369 369
 
370
-function prefs_form_project_specific($prefs_xml, $error=false) {
370
+function prefs_form_project_specific($prefs_xml, $error = false) {
371 371
     $prefs = project_specific_prefs_parse($prefs_xml);
372 372
     project_specific_prefs_edit($prefs, $error);
373 373
 }
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 
416 416
 // given a prefs structure, return the corresponding XML string
417 417
 //
418
-function project_prefs_make_xml($prefs, $primary=true) {
418
+function project_prefs_make_xml($prefs, $primary = true) {
419 419
     global $project_pref_descs;
420 420
     $xml = "";
421 421
     if ($primary) {
@@ -450,8 +450,8 @@  discard block
 block discarded – undo
450 450
 //
451 451
 function project_prefs_update(&$user, $prefs) {
452 452
     $prefs_xml = BoincDb::escape_string(project_prefs_make_xml($prefs));
453
-    $send_email = $user->send_email?1:0;
454
-    $show_hosts = $user->show_hosts?1:0;
453
+    $send_email = $user->send_email ? 1 : 0;
454
+    $show_hosts = $user->show_hosts ? 1 : 0;
455 455
     $retval = $user->update("project_prefs='$prefs_xml', send_email=$send_email, show_hosts=$show_hosts");
456 456
     if (!$retval) {
457 457
         return 1;
Please login to merge, or discard this patch.