BCRM / www

src/BCRM/BackendBundle/Command/CreateTicketsCommand.php

Doc Comments +3 added lines

@@ -65,6 +65,9 @@
         $commandBus->handle($command);
     }
 
+    /**
+     * @param string $msg
+     */
     protected function logVerbose($msg)
     {
         if ($this->output->getVerbosity() < OutputInterface::VERBOSITY_VERBOSE) return;

Braces +3 added lines, -1 removed lines

@@ -67,7 +67,9 @@
 
     protected function logVerbose($msg)
     {
-        if ($this->output->getVerbosity() < OutputInterface::VERBOSITY_VERBOSE) return;
+        if ($this->output->getVerbosity() < OutputInterface::VERBOSITY_VERBOSE) {
+            return;
+        }
         $this->output->writeln($msg);
     }
 }

src/BCRM/BackendBundle/Command/SendTicketsMailCommand.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use BCRM\BackendBundle\Entity\Event\Event;
 use BCRM\BackendBundle\Exception\CommandException;
 use BCRM\BackendBundle\Service\Event\SendTicketMailCommand;
-use Doctrine\Common\Util\Debug;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;

src/BCRM/BackendBundle/Content/FileContentReader.php

Doc Comments +9 added lines, -1 removed lines

@@ -44,7 +44,7 @@ 
     }
 
     /**
-     * @param $path
+     * @param string $path
      *
      * @return \SplFileInfo
      */
@@ -71,6 +71,9 @@ 
         return $c;
     }
 
+    /**
+     * @param string $markdown
+     */
     protected function readProperties($markdown)
     {
         $properties = array();
@@ -81,6 +84,11 @@ 
         return $properties;
     }
 
+    /**
+     * @param string $markdown
+     *
+     * @return string
+     */
     protected function removeProperties($markdown)
     {
         return preg_replace(static::PROPERTIES_MATCH, '', $markdown);

Braces +6 added lines, -2 removed lines

@@ -52,7 +52,9 @@ 
     {
         $contentdir = $this->contentDir->getPathname() . DIRECTORY_SEPARATOR;
         $file       = $contentdir . $path;
-        if (!is_file($file)) throw new FileNotFoundException($path);
+        if (!is_file($file)) {
+            throw new FileNotFoundException($path);
+        }
         return new \SplFileInfo($file);
     }
 
@@ -74,7 +76,9 @@ 
     protected function readProperties($markdown)
     {
         $properties = array();
-        if (!preg_match_all(static::PROPERTIES_MATCH, $markdown, $matches, PREG_SET_ORDER)) return $properties;
+        if (!preg_match_all(static::PROPERTIES_MATCH, $markdown, $matches, PREG_SET_ORDER)) {
+            return $properties;
+        }
         foreach ($matches as $match) {
             $properties[$match[1]] = $match[2];
         }

Spacing +3 added lines, -3 removed lines

@@ -38,7 +38,7 @@ 
     {
         $file = $this->getFilePath($path);
         $info = new Info();
-        $info->setLastModified(new \DateTime('@' . filemtime($file)));
+        $info->setLastModified(new \DateTime('@'.filemtime($file)));
         $info->setEtag(md5_file($file));
         return $info;
     }
@@ -50,8 +50,8 @@ 
      */
     protected function getFilePath($path)
     {
-        $contentdir = $this->contentDir->getPathname() . DIRECTORY_SEPARATOR;
-        $file       = $contentdir . $path;
+        $contentdir = $this->contentDir->getPathname().DIRECTORY_SEPARATOR;
+        $file       = $contentdir.$path;
         if (!is_file($file)) throw new FileNotFoundException($path);
         return new \SplFileInfo($file);
     }

src/BCRM/BackendBundle/Entity/Event/Ticket.php

Doc Comments +1 added lines, -1 removed lines

@@ -251,7 +251,7 @@
     }
 
     /**
-     * @return \DateTime|null
+     * @return boolean
      */
     public function getCheckinTime()
     {

Spacing +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
         } else {
             $days[] = 'SU';
         }
-        $str .= ' (' . join('+', $days) . ')';
+        $str .= ' ('.join('+', $days).')';
         return $str;
     }
 

src/BCRM/BackendBundle/Service/Concierge.php

Doc Comments -1 removed lines

@@ -34,7 +34,6 @@
 
     /**
      * @param CommandBus             $commandBus
-     * @param RouterInterface        $router
      * @param PaymentRepository      $paymentRepo
      * @param RegistrationRepository $registrationRepo
      */

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use BCRM\BackendBundle\Service\Concierge\PayRegistrationConciergeCommand;
 use BCRM\BackendBundle\Entity\PaymentRepository;
 use BCRM\BackendBundle\Entity\Event\RegistrationRepository;
-use Endroid\QrCode\QrCode;
 use LiteCQRS\Bus\CommandBus;
 use LiteCQRS\Bus\EventMessageBus;
 use LiteCQRS\Plugin\CRUD\Model\Commands\UpdateResourceCommand;

src/BCRM/BackendBundle/Service/Mail.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use BCRM\BackendBundle\Service\Mail\SendTemplateMailCommand;
 use BCRM\BackendBundle\Content\ContentReader;
 use Symfony\Bridge\Twig\TwigEngine;
-use Symfony\Component\Templating\TemplateReference;
 
 class Mail
 {

Spacing +3 added lines, -3 removed lines

@@ -51,11 +51,11 @@ 
     {
         $message       = \Swift_Message::newInstance();
         $ext           = $command->format === 'text/html' ? 'html' : 'txt';
-        $tplIdentifier = 'Email/' . $command->template . '.' . $ext;
+        $tplIdentifier = 'Email/'.$command->template.'.'.$ext;
         $template      = $this->cr->getContent($tplIdentifier);
         $templateData  = $command->templateData;
         if ($command->image !== null) {
-            $templateData['image'] = $message->embed(\Swift_Image::fromPath($command->image));;
+            $templateData['image'] = $message->embed(\Swift_Image::fromPath($command->image)); ;
         }
 
         // Subject
@@ -64,7 +64,7 @@ 
         $subject = $env->render($subject, $templateData);
 
         // Body
-        $body = $this->templating->render('bcrm_content:' . $tplIdentifier, $templateData);
+        $body = $this->templating->render('bcrm_content:'.$tplIdentifier, $templateData);
         $message->setCharset('UTF-8');
         $message->setFrom($this->mailFromEmail, $this->mailFromName)
             ->setSubject($subject)

src/BCRM/PrintBundle/Command/PrintTicketsCommand.php

Unused Use Statements -5 removed lines

@@ -7,13 +7,8 @@
 
 namespace BCRM\PrintBundle\Command;
 
-use BCRM\BackendBundle\Entity\Event\Event;
-use BCRM\BackendBundle\Entity\Event\Registration;
 use BCRM\BackendBundle\Entity\Event\Ticket;
-use BCRM\BackendBundle\Exception\CommandException;
-use BCRM\BackendBundle\Service\Event\CreateTicketCommand;
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;

Spacing +5 added lines, -5 removed lines

@@ -64,9 +64,9 @@ 
             $data->lastname  = isset($nameParts[1]) ? $nameParts[1] : null;
             $data->day       = $ticket->day == Ticket::DAY_SATURDAY ? 'Sa' : 'So';
             $badge           = $env->render($template, (array)$data);
-            $badgeFileName   = sys_get_temp_dir() . DIRECTORY_SEPARATOR . $ticket->code;
-            $badgeSVG        = $badgeFileName . '.svg';
-            $badgePDF        = $badgeFileName . '.pdf';
+            $badgeFileName   = sys_get_temp_dir().DIRECTORY_SEPARATOR.$ticket->code;
+            $badgeSVG        = $badgeFileName.'.svg';
+            $badgePDF        = $badgeFileName.'.pdf';
             file_put_contents($badgeSVG, $badge);
             exec(
                 sprintf(
@@ -75,11 +75,11 @@ 
                     escapeshellarg($badgeSVG)
                 )
             );
-            $printFile = rtrim($input->getOption('output'), DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . $ticket->code . '.pdf';
+            $printFile = rtrim($input->getOption('output'), DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.$ticket->code.'.pdf';
             if (is_file($printFile)) {
                 $counter = 1;
                 do {
-                    $printFile = preg_replace('/(\.[0-9]+)*\.pdf$/', '.' . ($counter++) . '.pdf', $printFile);
+                    $printFile = preg_replace('/(\.[0-9]+)*\.pdf$/', '.'.($counter++).'.pdf', $printFile);
                 } while (is_file($printFile));
             }
             copy($badgePDF, $printFile);

src/BCRM/WebBundle/Content/PageContentReader.php

Doc Comments +7 added lines, -1 removed lines

@@ -79,6 +79,12 @@ 
         return $page;
     }
 
+    /**
+     * @param string $html
+     * @param string $page
+     *
+     * @return string
+     */
     protected function fixLinks($html, $page)
     {
         if (!preg_match_all('/src="([^"]+)"/', $html, $matches, PREG_SET_ORDER)) return $html;
@@ -91,7 +97,7 @@ 
     }
 
     /**
-     * @param $path
+     * @param string $path
      *
      * @return string
      * @see http://www.php.net/manual/en/function.realpath.php#81935

Braces +14 added lines, -5 removed lines

@@ -48,7 +48,9 @@ 
             $subNav = array();
             foreach ($this->getSubnav($this->getFilePath($path)) as $subPage) {
                 $s = $this->buildPage($subPage, false);
-                if ($s->isHidden()) continue;
+                if ($s->isHidden()) {
+                    continue;
+                }
                 $n = new Nav();
                 $n->setTitle($s->getProperties()->get('title'));
                 $n->setPath(str_replace('.md', '', $subPage));
@@ -81,7 +83,9 @@ 
 
     protected function fixLinks($html, $page)
     {
-        if (!preg_match_all('/src="([^"]+)"/', $html, $matches, PREG_SET_ORDER)) return $html;
+        if (!preg_match_all('/src="([^"]+)"/', $html, $matches, PREG_SET_ORDER)) {
+            return $html;
+        }
         $path = $this->contentPath . '/' . dirname($page) . '/';
         foreach ($matches as $match) {
             $srcpath = $this->normalizePath($path . $match[1]);
@@ -100,9 +104,14 @@ 
     {
         $out = array();
         foreach (explode('/', $path) as $i => $fold) {
-            if ($fold == '' || $fold == '.') continue;
-            if ($fold == '..' && $i > 0 && end($out) != '..') array_pop($out);
-            else $out[] = $fold;
+            if ($fold == '' || $fold == '.') {
+                continue;
+            }
+            if ($fold == '..' && $i > 0 && end($out) != '..') {
+                array_pop($out);
+            } else {
+                $out[] = $fold;
+            }
         }
         return ($path{0} == '/' ? '/' : '') . join('/', $out);
     }

Spacing +7 added lines, -7 removed lines

@@ -82,9 +82,9 @@ 
     protected function fixLinks($html, $page)
     {
         if (!preg_match_all('/src="([^"]+)"/', $html, $matches, PREG_SET_ORDER)) return $html;
-        $path = $this->contentPath . '/' . dirname($page) . '/';
+        $path = $this->contentPath.'/'.dirname($page).'/';
         foreach ($matches as $match) {
-            $srcpath = $this->normalizePath($path . $match[1]);
+            $srcpath = $this->normalizePath($path.$match[1]);
             $html    = str_replace($match[1], $srcpath, $html);
         }
         return $html;
@@ -104,16 +104,16 @@ 
             if ($fold == '..' && $i > 0 && end($out) != '..') array_pop($out);
             else $out[] = $fold;
         }
-        return ($path{0} == '/' ? '/' : '') . join('/', $out);
+        return ($path{0} == '/' ? '/' : '').join('/', $out);
     }
 
     protected function getSubnav(\SplFileInfo $file)
     {
-        $dir        = dirname($file->getPathname()) . DIRECTORY_SEPARATOR;
-        $contentdir = $this->contentDir->getPathname() . DIRECTORY_SEPARATOR;
-        return array_map(function ($entry) use ($contentdir) {
+        $dir        = dirname($file->getPathname()).DIRECTORY_SEPARATOR;
+        $contentdir = $this->contentDir->getPathname().DIRECTORY_SEPARATOR;
+        return array_map(function($entry) use ($contentdir) {
             $entry = str_replace($contentdir, '', $entry);
             return $entry;
-        }, glob($dir . '*.md'));
+        }, glob($dir.'*.md'));
     }
 }

src/BCRM/WebBundle/Controller/CheckinController.php

Unused Use Statements -4 removed lines

@@ -13,7 +13,6 @@ 
 use BCRM\BackendBundle\Entity\Event\Ticket;
 use BCRM\BackendBundle\Entity\Event\TicketRepository;
 use BCRM\BackendBundle\Service\Concierge\CheckinCommand;
-use BCRM\WebBundle\Content\ContentReader;
 use BCRM\WebBundle\Exception\AccesDeniedHttpException;
 use BCRM\WebBundle\Exception\BadRequestException;
 use Carbon\Carbon;
@@ -21,10 +20,7 @@ 
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Symfony\Component\Routing\RouterInterface;
-use Symfony\Component\Validator\Constraints\DateTime;
 
 /**
  * Manages event checkins.