Inspection of "shipping toggle shows no checkbox if setting not s..." - AyeCode/invoicing - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1f6dda...09085e )

by Brian

created 2023-05-08 09:20 UTC

Status

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@  discard block
 block discarded – undo
 defined( 'ABSPATH' ) || exit;
 
 if ( empty( $fields ) ) {
-	return;
+    return;
 }
 
 // A prefix for all ids (so that a form can be included in the same page multiple times).
@@ -18,12 +18,12 @@  discard block
 block discarded – undo
 
 // Prepare the user's country.
 if ( ! empty( $form->invoice ) ) {
-	$country = $form->invoice->get_country();
+    $country = $form->invoice->get_country();
 }
 
 if ( empty( $country ) ) {
-	$country = empty( $country ) ? getpaid_get_ip_country() : $country;
-	$country = empty( $country ) ? wpinv_get_default_country() : $country;
+    $country = empty( $country ) ? getpaid_get_ip_country() : $country;
+    $country = empty( $country ) ? wpinv_get_default_country() : $country;
 }
 
 // A prefix for all ids (so that a form can be included in the same page multiple times).
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
 	<!-- Start Billing Address -->
 	<div class="getpaid-billing-address-wrapper">
 		<?php
-			$field_type = 'billing';
-			include plugin_dir_path( __FILE__ ) . 'address-fields.php';
-			do_action( 'getpaid_after_payment_form_billing_fields', $form );
-		?>
+            $field_type = 'billing';
+            include plugin_dir_path( __FILE__ ) . 'address-fields.php';
+            do_action( 'getpaid_after_payment_form_billing_fields', $form );
+        ?>
 	</div>
 	<!-- End Billing Address -->
 
@@ -70,21 +70,21 @@  discard block
 block discarded – undo
 
 	<?php
 
-		aui()->input(
-		    array(
-			    'type'     => 'checkbox',
-			    'name'     => 'same-shipping-address',
-			    'id'       => "shipping-toggle$uniqid",
-			    'required' => false,
-			    'label'    => empty( $shipping_address_toggle ) ? esc_html__( 'Same billing & shipping address.', 'invoicing' ) : wp_kses_post( $shipping_address_toggle ),
-			    'value'    => 1,
-			    'checked'  => true,
-				'class'    => 'w-auto',
-		    ),
-			true
-		);
+        aui()->input(
+            array(
+                'type'     => 'checkbox',
+                'name'     => 'same-shipping-address',
+                'id'       => "shipping-toggle$uniqid",
+                'required' => false,
+                'label'    => empty( $shipping_address_toggle ) ? esc_html__( 'Same billing & shipping address.', 'invoicing' ) : wp_kses_post( $shipping_address_toggle ),
+                'value'    => 1,
+                'checked'  => true,
+                'class'    => 'w-auto',
+            ),
+            true
+        );
 
-	?>
+    ?>
 
 
 	<!-- Start Shipping Address Title -->
@@ -103,10 +103,10 @@  discard block
 block discarded – undo
 	<!-- Start Shipping Address -->
 	<div class="getpaid-shipping-address-wrapper">
 		<?php
-			$field_type = 'shipping';
-			include plugin_dir_path( __FILE__ ) . 'address-fields.php';
-			do_action( 'getpaid_after_payment_form_shipping_fields', $form );
-		?>
+            $field_type = 'shipping';
+            include plugin_dir_path( __FILE__ ) . 'address-fields.php';
+            do_action( 'getpaid_after_payment_form_shipping_fields', $form );
+        ?>
 	</div>
 	<!-- End Shipping Address -->
 

Please login to merge, or discard this patch.

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -7,57 +7,57 @@  discard block
 block discarded – undo
  * @version 1.0.19
  */
 
-defined( 'ABSPATH' ) || exit;
+defined('ABSPATH') || exit;
 
-if ( empty( $fields ) ) {
+if (empty($fields)) {
 	return;
 }
 
 // A prefix for all ids (so that a form can be included in the same page multiple times).
-$uniqid = uniqid( '_' );
+$uniqid = uniqid('_');
 
 // Prepare the user's country.
-if ( ! empty( $form->invoice ) ) {
+if (!empty($form->invoice)) {
 	$country = $form->invoice->get_country();
 }
 
-if ( empty( $country ) ) {
-	$country = empty( $country ) ? getpaid_get_ip_country() : $country;
-	$country = empty( $country ) ? wpinv_get_default_country() : $country;
+if (empty($country)) {
+	$country = empty($country) ? getpaid_get_ip_country() : $country;
+	$country = empty($country) ? wpinv_get_default_country() : $country;
 }
 
 // A prefix for all ids (so that a form can be included in the same page multiple times).
-$uniqid = uniqid( '_' );
+$uniqid = uniqid('_');
 
-$address_type = empty( $address_type ) ? 'billing' : $address_type;
+$address_type = empty($address_type) ? 'billing' : $address_type;
 
 ?>
 
-<?php if ( 'both' === $address_type ) : ?>
+<?php if ('both' === $address_type) : ?>
 
 	<!-- Start Billing/Shipping Address Title -->
 	<h4 class="mb-3 getpaid-shipping-billing-address-title">
-		<?php esc_html_e( 'Billing / Shipping Address', 'invoicing' ); ?>
+		<?php esc_html_e('Billing / Shipping Address', 'invoicing'); ?>
 	</h4>
 	<!-- End Billing Address Title -->
 
 	<!-- Start Billing Address Title -->
 	<h4 class="mb-3 getpaid-billing-address-title">
-		<?php esc_html_e( 'Billing Address', 'invoicing' ); ?>
+		<?php esc_html_e('Billing Address', 'invoicing'); ?>
 	</h4>
 	<!-- End Billing Address Title -->
 
 <?php endif; ?>
 
 
-<?php if ( 'both' === $address_type || 'billing' === $address_type ) : ?>
+<?php if ('both' === $address_type || 'billing' === $address_type) : ?>
 
 	<!-- Start Billing Address -->
 	<div class="getpaid-billing-address-wrapper">
 		<?php
 			$field_type = 'billing';
-			include plugin_dir_path( __FILE__ ) . 'address-fields.php';
-			do_action( 'getpaid_after_payment_form_billing_fields', $form );
+			include plugin_dir_path(__FILE__) . 'address-fields.php';
+			do_action('getpaid_after_payment_form_billing_fields', $form);
 		?>
 	</div>
 	<!-- End Billing Address -->
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 <?php endif; ?>
 
 
-<?php if ( 'both' === $address_type ) : ?>
+<?php if ('both' === $address_type) : ?>
 
 
 	<?php
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
 			    'name'     => 'same-shipping-address',
 			    'id'       => "shipping-toggle$uniqid",
 			    'required' => false,
-			    'label'    => empty( $shipping_address_toggle ) ? esc_html__( 'Same billing & shipping address.', 'invoicing' ) : wp_kses_post( $shipping_address_toggle ),
+			    'label'    => empty($shipping_address_toggle) ? esc_html__('Same billing & shipping address.', 'invoicing') : wp_kses_post($shipping_address_toggle),
 			    'value'    => 1,
 			    'checked'  => true,
 				'class'    => 'w-auto',
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
 
 	<!-- Start Shipping Address Title -->
 	<h4 class="mb-3 getpaid-shipping-address-title">
-		<?php esc_html_e( 'Shipping Address', 'invoicing' ); ?>
+		<?php esc_html_e('Shipping Address', 'invoicing'); ?>
 	</h4>
 	<!-- End Shipping Address Title -->
 
@@ -98,14 +98,14 @@  discard block
 block discarded – undo
 
 
 	
-<?php if ( 'both' === $address_type || 'shipping' === $address_type ) : ?>
+<?php if ('both' === $address_type || 'shipping' === $address_type) : ?>
 
 	<!-- Start Shipping Address -->
 	<div class="getpaid-shipping-address-wrapper">
 		<?php
 			$field_type = 'shipping';
-			include plugin_dir_path( __FILE__ ) . 'address-fields.php';
-			do_action( 'getpaid_after_payment_form_shipping_fields', $form );
+			include plugin_dir_path(__FILE__) . 'address-fields.php';
+			do_action('getpaid_after_payment_form_shipping_fields', $form);
 		?>
 	</div>
 	<!-- End Shipping Address -->

Please login to merge, or discard this patch.

		@@ -7,57 +7,57 @@ discard block
		block discarded – undo
7	7	* @version 1.0.19
8	8	*/
9	9
10		-defined( 'ABSPATH' ) \|\| exit;
	10	+defined('ABSPATH') \|\| exit;
11	11
12		-if ( empty( $fields ) ) {
	12	+if (empty($fields)) {
13	13	return;
14	14	}
15	15
16	16	// A prefix for all ids (so that a form can be included in the same page multiple times).
17		-$uniqid = uniqid( '_' );
	17	+$uniqid = uniqid('_');
18	18
19	19	// Prepare the user's country.
20		-if ( ! empty( $form->invoice ) ) {
	20	+if (!empty($form->invoice)) {
21	21	$country = $form->invoice->get_country();
22	22	}
23	23
24		-if ( empty( $country ) ) {
25		- $country = empty( $country ) ? getpaid_get_ip_country() : $country;
26		- $country = empty( $country ) ? wpinv_get_default_country() : $country;
	24	+if (empty($country)) {
	25	+ $country = empty($country) ? getpaid_get_ip_country() : $country;
	26	+ $country = empty($country) ? wpinv_get_default_country() : $country;
27	27	}
28	28
29	29	// A prefix for all ids (so that a form can be included in the same page multiple times).
30		-$uniqid = uniqid( '_' );
	30	+$uniqid = uniqid('_');
31	31
32		-$address_type = empty( $address_type ) ? 'billing' : $address_type;
	32	+$address_type = empty($address_type) ? 'billing' : $address_type;
33	33
34	34	?>
35	35
36		-<?php if ( 'both' === $address_type ) : ?>
	36	+<?php if ('both' === $address_type) : ?>
37	37
38	38	<!-- Start Billing/Shipping Address Title -->
39	39	<h4 class="mb-3 getpaid-shipping-billing-address-title">
40		- <?php esc_html_e( 'Billing / Shipping Address', 'invoicing' ); ?>
	40	+ <?php esc_html_e('Billing / Shipping Address', 'invoicing'); ?>
41	41	</h4>
42	42	<!-- End Billing Address Title -->
43	43
44	44	<!-- Start Billing Address Title -->
45	45	<h4 class="mb-3 getpaid-billing-address-title">
46		- <?php esc_html_e( 'Billing Address', 'invoicing' ); ?>
	46	+ <?php esc_html_e('Billing Address', 'invoicing'); ?>
47	47	</h4>
48	48	<!-- End Billing Address Title -->
49	49
50	50	<?php endif; ?>
51	51
52	52
53		-<?php if ( 'both' === $address_type \|\| 'billing' === $address_type ) : ?>
	53	+<?php if ('both' === $address_type \|\| 'billing' === $address_type) : ?>
54	54
55	55	<!-- Start Billing Address -->
56	56	<div class="getpaid-billing-address-wrapper">
57	57	<?php
58	58	$field_type = 'billing';
59		- include plugin_dir_path( __FILE__ ) . 'address-fields.php';
60		- do_action( 'getpaid_after_payment_form_billing_fields', $form );
	59	+ include plugin_dir_path(__FILE__) . 'address-fields.php';
	60	+ do_action('getpaid_after_payment_form_billing_fields', $form);
61	61	?>
62	62	</div>
63	63	<!-- End Billing Address -->
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	<?php endif; ?>
66	66
67	67
68		-<?php if ( 'both' === $address_type ) : ?>
	68	+<?php if ('both' === $address_type) : ?>
69	69
70	70
71	71	<?php
		@@ -76,7 +76,7 @@ discard block
		block discarded – undo
76	76	'name' => 'same-shipping-address',
77	77	'id' => "shipping-toggle$uniqid",
78	78	'required' => false,
79		- 'label' => empty( $shipping_address_toggle ) ? esc_html__( 'Same billing & shipping address.', 'invoicing' ) : wp_kses_post( $shipping_address_toggle ),
	79	+ 'label' => empty($shipping_address_toggle) ? esc_html__('Same billing & shipping address.', 'invoicing') : wp_kses_post($shipping_address_toggle),
80	80	'value' => 1,
81	81	'checked' => true,
82	82	'class' => 'w-auto',
		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89
90	90	<!-- Start Shipping Address Title -->
91	91	<h4 class="mb-3 getpaid-shipping-address-title">
92		- <?php esc_html_e( 'Shipping Address', 'invoicing' ); ?>
	92	+ <?php esc_html_e('Shipping Address', 'invoicing'); ?>
93	93	</h4>
94	94	<!-- End Shipping Address Title -->
95	95
		@@ -98,14 +98,14 @@ discard block
		block discarded – undo
98	98
99	99
100	100
101		-<?php if ( 'both' === $address_type \|\| 'shipping' === $address_type ) : ?>
	101	+<?php if ('both' === $address_type \|\| 'shipping' === $address_type) : ?>
102	102
103	103	<!-- Start Shipping Address -->
104	104	<div class="getpaid-shipping-address-wrapper">
105	105	<?php
106	106	$field_type = 'shipping';
107		- include plugin_dir_path( __FILE__ ) . 'address-fields.php';
108		- do_action( 'getpaid_after_payment_form_shipping_fields', $form );
	107	+ include plugin_dir_path(__FILE__) . 'address-fields.php';
	108	+ do_action('getpaid_after_payment_form_shipping_fields', $form);
109	109	?>
110	110	</div>
111	111	<!-- End Shipping Address -->

		@@ -10,7 +10,7 @@ discard block
		block discarded – undo
10	10	defined( 'ABSPATH' ) \|\| exit;
11	11
12	12	if ( empty( $fields ) ) {
13		- return;
	13	+ return;
14	14	}
15	15
16	16	// A prefix for all ids (so that a form can be included in the same page multiple times).
		@@ -18,12 +18,12 @@ discard block
		block discarded – undo
18	18
19	19	// Prepare the user's country.
20	20	if ( ! empty( $form->invoice ) ) {
21		- $country = $form->invoice->get_country();
	21	+ $country = $form->invoice->get_country();
22	22	}
23	23
24	24	if ( empty( $country ) ) {
25		- $country = empty( $country ) ? getpaid_get_ip_country() : $country;
26		- $country = empty( $country ) ? wpinv_get_default_country() : $country;
	25	+ $country = empty( $country ) ? getpaid_get_ip_country() : $country;
	26	+ $country = empty( $country ) ? wpinv_get_default_country() : $country;
27	27	}
28	28
29	29	// A prefix for all ids (so that a form can be included in the same page multiple times).
		@@ -55,10 +55,10 @@ discard block
		block discarded – undo
55	55	<!-- Start Billing Address -->
56	56	<div class="getpaid-billing-address-wrapper">
57	57	<?php
58		- $field_type = 'billing';
59		- include plugin_dir_path( __FILE__ ) . 'address-fields.php';
60		- do_action( 'getpaid_after_payment_form_billing_fields', $form );
61		- ?>
	58	+ $field_type = 'billing';
	59	+ include plugin_dir_path( __FILE__ ) . 'address-fields.php';
	60	+ do_action( 'getpaid_after_payment_form_billing_fields', $form );
	61	+ ?>
62	62	</div>
63	63	<!-- End Billing Address -->
64	64
		@@ -70,21 +70,21 @@ discard block
		block discarded – undo
70	70
71	71	<?php
72	72
73		- aui()->input(
74		- array(
75		- 'type' => 'checkbox',
76		- 'name' => 'same-shipping-address',
77		- 'id' => "shipping-toggle$uniqid",
78		- 'required' => false,
79		- 'label' => empty( $shipping_address_toggle ) ? esc_html__( 'Same billing & shipping address.', 'invoicing' ) : wp_kses_post( $shipping_address_toggle ),
80		- 'value' => 1,
81		- 'checked' => true,
82		- 'class' => 'w-auto',
83		- ),
84		- true
85		- );
	73	+ aui()->input(
	74	+ array(
	75	+ 'type' => 'checkbox',
	76	+ 'name' => 'same-shipping-address',
	77	+ 'id' => "shipping-toggle$uniqid",
	78	+ 'required' => false,
	79	+ 'label' => empty( $shipping_address_toggle ) ? esc_html__( 'Same billing & shipping address.', 'invoicing' ) : wp_kses_post( $shipping_address_toggle ),
	80	+ 'value' => 1,
	81	+ 'checked' => true,
	82	+ 'class' => 'w-auto',
	83	+ ),
	84	+ true
	85	+ );
86	86
87		- ?>
	87	+ ?>
88	88
89	89
90	90	<!-- Start Shipping Address Title -->
		@@ -103,10 +103,10 @@ discard block
		block discarded – undo
103	103	<!-- Start Shipping Address -->
104	104	<div class="getpaid-shipping-address-wrapper">
105	105	<?php
106		- $field_type = 'shipping';
107		- include plugin_dir_path( __FILE__ ) . 'address-fields.php';
108		- do_action( 'getpaid_after_payment_form_shipping_fields', $form );
109		- ?>
	106	+ $field_type = 'shipping';
	107	+ include plugin_dir_path( __FILE__ ) . 'address-fields.php';
	108	+ do_action( 'getpaid_after_payment_form_shipping_fields', $form );
	109	+ ?>
110	110	</div>
111	111	<!-- End Shipping Address -->
112	112

AyeCode / invoicing

Push — master ( 1f6dda...09085e )

Status

Category

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch