Summary - Inspection of "New Regex For AMP Icon Replacement" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

jetpack

Completed

unknown

created 2020-04-21 11:46 UTC

There were no notable changes in the changeset which was inspected.

4.9

▶ ± 0

Head	Matt Geri 2020-04-21 13:44 GMT+0200 New Regex For AMP Icon Replacement - The old regex was not working when markup (specifically a div) was included inside the list item. It would cut the replace too early and show markup on the page that should not be shown. - New regex replaces the whole unordered list with the AMP icons
Base	Matt Geri 2020-04-21 11:12 UTC Review Fixes * Change hook for enqueuing assets * Change social icons to a dependency * Remove spaces in favour of tabs

Automattic / jetpack