Audiens / adobe-client

src/Auth.php

Doc Comments +6 added lines, -6 removed lines

@@ -41,10 +41,10 @@ 
 
     /**
      * Auth constructor.
-     * @param $clientId
-     * @param $secretKey
-     * @param $username
-     * @param $password
+     * @param string $clientId
+     * @param string $secretKey
+     * @param string $username
+     * @param string $password
      * @param ClientInterface $clientInterface
      * @param AuthStrategyInterface $authStrategy
      */
@@ -67,10 +67,10 @@ 
 
     /**
      * @param string $method
-     * @param null   $uri
+     * @param string   $uri
      * @param array  $options
      *
-     * @return mixed|\Psr\Http\Message\ResponseInterface
+     * @return \Psr\Http\Message\ResponseInterface
      * @throws \Exception
      */
     public function request($method, $uri = null, array $options = [])

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
 
         $optionForToken = [
             'headers' => [
-                'Authorization' =>  ['Bearer '.$this->authStrategy->authenticate($this->clientId, $this->secretKey, $this->username, $this->password)],
+                'Authorization' =>  ['Bearer ' . $this->authStrategy->authenticate($this->clientId, $this->secretKey, $this->username, $this->password)],
             ],
         ];
 
@@ -93,7 +93,7 @@ 
 
         $optionForToken = [
             'headers' => [
-                'Authorization' =>  ['Bearer '.$this->authStrategy->authenticate($this->clientId, $this->secretKey, $this->username, $this->password, true, true)],
+                'Authorization' =>  ['Bearer ' . $this->authStrategy->authenticate($this->clientId, $this->secretKey, $this->username, $this->password, true, true)],
             ],
         ];
 

src/Authentication/AdnxStrategy.php

Doc Comments +3 added lines, -1 removed lines

@@ -26,7 +26,7 @@ 
      * AdnxStrategy constructor.
      *
      * @param ClientInterface $clientInterface
-     * @param Cache|null $cache
+     * @param Cache $cache
      */
     public function __construct(ClientInterface $clientInterface, Cache $cache)
     {
@@ -39,6 +39,8 @@ 
      * @param string $password
      * @param bool $cache
      * @param bool $refresh
+     * @param string $clientId
+     * @param string $secretKey
      * @return mixed
      * @throws AuthException
      */

src/Authentication/SandboxStrategy.php

Doc Comments +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
      * AdnxStrategy constructor.
      *
      * @param ClientInterface $clientInterface
-     * @param Cache|null $cache
+     * @param Cache $cache
      */
     public function __construct(ClientInterface $clientInterface, Cache $cache)
     {
@@ -39,7 +39,7 @@ 
      * @param string $clientId
      * @param string $secretKey
      * @param string $username
-     * @param $password
+     * @param string $password
      * @param bool $cache
      * @param bool $refresh
      * @return mixed

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Audiens\AdobeClient\Authentication;
 
-use Audiens\AdobeClient\Auth;
 use Audiens\AdobeClient\Exception\AuthException;
 use Doctrine\Common\Cache\Cache;
 use GuzzleHttp\ClientInterface;

src/Repository/TraitRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -93,7 +93,7 @@ 
 
 
     /**
-     * @param $id
+     * @param integer $id
      *
      * @return Traits|null
      */
@@ -159,7 +159,7 @@ 
     }
 
     /**
-     * @param $sid
+     * @param integer $sid
      * @param \DateTime $startDate
      * @param \DateTime $endDate
      * @param string $dayInterval

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Audiens\AdobeClient\Repository;
 
-use Audiens\AdobeClient\Auth;
 use Audiens\AdobeClient\CachableTrait;
 use Audiens\AdobeClient\CacheableInterface;
 use Audiens\AdobeClient\Entity\TraitMetrics;

Spacing +1 added lines, -1 removed lines

@@ -168,7 +168,7 @@
      */
     public function getTrendByTrait($sid, \DateTime $startDate, \DateTime $endDate, $dayInterval = '1D')
     {
-        $cacheKey = self::CACHE_NAMESPACE . sha1($startDate->getTimestamp().$endDate->getTimestamp());
+        $cacheKey = self::CACHE_NAMESPACE . sha1($startDate->getTimestamp() . $endDate->getTimestamp());
 
         if ($this->isCacheEnabled()) {
             if ($this->cache->contains($cacheKey)) {

Test/FunctionalTestCase.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Test;
 
 use Audiens\AdobeClient\Auth;
-use Audiens\AdobeClient\Authentication\AdnxStrategy;
 use Audiens\AdobeClient\Authentication\SandboxStrategy;
 use Audiens\AdobeClient\Repository\TraitRepository;
 use Doctrine\Common\Cache\FilesystemCache;

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
     {
 
         try {
-            $dotenv = new Dotenv(__DIR__.'/../');
+            $dotenv = new Dotenv(__DIR__ . '/../');
             $dotenv->load();
         } catch (\Exception $e) {
         }

Test/Functional/TraitRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 
             $this->assertNotEmpty($trait->getMetrics());
 
-            foreach($trait->getMetrics() as $metric)
+            foreach ($trait->getMetrics() as $metric)
             {
                 $this->assertInstanceOf(TraitMetrics::class, $metric);
             }

src/Exception/RepositoryException.php

Spacing +1 added lines, -1 removed lines

@@ -37,6 +37,6 @@
      */
     public static function missingSid($trait)
     {
-        return new self('Missing sid for '.serialize($trait->getName()));
+        return new self('Missing sid for ' . serialize($trait->getName()));
     }
 }

src/Exception/AuthException.php

Spacing +1 added lines, -1 removed lines

@@ -17,6 +17,6 @@
      */
     public static function authFailed($reason)
     {
-        return new self(self::DEFAULT_MESSAGE.$reason, 0, null);
+        return new self(self::DEFAULT_MESSAGE . $reason, 0, null);
     }
 }