Atriedes / feature

src/Feature/Config.php

Doc Comments +17 added lines

@@ -190,6 +190,11 @@ 
      * variantFor, in which case we want to perform some certain
      * sanity checks to make sure the code is being used correctly.
      */
+
+    /**
+     * @param integer $userId
+     * @param boolean $inVariantMethod
+     */
     private function chooseVariant($bucketingId, $userId, $inVariantMethod)
     {
         if ($inVariantMethod && $this->enabled === self::ON) {
@@ -362,6 +367,10 @@ 
      * should see each variant to map a randomish number to a
      * particular variant.
      */
+
+    /**
+     * @param string $id
+     */
     private function variantByPercentage($id)
     {
         $n = 100 * $this->randomish($id);
@@ -447,6 +456,10 @@ 
      * feature's config stanza, returning an array mappinng the user
      * or group names to they variant they should see.
      */
+
+    /**
+     * @param string $what
+     */
     private function parseUsersOrGroups($stanza, $what)
     {
         $value = Util::arrayGet($stanza, $what);
@@ -487,6 +500,10 @@ 
      * properties. If non-falsy, must be one of the keys in the
      * enabled map unless enabled is 'on' or 'off'.
      */
+
+    /**
+     * @param string $what
+     */
     private function parseVariantName($stanza, $what)
     {
         $value = Util::arrayGet($stanza, $what);

Spacing +4 added lines, -11 removed lines

@@ -22,7 +22,7 @@ 
     const BUCKETING           = 'bucketing';
 
     /* Special values for enabled property. */
-    const ON  = 'on';  /* Feature is fully enabled. */
+    const ON  = 'on'; /* Feature is fully enabled. */
     const OFF = 'off'; /* Feature is fully disabled. */
 
     /* Bucketing schemes. */
@@ -209,7 +209,7 @@ 
                 );
             }
 
-            $bucketingId = (string)$bucketingId;
+            $bucketingId = (string) $bucketingId;
             if (array_key_exists($bucketingId, $this->cache)) {
                 // Note that this caching is not just an optimization:
                 // it prevents us from double logging a single
@@ -223,13 +223,7 @@ 
                 return $this->cache[$bucketingId];
             } else {
                 list($v, $selector) =
-                    $this->variantFromURL($userId) ?:
-                        $this->variantForUser($userId) ?:
-                            $this->variantForGroup($userId) ?:
-                                $this->variantForAdmin($userId) ?:
-                                    $this->variantForInternal() ?:
-                                        $this->variantByPercentage($bucketingId) ?:
-                                            array(self::OFF, 'w');
+                    $this->variantFromURL($userId) ?: $this->variantForUser($userId) ?: $this->variantForGroup($userId) ?: $this->variantForAdmin($userId) ?: $this->variantForInternal() ?: $this->variantByPercentage($bucketingId) ?: array(self::OFF, 'w');
 
                 if ($inVariantMethod && $v === self::OFF) {
                     $this->error("Variant check outside enabled check");
@@ -465,8 +459,7 @@ 
         } elseif (is_array($value)) {
             $result = array();
             $bad_keys = is_array($this->enabled) ?
-                array_keys(array_diff_key($value, $this->enabled)) :
-                array();
+                array_keys(array_diff_key($value, $this->enabled)) : array();
             if (!$bad_keys) {
                 foreach ($value as $variant => $whos) {
                     foreach (self::asArray($whos) as $who) {

src/Feature/Util.php

Doc Comments +4 added lines, -4 removed lines

@@ -10,7 +10,7 @@ 
 class Util
 {
     /**
-     * @return float
+     * @return integer
      */
     public static function random()
     {
@@ -18,8 +18,8 @@ 
     }
 
     /**
-     * @param $id
-     * @return float
+     * @param string $id
+     * @return integer
      */
     public static function randomById($id)
     {
@@ -39,7 +39,7 @@ 
 
     /**
      * @param string $hex
-     * @return float
+     * @return integer
      */
     private static function mapHex($hex)
     {