Completed
Pull Request — master (#8)
by Micheal
10:27 queued 08:57
created
Providers/RouteServiceProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
     protected $namespace = 'Modules\Notification\Http\Controllers';
12 12
 
13 13
     /**
14
-     * @return string
14
+     * @return boolean
15 15
      */
16 16
     protected function getFrontendRoute()
17 17
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
      */
24 24
     protected function getBackendRoute()
25 25
     {
26
-        return __DIR__ . '/../Http/backendRoutes.php';
26
+        return __DIR__.'/../Http/backendRoutes.php';
27 27
     }
28 28
 
29 29
     /**
@@ -31,6 +31,6 @@  discard block
 block discarded – undo
31 31
      */
32 32
     protected function getApiRoute()
33 33
     {
34
-        return __DIR__ . '/../Http/apiRoutes.php';
34
+        return __DIR__.'/../Http/apiRoutes.php';
35 35
     }
36 36
 }
Please login to merge, or discard this patch.
Database/Migrations/2015_11_17_154243_create_notifications_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
      */
12 12
     public function up()
13 13
     {
14
-        Schema::create('notification__notifications', function (Blueprint $table) {
14
+        Schema::create('notification__notifications', function(Blueprint $table) {
15 15
             $table->increments('id');
16 16
             $table->integer('user_id')->unsigned();
17 17
             $table->string('type')->nullable();
Please login to merge, or discard this patch.
Entities/Notification.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@
 block discarded – undo
16 16
 class Notification extends Model
17 17
 {
18 18
     protected $table = 'notification__notifications';
19
-    protected $fillable = ['user_id', 'type', 'message', 'icon_class', 'link', 'is_read', 'title'];
20
-    protected $appends = ['time_ago'];
19
+    protected $fillable = [ 'user_id', 'type', 'message', 'icon_class', 'link', 'is_read', 'title' ];
20
+    protected $appends = [ 'time_ago' ];
21 21
 
22 22
     /**
23 23
      * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
Please login to merge, or discard this patch.
Repositories/Eloquent/EloquentNotificationRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,6 +74,6 @@
 block discarded – undo
74 74
      */
75 75
     public function markAllAsReadForUser($userId)
76 76
     {
77
-        return $this->model->whereUserId($userId)->update(['is_read' => true]);
77
+        return $this->model->whereUserId($userId)->update([ 'is_read' => true ]);
78 78
     }
79 79
 }
Please login to merge, or discard this patch.
Events/BroadcastNotification.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,6 +25,6 @@
 block discarded – undo
25 25
      */
26 26
     public function broadcastOn()
27 27
     {
28
-        return ['asgardcms.notifications.' . $this->notification->user_id];
28
+        return [ 'asgardcms.notifications.'.$this->notification->user_id ];
29 29
     }
30 30
 }
Please login to merge, or discard this patch.
Http/backendRoutes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 use Illuminate\Routing\Router;
4 4
 
5 5
 /** @var Router $router */
6
-$router->group(['prefix' => '/notification'], function (Router $router) {
6
+$router->group([ 'prefix' => '/notification' ], function(Router $router) {
7 7
     $router->get('notifications', [
8 8
         'as' => 'admin.notification.notification.index',
9 9
         'uses' => 'NotificationsController@index',
Please login to merge, or discard this patch.
Http/apiRoutes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,4 +3,4 @@
 block discarded – undo
3 3
 use Illuminate\Routing\Router;
4 4
 
5 5
 /** @var Router $router */
6
-$router->post('notification/mark-read', ['as' => 'api.notification.read', 'uses' => 'NotificationsController@markAsRead']);
6
+$router->post('notification/mark-read', [ 'as' => 'api.notification.read', 'uses' => 'NotificationsController@markAsRead' ]);
Please login to merge, or discard this patch.
Http/Controllers/Admin/NotificationsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         $this->notification->destroy($notification);
45 45
 
46 46
         return redirect()->route('admin.notification.notification.index')
47
-            ->withSuccess(trans('core::core.messages.resource deleted', ['name' => 'Notification']));
47
+            ->withSuccess(trans('core::core.messages.resource deleted', [ 'name' => 'Notification' ]));
48 48
     }
49 49
 
50 50
     public function destroyAll()
Please login to merge, or discard this patch.
Repositories/Cache/CacheNotificationDecorator.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,11 +21,11 @@  discard block
 block discarded – undo
21 21
     public function latestForUser($userId)
22 22
     {
23 23
         return $this->cache
24
-            ->tags([$this->entityName, 'global'])
24
+            ->tags([ $this->entityName, 'global' ])
25 25
             ->remember(
26 26
                 "{$this->locale}.{$this->entityName}.latestForUser.{$userId}",
27 27
                 $this->cacheTime,
28
-                function () use ($userId) {
28
+                function() use ($userId) {
29 29
                     return $this->repository->latestForUser($userId);
30 30
                 }
31 31
             );
@@ -51,11 +51,11 @@  discard block
 block discarded – undo
51 51
     public function allForUser($userId)
52 52
     {
53 53
         return $this->cache
54
-            ->tags([$this->entityName, 'global'])
54
+            ->tags([ $this->entityName, 'global' ])
55 55
             ->remember(
56 56
                 "{$this->locale}.{$this->entityName}.allForUser.{$userId}",
57 57
                 $this->cacheTime,
58
-                function () use ($userId) {
58
+                function() use ($userId) {
59 59
                     return $this->repository->allForUser($userId);
60 60
                 }
61 61
             );
@@ -69,11 +69,11 @@  discard block
 block discarded – undo
69 69
     public function allUnreadForUser($userId)
70 70
     {
71 71
         return $this->cache
72
-            ->tags([$this->entityName, 'global'])
72
+            ->tags([ $this->entityName, 'global' ])
73 73
             ->remember(
74 74
                 "{$this->locale}.{$this->entityName}.allUnreadForUser.{$userId}",
75 75
                 $this->cacheTime,
76
-                function () use ($userId) {
76
+                function() use ($userId) {
77 77
                     return $this->repository->allUnreadForUser($userId);
78 78
                 }
79 79
             );
Please login to merge, or discard this patch.