Completed
Pull Request — master (#23)
by Arthur
01:48
created
src/WebThumbnailer/Finder/DefaultFinder.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -60,16 +60,16 @@  discard block
 block discarded – undo
60 60
             return $this->url;
61 61
         }
62 62
 
63
-        if (empty($thumbnail) && ! empty($headers) && strpos($headers[0], '200') === false) {
63
+        if (empty($thumbnail) && !empty($headers) && strpos($headers[0], '200') === false) {
64 64
             return false;
65 65
         }
66 66
 
67 67
         // With curl, the thumb is extracted during the download
68
-        if ($this->webAccess instanceof WebAccessCUrl && ! empty($thumbnail)) {
68
+        if ($this->webAccess instanceof WebAccessCUrl && !empty($thumbnail)) {
69 69
             return $thumbnail;
70 70
         }
71 71
 
72
-        return ! empty($content) ? static::extractMetaTag($content) : false;
72
+        return !empty($content) ? static::extractMetaTag($content) : false;
73 73
     }
74 74
 
75 75
     /**
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
          *
100 100
          * @return int|false length of $data or false if we need to stop the download
101 101
          */
102
-        return function (&$ch, $data) use ($url, &$content, &$thumbnail, &$isRedirected) {
102
+        return function(&$ch, $data) use ($url, &$content, &$thumbnail, &$isRedirected) {
103 103
             $content .= $data;
104 104
             $responseCode = curl_getinfo($ch, CURLINFO_RESPONSE_CODE);
105 105
             if (!empty($responseCode) && in_array($responseCode, [301, 302])) {
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
             }
112 112
             // After a redirection, the content type will keep the previous request value
113 113
             // until it finds the next content-type header.
114
-            if (! $isRedirected || strpos(strtolower($data), 'content-type') !== false) {
114
+            if (!$isRedirected || strpos(strtolower($data), 'content-type') !== false) {
115 115
                 $contentType = curl_getinfo($ch, CURLINFO_CONTENT_TYPE);
116 116
             }
117 117
             // we look for image, and ignore application/octet-stream,
@@ -155,10 +155,10 @@  discard block
 block discarded – undo
155 155
         $propertiesKey = ['property', 'name', 'itemprop'];
156 156
         $properties = implode('|', $propertiesKey);
157 157
         // Try to retrieve OpenGraph image.
158
-        $ogRegex = '#<meta[^>]+(?:' . $properties . ')=["\']?og:image["\'\s][^>]*content=["\']?(.*?)["\'\s>]#';
158
+        $ogRegex = '#<meta[^>]+(?:'.$properties.')=["\']?og:image["\'\s][^>]*content=["\']?(.*?)["\'\s>]#';
159 159
         // If the attributes are not in the order property => content (e.g. Github)
160 160
         // New regex to keep this readable... more or less.
161
-        $ogRegexReverse = '#<meta[^>]+content=["\']?([^"\'\s]+)[^>]+(?:' . $properties . ')=["\']?og:image["\'\s/>]#';
161
+        $ogRegexReverse = '#<meta[^>]+content=["\']?([^"\'\s]+)[^>]+(?:'.$properties.')=["\']?og:image["\'\s/>]#';
162 162
 
163 163
         if (
164 164
             preg_match($ogRegex, $content, $matches) > 0
Please login to merge, or discard this patch.
src/WebThumbnailer/Finder/QueryRegexFinder.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         }
84 84
 
85 85
         // With curl, the thumb is extracted during the download
86
-        if ($this->webAccess instanceof WebAccessCUrl && ! empty($thumbnail)) {
86
+        if ($this->webAccess instanceof WebAccessCUrl && !empty($thumbnail)) {
87 87
             return $thumbnail;
88 88
         }
89 89
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
          *
117 117
          * @return int|false length of $data or false if we need to stop the download
118 118
          */
119
-        return function (&$ch, $data) use (&$content, &$thumbnail, &$isRedirected) {
119
+        return function(&$ch, $data) use (&$content, &$thumbnail, &$isRedirected) {
120 120
             $content .= $data;
121 121
             $responseCode = curl_getinfo($ch, CURLINFO_RESPONSE_CODE);
122 122
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
             }
130 130
             // After a redirection, the content type will keep the previous request value
131 131
             // until it finds the next content-type header.
132
-            if (! $isRedirected || strpos(strtolower($data), 'content-type') !== false) {
132
+            if (!$isRedirected || strpos(strtolower($data), 'content-type') !== false) {
133 133
                 $contentType = curl_getinfo($ch, CURLINFO_CONTENT_TYPE);
134 134
             }
135 135
             if (!empty($contentType) && strpos($contentType, 'text/html') === false) {
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
         if (preg_match($this->urlRegex, $content, $matches) !== 0) {
161 161
             $total = count($matches);
162 162
             for ($i = 1; $i < $total; $i++) {
163
-                $thumbnailUrl = str_replace('${' . $i . '}', $matches[$i], $thumbnailUrl);
163
+                $thumbnailUrl = str_replace('${'.$i.'}', $matches[$i], $thumbnailUrl);
164 164
             }
165 165
 
166 166
             // Match only options (not ${number})
Please login to merge, or discard this patch.
src/WebThumbnailer/Application/WebAccess/WebAccessCUrl.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,12 +63,12 @@  discard block
 block discarded – undo
63 63
             $maxBytes = ConfigManager::get('settings.default.max_img_dl', 16777216);
64 64
         }
65 65
 
66
-        $cookie = ConfigManager::get('settings.path.cache') . '/cookie.txt';
66
+        $cookie = ConfigManager::get('settings.path.cache').'/cookie.txt';
67 67
         $userAgent =
68 68
             'Mozilla/5.0 (X11; Linux x86_64; rv:45.0; WebThumbnailer)'
69 69
             . ' Gecko/20100101 Firefox/45.0';
70 70
         $acceptLanguage =
71
-            substr(setlocale(LC_COLLATE, 0), 0, 2) . ',en-US;q=0.7,en;q=0.3';
71
+            substr(setlocale(LC_COLLATE, 0), 0, 2).',en-US;q=0.7,en;q=0.3';
72 72
         $maxRedirs = 6;
73 73
 
74 74
         $ch = curl_init($url);
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         curl_setopt(
84 84
             $ch,
85 85
             CURLOPT_HTTPHEADER,
86
-            ['Accept-Language: ' . $acceptLanguage]
86
+            ['Accept-Language: '.$acceptLanguage]
87 87
         );
88 88
         curl_setopt($ch, CURLOPT_MAXREDIRS, $maxRedirs);
89 89
         curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         curl_setopt(
101 101
             $ch,
102 102
             CURLOPT_PROGRESSFUNCTION,
103
-            function ($arg0, $arg1, $arg2) use ($maxBytes) {
103
+            function($arg0, $arg1, $arg2) use ($maxBytes) {
104 104
                 $downloaded = $arg2;
105 105
                 // Non-zero return stops downloading
106 106
                 return ($downloaded > $maxBytes) ? 1 : 0;
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
         curl_close($ch);
122 122
 
123 123
         if (!is_string($response)) {
124
-            return [[0 => 'curl_exec() error #' . $errorNo . ': ' . $errorStr], false];
124
+            return [[0 => 'curl_exec() error #'.$errorNo.': '.$errorStr], false];
125 125
         }
126 126
 
127 127
         // Formatting output like the fallback method
Please login to merge, or discard this patch.
src/WebThumbnailer/Application/CacheManager.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             static::rebuildCacheFolders();
52 52
             return static::getCachePath($type, true);
53 53
         } elseif (!$path) {
54
-            throw new IOException('Cache folders are not writable: ' . $cache);
54
+            throw new IOException('Cache folders are not writable: '.$cache);
55 55
         }
56 56
         return $path;
57 57
     }
@@ -94,12 +94,12 @@  discard block
 block discarded – undo
94 94
         }
95 95
 
96 96
         if ($type === static::TYPE_THUMB) {
97
-            $suffix = $width . $height . ($crop ? '1' : '0') . '.jpg';
97
+            $suffix = $width.$height.($crop ? '1' : '0').'.jpg';
98 98
         } else {
99
-            $suffix = $width . $height;
99
+            $suffix = $width.$height;
100 100
         }
101 101
 
102
-        return $domainFolder . static::getThumbFilename($url) . $suffix;
102
+        return $domainFolder.static::getThumbFilename($url).$suffix;
103 103
     }
104 104
 
105 105
     /**
@@ -148,10 +148,10 @@  discard block
 block discarded – undo
148 148
     protected static function createDomainThumbCacheFolder(string $domain, string $type): void
149 149
     {
150 150
         $cachePath = static::getCachePath($type);
151
-        $domainFolder = $cachePath . $domain;
151
+        $domainFolder = $cachePath.$domain;
152 152
         if (!file_exists($domainFolder)) {
153 153
             mkdir($domainFolder, 0775, false);
154
-            touch($domainFolder . '/' . static::$CLEAN_FILE);
154
+            touch($domainFolder.'/'.static::$CLEAN_FILE);
155 155
         }
156 156
         static::createHtaccessFile($cachePath, $type === static::TYPE_THUMB);
157 157
     }
@@ -169,13 +169,13 @@  discard block
 block discarded – undo
169 169
     protected static function createHtaccessFile(string $path, bool $allowed = false): void
170 170
     {
171 171
         $apacheVersion = ConfigManager::get('settings.apache_version', '');
172
-        $htaccessFile = $path . '.htaccess';
172
+        $htaccessFile = $path.'.htaccess';
173 173
         if (file_exists($htaccessFile)) {
174 174
             return;
175 175
         }
176
-        $templateFile = file_exists(FileUtils::RESOURCES_PATH . 'htaccess' . $apacheVersion . '_template')
177
-            ? FileUtils::RESOURCES_PATH . 'htaccess' . $apacheVersion . '_template'
178
-            : FileUtils::RESOURCES_PATH . 'htaccess_template';
176
+        $templateFile = file_exists(FileUtils::RESOURCES_PATH.'htaccess'.$apacheVersion.'_template')
177
+            ? FileUtils::RESOURCES_PATH.'htaccess'.$apacheVersion.'_template'
178
+            : FileUtils::RESOURCES_PATH.'htaccess_template';
179 179
         $template = new \Text_Template($templateFile);
180 180
         $template->setVar([
181 181
             'new_all' => $allowed ? 'granted' : 'denied',
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
     protected static function checkCacheType(string $type): bool
211 211
     {
212 212
         if ($type != static::TYPE_THUMB && $type != static::TYPE_FINDER) {
213
-            throw new CacheException('Unknown cache type ' . $type);
213
+            throw new CacheException('Unknown cache type '.$type);
214 214
         }
215 215
 
216 216
         return true;
@@ -225,20 +225,20 @@  discard block
 block discarded – undo
225 225
     protected static function rebuildCacheFolders(): void
226 226
     {
227 227
         $mainFolder = ConfigManager::get('settings.path.cache', 'cache/');
228
-        if (! is_dir($mainFolder)) {
228
+        if (!is_dir($mainFolder)) {
229 229
             mkdir($mainFolder, 0755);
230 230
         }
231
-        if (! is_dir($mainFolder . static::TYPE_THUMB)) {
232
-            mkdir($mainFolder . static::TYPE_THUMB, 0755);
231
+        if (!is_dir($mainFolder.static::TYPE_THUMB)) {
232
+            mkdir($mainFolder.static::TYPE_THUMB, 0755);
233 233
         }
234
-        if (! is_readable($mainFolder . static::TYPE_THUMB . DIRECTORY_SEPARATOR . '.gitkeep')) {
235
-            touch($mainFolder . static::TYPE_THUMB . DIRECTORY_SEPARATOR . '.gitkeep');
234
+        if (!is_readable($mainFolder.static::TYPE_THUMB.DIRECTORY_SEPARATOR.'.gitkeep')) {
235
+            touch($mainFolder.static::TYPE_THUMB.DIRECTORY_SEPARATOR.'.gitkeep');
236 236
         }
237
-        if (! is_dir($mainFolder . static::TYPE_FINDER)) {
238
-            mkdir($mainFolder . static::TYPE_FINDER, 0755);
237
+        if (!is_dir($mainFolder.static::TYPE_FINDER)) {
238
+            mkdir($mainFolder.static::TYPE_FINDER, 0755);
239 239
         }
240
-        if (! is_readable($mainFolder . static::TYPE_THUMB . DIRECTORY_SEPARATOR . '.gitkeep')) {
241
-            touch($mainFolder . static::TYPE_FINDER . DIRECTORY_SEPARATOR . '.gitkeep');
240
+        if (!is_readable($mainFolder.static::TYPE_THUMB.DIRECTORY_SEPARATOR.'.gitkeep')) {
241
+            touch($mainFolder.static::TYPE_FINDER.DIRECTORY_SEPARATOR.'.gitkeep');
242 242
         }
243 243
     }
244 244
 
Please login to merge, or discard this patch.