ArthurGuy / BBMembershipSystem

app/Entities/Equipment.php

Doc Comments +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
     /**
      * Add a photo name to the photos array
      *
-     * @param $fileName
+     * @param string $fileName
      */
     public function addPhoto($fileName)
     {

app/Entities/KeyFob.php

Doc Comments +3 added lines

@@ -58,6 +58,9 @@
         return $record;
     }
 
+    /**
+     * @param string $fobId
+     */
     public static function lookupPartialTag($fobId)
     {
         $record = self::where('key_id', 'LIKE', '%' . strtoupper($fobId) . '%')->active()->first();

app/Entities/Role.php

Doc Comments +3 added lines

@@ -18,6 +18,9 @@
         return $this->belongsToMany('\BB\Entities\User')->withTimestamps();
     }
 
+    /**
+     * @param string $name
+     */
     public static function findByName($name) {
         $role = self::where('name', $name)->first();
         if ($role) {

Braces +2 added lines, -1 removed lines

@@ -18,7 +18,8 @@
         return $this->belongsToMany('\BB\Entities\User')->withTimestamps();
     }
 
-    public static function findByName($name) {
+    public static function findByName($name)
+    {
         $role = self::where('name', $name)->first();
         if ($role) {
             return $role;

app/Http/Controllers/ACS/ActivityController.php

Doc Comments +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
     /**
      * Record the start of a new session
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      *
      * @SWG\Post(
      *     path="/acs/activity",
@@ -80,7 +80,7 @@ 
     /**
      * Update an ongoing activity
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      *
      * @SWG\Put(
      *     path="/acs/activity/{activityId}",
@@ -103,7 +103,7 @@ 
     /**
      * Show the form for creating a new resource.
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      *
      * @SWG\Delete(
      *     path="/acs/activity/{activityId}",

app/Http/Controllers/ACSController.php

Doc Comments +2 added lines, -2 removed lines

@@ -143,7 +143,7 @@ 
      *
      * @param $message
      * @param $device
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      */
     private function handleSystemCheckIn($message, $device, $service)
     {
@@ -181,7 +181,7 @@ 
      * Json encode the response data and return
      *
      * @param array $responseData
-     * @return \Response
+     * @return \Illuminate\Http\JsonResponse
      */
     private function sendResponse(array $responseData)
     {

Spacing +4 added lines, -4 removed lines

@@ -84,10 +84,10 @@
 
         $responseArray = [
             'time'      => time(),
-            'command'   => null,      //stored command for the device to process
-            'valid'     => true,      //member request
-            'available' => true,      //device status - remote shutdown,
-            'member'    => null,      //member name
+            'command'   => null, //stored command for the device to process
+            'valid'     => true, //member request
+            'available' => true, //device status - remote shutdown,
+            'member'    => null, //member name
         ];
 
     }

app/Http/Controllers/DetectedDevicesController.php

Unused Use Statements -3 removed lines

@@ -3,9 +3,6 @@
 namespace BB\Http\Controllers;
 
 use BB\Entities\DetectedDevice;
-use Illuminate\Http\Request;
-
-use BB\Http\Requests;
 use BB\Http\Controllers\Controller;
 
 class DetectedDevicesController extends Controller

app/Http/Controllers/DeviceController.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace BB\Http\Controllers;
 
 use BB\Entities\ACSNode;
-use BB\Http\Requests;
 
 class DeviceController extends Controller
 {

app/Http/Controllers/ExpensesController.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     /**
      * Store a newly created resource in storage.
      *
-     * @return Response
+     * @return \Illuminate\Http\JsonResponse
      * @throws ImageFailedException
      * @throws \BB\Exceptions\FormValidationException
      */

Indentation +49 added lines, -49 removed lines

@@ -33,8 +33,8 @@ 
      * @return Response
      * @throws \BB\Exceptions\AuthenticationException
      */
-	public function index()
-	{
+    public function index()
+    {
         $userId       = \Request::get('user_id', '');
         $sortBy       = \Request::get('sortBy', 'created_at');
         $direction    = \Request::get('direction', 'desc');
@@ -49,18 +49,18 @@ 
         $expenses = $this->expenseRepository->getPaginated(compact('sortBy', 'direction'));
 
         return \View::make('expenses.index')->with('expenses', $expenses);
-	}
+    }
 
 
-	/**
-	 * Show the form for creating a new resource.
-	 *
-	 * @return Response
-	 */
-	public function create()
-	{
-		//
-	}
+    /**
+     * Show the form for creating a new resource.
+     *
+     * @return Response
+     */
+    public function create()
+    {
+        //
+    }
 
 
     /**
@@ -70,9 +70,9 @@ 
      * @throws ImageFailedException
      * @throws \BB\Exceptions\FormValidationException
      */
-	public function store()
-	{
-		$data = \Request::only(['user_id', 'category', 'description', 'amount', 'expense_date', 'file']);
+    public function store()
+    {
+        $data = \Request::only(['user_id', 'category', 'description', 'amount', 'expense_date', 'file']);
 
         $this->expenseValidator->validate($data);
 
@@ -107,31 +107,31 @@ 
         event(new NewExpenseSubmitted($expense));
 
         return \Response::json($expense, 201);
-	}
+    }
 
 
-	/**
-	 * Display the specified resource.
-	 *
-	 * @param  int  $id
-	 * @return Response
-	 */
-	public function show($id)
-	{
-		return \BB\Entities\Expense::findOrFail($id);
-	}
+    /**
+     * Display the specified resource.
+     *
+     * @param  int  $id
+     * @return Response
+     */
+    public function show($id)
+    {
+        return \BB\Entities\Expense::findOrFail($id);
+    }
 
 
-	/**
-	 * Show the form for editing the specified resource.
-	 *
-	 * @param  int  $id
-	 * @return Response
-	 */
-	public function edit($id)
-	{
-		//
-	}
+    /**
+     * Show the form for editing the specified resource.
+     *
+     * @param  int  $id
+     * @return Response
+     */
+    public function edit($id)
+    {
+        //
+    }
 
 
     /**
@@ -141,8 +141,8 @@ 
      * @return Response
      * @throws \BB\Exceptions\AuthenticationException
      */
-	public function update($id)
-	{
+    public function update($id)
+    {
         /**
         if (\Request::ajax()) {
             $data = \Request::only(['category', 'description', 'amount', 'expense_date']);
@@ -152,7 +152,7 @@ 
 
             return $expense;
         }
-        */
+         */
 
         if ( ! \Auth::user()->hasRole('admin')) {
             throw new \BB\Exceptions\AuthenticationException();
@@ -167,20 +167,20 @@ 
         }
 
         return \Redirect::route('expenses.index');
-	}
+    }
 
 
-	/**
-	 * Remove the specified resource from storage.
-	 *
-	 * @param  int  $id
-	 * @return Response
-	 */
-	public function destroy($id)
-	{
+    /**
+     * Remove the specified resource from storage.
+     *
+     * @param  int  $id
+     * @return Response
+     */
+    public function destroy($id)
+    {
         //$expense = \BB\Entities\Expense::findOrFail($id);
         //$expense->delete();
-	}
+    }
 
 
 }

Spacing +2 added lines, -2 removed lines

@@ -83,13 +83,13 @@
                 $ext = \Input::file('file')->guessClientExtension();
                 $mimeType = \Input::file('file')->getMimeType();
 
-                $newFilename = \App::environment().'/expenses/' . str_random() . '.' . $ext;
+                $newFilename = \App::environment() . '/expenses/' . str_random() . '.' . $ext;
 
                 Storage::put($newFilename, file_get_contents($filePath), 'public');
 
                 $data['file'] = $newFilename;
 
-            } catch(\Exception $e) {
+            } catch (\Exception $e) {
                 \Log::error($e);
                 throw new ImageFailedException($e->getMessage());
             }

Braces +2 added lines, -1 removed lines

@@ -6,7 +6,8 @@
 use Illuminate\Support\Facades\Response;
 use Illuminate\Support\Facades\Storage;
 
-class ExpensesController extends Controller {
+class ExpensesController extends Controller
+{
 
     /**
      * @var \BB\Validators\ExpenseValidator

app/Http/Controllers/GoCardlessPaymentController.php

Doc Comments +3 added lines

@@ -226,6 +226,9 @@
         }
     }
 
+    /**
+     * @param integer $userId
+     */
     private function getName($reason, $userId)
     {
         if ($reason == 'subscription') {