View GitHub Repository BBMembershipSystem

Schedule Inspection
Subscribe
Completed
Pull Request — master (#216)
by Arthur
05:42 queued 02:50
created
Status
Category
Toggle Patches
app/Helpers/GoCardlessHelper.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -30,6 +30,9 @@  discard block
 
 block discarded – undo
30 30 
         ]);
31 31 
     }
32 32
33 
+    /**
34 
+     * @return double
35 
+     */
33 36 
     public function getPayment($paymentId)
34 37 
     {
35 38 
         return $this->client->payments()->get($paymentId);
 
@@ -66,7 +69,7 @@  discard block
 
 block discarded – undo
66 69 
      * @param             $amount
67 70 
      * @param null|string $name
68 71 
      * @param null|string $description
69 
-     * @return bool|mixed
72 
+     * @return integer
70 73 
      */
71 74 
     public function newBill($preauthId, $amount, $name = null, $description = null)
72 75 
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -26,7 +26,7 @@  discard block
 
 block discarded – undo
26 26
27 27 
         $this->client = new \GoCardlessPro\Client([
28 28 
             'access_token' => env('NEW_GOCARDLESS_ACCESS_TOKEN'),
29 
-            'environment' => (env('NEW_GOCARDLESS_ENV', 'LIVE') == 'LIVE')? \GoCardlessPro\Environment::LIVE: \GoCardlessPro\Environment::SANDBOX,
29 
+            'environment' => (env('NEW_GOCARDLESS_ENV', 'LIVE') == 'LIVE') ? \GoCardlessPro\Environment::LIVE : \GoCardlessPro\Environment::SANDBOX,
30 30 
         ]);
31 31 
     }
32 32 
 
@@ -51,7 +51,7 @@  discard block
 
 block discarded – undo
51 51 
     {
52 52 
         return $this->client->redirectFlows()->complete(
53 53 
             $user->gocardless_setup_id,
54 
-            ["params" => ["session_token" => 'user-token-'.$user->id]]
54 
+            ["params" => ["session_token" => 'user-token-' . $user->id]]
55 55 
         );
56 56 
     }
57 57
Please login to merge, or discard this patch.
app/Http/Controllers/SubscriptionController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36 
         $payment_details = array(
37 37 
             "description"          => "Build Brighton",
38 38 
             'success_redirect_url' => route('account.subscription.store', $user->id),
39 
-            "session_token"        => 'user-token-'.$user->id,
39 
+            "session_token"        => 'user-token-' . $user->id,
40 40 
             'prefilled_customer'   => [
41 41 
                 'given_name'    => $user->given_name,
42 42 
                 'family_name'   => $user->family_name,
 
@@ -81,7 +81,7 @@  discard block
 
 block discarded – undo
81 81 
         }
82 82
83 83
84 
-        if (!isset($confirmed_resource->links->mandate) || empty($confirmed_resource->links->mandate)) {
84 
+        if ( ! isset($confirmed_resource->links->mandate) || empty($confirmed_resource->links->mandate)) {
85 85 
             \Notification::error('Something went wrong, you can try again or get in contact');
86 86 
             return \Redirect::route('account.show', $user->id);
87 87 
         }
Please login to merge, or discard this patch.