Algo-Web / POData

src/POData/Providers/ProvidersWrapper.php

Doc Comments +1 added lines, -1 removed lines

@@ -966,7 +966,7 @@
     }
     /**
      * @param ResourceSet      $resourceSet   The entity set containing the entity to fetch
-     * @param object           $sourceEntityInstance The source entity instance
+     * @param KeyDescriptor           $sourceEntityInstance The source entity instance
      * @param object           $data                 The New data for the entity instance.
      *
      * returns object|null returns the newly created model if sucessful or null if model creation failed.

src/POData/Writers/Metadata/MetadataWriter.php

Indentation +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
         $resourceTypesInContainerNamespace = array();
         $containerNamespace = $this->providersWrapper->getContainerNamespace();
         foreach ($this->_metadataManager->getResourceTypesAlongWithNamespace()
-                 as $resourceTypeNamespace => $resourceTypesWithName) {
+                    as $resourceTypeNamespace => $resourceTypesWithName) {
             if ($resourceTypeNamespace == $containerNamespace) {
                 foreach ($resourceTypesWithName as $resourceTypeName => $resourceType) {
                     $resourceTypesInContainerNamespace[] = $resourceType;
@@ -279,7 +279,7 @@ 
     private function _writeProperties(ResourceType $resourceType, $associationTypesInResourceTypeNamespace)
     {
         foreach ($this->_metadataManager->getAllVisiblePropertiesDeclaredOnThisType($resourceType)
-                 as $resourceProperty) {
+                    as $resourceProperty) {
             if ($resourceProperty->isKindOf(ResourcePropertyKind::BAG)) {
                 $this->_writeBagProperty($resourceProperty);
             } elseif ($resourceProperty->isKindOf(ResourcePropertyKind::PRIMITIVE)) {

src/POData/UriProcessor/RequestExpander.php

Doc Comments +10 added lines, -10 removed lines

@@ -170,7 +170,7 @@ 
      * Pushes a segment for the root of the tree
      * Note: Calls to this method should be balanced with calls to popSegment.
      *
-     * @return bool true if the segment was pushed, false otherwise
+     * @return boolean|null true if the segment was pushed, false otherwise
      */
     private function pushSegmentForRoot()
     {
@@ -189,7 +189,7 @@ 
      * @param ResourceProperty &$resourceProperty Current navigation property
      *                                            being written out
      *
-     * @return bool true if a segment was pushed, false otherwise
+     * @return boolean|null true if a segment was pushed, false otherwise
      *
      * @throws InvalidOperationException If this function invoked with non-navigation
      *                                   property instance
@@ -277,7 +277,7 @@ 
      * @param ResourceSetWrapper &$resourceSetWrapper The resource set wrapper
      *                                                to push
      *
-     * @return bool true if the segment was push, false otherwise
+     * @return boolean|null true if the segment was push, false otherwise
      */
     private function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
     {
@@ -301,7 +301,7 @@ 
     }
 
     /**
-     * @param $expandedProjectionNode
+     * @param ExpandedProjectionNode $expandedProjectionNode
      * @param $entry
      * @return null|\object[]
      */
@@ -327,10 +327,10 @@ 
     }
 
     /**
-     * @param $expandedProjectionNode
+     * @param ExpandedProjectionNode $expandedProjectionNode
      * @param $entry
-     * @param $resourceType
-     * @param $expandedPropertyName
+     * @param \POData\Providers\Metadata\ResourceType $resourceType
+     * @param string $expandedPropertyName
      * @throws InvalidOperationException
      * @throws \POData\Common\ODataException
      */
@@ -360,9 +360,9 @@ 
     /**
      * @param $entry
      * @param $result
-     * @param $expandedProjectionNode
-     * @param $resourceType
-     * @param $expandedPropertyName
+     * @param ExpandedProjectionNode $expandedProjectionNode
+     * @param \POData\Providers\Metadata\ResourceType $resourceType
+     * @param string $expandedPropertyName
      * @throws InvalidOperationException
      */
     private function executeCollectionExpansionProcessExpansion(

Spacing +2 added lines, -2 removed lines

@@ -194,7 +194,7 @@ 
      * @throws InvalidOperationException If this function invoked with non-navigation
      *                                   property instance
      */
-    private function pushSegmentForNavigationProperty(ResourceProperty &$resourceProperty)
+    private function pushSegmentForNavigationProperty(ResourceProperty & $resourceProperty)
     {
         if ($resourceProperty->getTypeKind() == ResourceTypeKind::ENTITY) {
             assert(!empty($this->getStack()->getSegmentNames()), '!is_empty($this->getStack()->getSegmentNames())');
@@ -279,7 +279,7 @@ 
      *
      * @return bool true if the segment was push, false otherwise
      */
-    private function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
+    private function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
     {
         $this->getStack()->pushSegment($segmentName, $resourceSetWrapper);
     }

src/POData/UriProcessor/SegmentStack.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
      *
      * @return bool true if the segment was push, false otherwise
      */
-    public function pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
+    public function pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
     {
         $rootProjectionNode = $this->getRequest()->getRootProjectionNode();
         if (!is_null($rootProjectionNode) && $rootProjectionNode->isExpansionSpecified()) {

src/POData/UriProcessor/UriProcessor.php

Unused Use Statements -6 removed lines

@@ -2,15 +2,10 @@ 
 
 namespace POData\UriProcessor;
 
-use Illuminate\Support\Str;
 use POData\Providers\ProvidersWrapper;
 use POData\Providers\Metadata\ResourcePropertyKind;
-use POData\Providers\Metadata\ResourceTypeKind;
-use POData\Providers\Metadata\ResourceSetWrapper;
-use POData\Providers\Metadata\ResourceProperty;
 use POData\Providers\Query\QueryType;
 use POData\UriProcessor\QueryProcessor\QueryProcessor;
-use POData\UriProcessor\QueryProcessor\ExpandProjectionParser\ExpandedProjectionNode;
 use POData\UriProcessor\ResourcePathProcessor\ResourcePathProcessor;
 use POData\UriProcessor\ResourcePathProcessor\SegmentParser\SegmentDescriptor;
 use POData\UriProcessor\ResourcePathProcessor\SegmentParser\TargetKind;
@@ -18,7 +13,6 @@ 
 use POData\IService;
 use POData\Common\Messages;
 use POData\Common\ODataException;
-use POData\Common\InvalidOperationException;
 use POData\Common\ODataConstants;
 use POData\Providers\Query\QueryResult;
 use POData\OperationContext\HTTPRequestMethod;

Spacing +1 added lines, -1 removed lines

@@ -382,7 +382,7 @@
             $segment->setResult($entityInstance);
         } else {
             $skip = (null == $this->getRequest()) ? 0 : $this->getRequest()->getSkipCount();
-            $skip = (null == $skip) ? 0 :$skip;
+            $skip = (null == $skip) ? 0 : $skip;
             $queryResult = $this->getProviders()->getResourceSet(
                 $this->getRequest()->queryType,
                 $segment->getTargetResourceSetWrapper(),

src/POData/UriProcessor/QueryProcessor/OrderByParser/OrderByLeafNode.php

Doc Comments +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
      *
      * @param string[] $ancestors Array of parent properties e.g. array('Orders', 'Customer', 'Customer_Demographics')
      *
-     * @return AnonymousFunction
+     * @return \Closure
      */
     public function buildComparisonFunction($ancestors)
     {

Spacing +4 added lines, -4 removed lines

@@ -106,7 +106,7 @@ 
         $accessor2 = null;
         $a = $this->_isAscending ? 1 : -1;
 
-        $retVal = function ($object1, $object2) use ($ancestors, $a) {
+        $retVal = function($object1, $object2) use ($ancestors, $a) {
 
             $flag1 = is_null($object1);
             $flag2 = is_null($object2);
@@ -142,7 +142,7 @@ 
                 return $a*1;
             }
             $type = $this->resourceProperty->getInstanceType();
-            $result  = null;
+            $result = null;
             if ($type instanceof DateTime) {
                 $result = strtotime($accessor1) - strtotime($accessor2);
             } elseif ($type instanceof StringType) {
@@ -151,11 +151,11 @@ 
                 $result = strcmp($accessor1, $accessor2);
             } else {
                 $delta = $accessor1 - $accessor2;  
-                $result (0 == $delta) ? 0 : $delta / abs($delta);
+                $result(0 == $delta) ? 0 : $delta/abs($delta);
             }
 
             return $a*$result;
         };
-        return $retVal ;
+        return $retVal;
     }
 }

src/POData/UriProcessor/QueryProcessor/OrderByParser/OrderByParser.php

Spacing +2 added lines, -2 removed lines

@@ -406,9 +406,9 @@
         } else {
             $code = null;
             $funcList = $this->_comparisonFunctions;
-            $BigFunc = function ($object1, $object2) use ($funcList) {
+            $BigFunc = function($object1, $object2) use ($funcList) {
                 foreach ($funcList as $f) {
-                    $ret = $f($object1,$object2);
+                    $ret = $f($object1, $object2);
                     if ($ret != 0) {
                         return $ret;
                     }