Completed
Pull Request — master (#12)
by Christopher
04:23
created
src/POData/Providers/Query/IQueryProvider.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@
 block discarded – undo
145 145
      *
146 146
      * @return object|null The new resource value if it is assignable or throw exception for null.
147 147
      */
148
-    public function updateResource(ResourceSet $sourceResourceSet,$sourceEntityInstance, KeyDescriptor $keyDescriptor,$data, $shouldUpdate = false);
148
+    public function updateResource(ResourceSet $sourceResourceSet, $sourceEntityInstance, KeyDescriptor $keyDescriptor, $data, $shouldUpdate = false);
149 149
 
150 150
     /*
151 151
      * Delete resource from a resource set.
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
      * @param QueryType   $queryType   indicates if this is a query for a count, entities, or entities with a count
38 38
      * @param ResourceSet $resourceSet The entity set containing the entities to fetch
39 39
      * @param FilterInfo  $filterInfo  represents the $filter parameter of the OData query.  NULL if no $filter specified
40
-     * @param mixed       $orderBy     sorted order if we want to get the data in some specific order
40
+     * @param null|\POData\UriProcessor\QueryProcessor\OrderByParser\InternalOrderByInfo       $orderBy     sorted order if we want to get the data in some specific order
41 41
      * @param int         $top         number of records which  need to be skip
42 42
      * @param string      $skipToken   value indicating what records to skip
43 43
      *
Please login to merge, or discard this patch.
src/POData/UriProcessor/XML2Array.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 
4 4
 class XML2Array
5 5
 {
6
- /**
6
+    /**
7 7
      * @var string
8 8
      */
9 9
     private static $encoding = 'UTF-8';
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
                     throw new \Exception();
31 31
                 }
32 32
             } catch (\Exception $ex) {
33
-                throw new \Exception('[XML2Array] Error parsing the XML string.'.PHP_EOL.$ex->getMessage());
33
+                throw new \Exception('[XML2Array] Error parsing the XML string.' . PHP_EOL . $ex->getMessage());
34 34
             }
35 35
         } elseif (is_object($input_xml)) {
36 36
             if (get_class($input_xml) != 'DOMDocument') {
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
             throw new \Exception('[XML2Array] Invalid input');
42 42
         }
43 43
         $array[$xml->documentElement->tagName] = self::convert($xml->documentElement);
44
-        self::$xml = null;    // clear the xml node in the class for 2nd time use.
44
+        self::$xml = null; // clear the xml node in the class for 2nd time use.
45 45
         return $array;
46 46
     }
47 47
     /**
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
     /**
15 15
      * Convert an XML to Array.
16 16
      *
17
-     * @param string|\DOMDocument $input_xml
17
+     * @param string $input_xml
18 18
      *
19 19
      * @return array
20 20
      *
Please login to merge, or discard this patch.
src/POData/Readers/Atom/AtomODataReader.php 3 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     }
82 82
 
83 83
     /**
84
-     * @param DOMNode $feed
84
+     * @param \DOMNode $feed
85 85
      */
86 86
     protected function EnumerateFeed($feed, &$feedType, $parentObject = null)
87 87
     {
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     }
119 119
 
120 120
     /**
121
-     * @param DOMNode $entry
121
+     * @param \DOMNode $entry
122 122
      */
123 123
     protected function EnumerateEntry($entry, &$entityType, $parentObject = null)
124 124
     {
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
     }
204 204
 
205 205
     /**
206
-     * @param DOMNodeList $links
206
+     * @param \DOMNodeList $links
207 207
      */
208 208
     protected function GetRelatedLinks($links)
209 209
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 use DOMDocument;
5 5
 use ReflectionClass;
6 6
 use ReflectionProperty;
7
-use POData\Readers\IODataReader;
8 7
 
9 8
 class AtomODataReader
10 9
 {
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
                                     'default' => 'http://www.w3.org/2005/Atom',
15 15
                                     'd' => 'http://schemas.microsoft.com/ado/2007/08/dataservices',
16 16
                                     'm' => 'http://schemas.microsoft.com/ado/2007/08/dataservices/metadata'
17
-                                 );
17
+                                    );
18 18
     protected static $QUERY_ROOT_FEED = '/default:feed';
19 19
     protected static $QUERY_ROOT_ENTRY = '/default:entry';
20 20
     protected static $QUERY_TITLE = 'default:title';
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
                                  ($attributes['EdmType'] == 'Edm.Int16' ||
346 346
                                   $attributes['EdmType'] == 'Edm.Int32' ||
347 347
                                   $attributes['EdmType'] == 'Edm.Int64')))) {
348
-                                   $value = '0';
348
+                                    $value = '0';
349 349
                             }
350 350
                         } else {
351 351
                             $value = null;
Please login to merge, or discard this patch.
src/POData/Common/Messages/resourceAssociationSet.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,13 +3,13 @@
 block discarded – undo
3 3
 trait resourceAssociationSet
4 4
 {
5 5
 /**
6
-     * Format a message to show error when target resource property
7
-     * argument is not null or instance of ResourceProperty.
8
-     *
9
-     * @param string $argumentName The name of the target resource property argument
10
-     *
11
-     * @return string The formatted message
12
-     */
6
+ * Format a message to show error when target resource property
7
+ * argument is not null or instance of ResourceProperty.
8
+ *
9
+ * @param string $argumentName The name of the target resource property argument
10
+ *
11
+ * @return string The formatted message
12
+ */
13 13
     public static function resourceAssociationSetPropertyMustBeNullOrInstanceofResourceProperty($argumentName)
14 14
     {
15 15
         return "The argument '$argumentName' must be either null or instance of 'ResourceProperty";
Please login to merge, or discard this patch.
src/POData/Common/Messages/queryProvider.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -6,10 +6,10 @@
 block discarded – undo
6 6
 trait queryProvider
7 7
 {
8 8
 /**
9
-     * @param string $methodName method name
10
-     *
11
-     * @return string The message
12
-     */
9
+ * @param string $methodName method name
10
+ *
11
+ * @return string The message
12
+ */
13 13
     public static function queryProviderReturnsNonQueryResult($methodName)
14 14
     {
15 15
         return "The implementation of the method $methodName must return a QueryResult instance.";
Please login to merge, or discard this patch.
src/POData/Common/Messages/request.php 1 patch
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -5,15 +5,15 @@
 block discarded – undo
5 5
 trait request
6 6
 {
7 7
 /**
8
-     * Format a message to show error when client requested version is
9
-     * lower than the version required to intercept the response.
10
-     *
11
-     * @param string $requestedVersion The client requested version
12
-     * @param string $requiredVersion  The minimum version required to
13
-     *                                 intercept the response
14
-     *
15
-     * @return string The formatted message
16
-     */
8
+ * Format a message to show error when client requested version is
9
+ * lower than the version required to intercept the response.
10
+ *
11
+ * @param string $requestedVersion The client requested version
12
+ * @param string $requiredVersion  The minimum version required to
13
+ *                                 intercept the response
14
+ *
15
+ * @return string The formatted message
16
+ */
17 17
     public static function requestVersionTooLow($requestedVersion, $requiredVersion)
18 18
     {
19 19
         return "Request version '$requestedVersion' is not supported for the request payload. The only supported version is '$requiredVersion'.";
Please login to merge, or discard this patch.
src/POData/Common/Messages/streamProviderWrapper.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -4,10 +4,10 @@
 block discarded – undo
4 4
 trait streamProviderWrapper
5 5
 {
6 6
 /**
7
-     * Message to show error when IStreamProvider.GetStreamETag returns invalid etag value.
8
-     *
9
-     * @return string The message
10
-     */
7
+ * Message to show error when IStreamProvider.GetStreamETag returns invalid etag value.
8
+ *
9
+ * @return string The message
10
+ */
11 11
     public static function streamProviderWrapperGetStreamETagReturnedInvalidETagFormat()
12 12
     {
13 13
         return 'The method \'IStreamProvider.GetStreamETag\' returned an entity tag with invalid format.';
Please login to merge, or discard this patch.
src/POData/Common/Messages/http.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
 
6 6
 trait http
7 7
 {
8
- /**
8
+    /**
9 9
      * Message to show error when baseUrl given in service.config.xml is invalid.
10 10
      *
11 11
      * @param bool $notEndWithSvcOrHasQuery Base url end with svc or not
@@ -36,12 +36,12 @@  discard block
 block discarded – undo
36 36
     }
37 37
 
38 38
 /**
39
-     * Message to show error when data service found a request method other than GET.
40
-     *
41
-     * @param HTTPRequestMethod $method Request method
42
-     *
43
-     * @return string The formatted message
44
-     */
39
+ * Message to show error when data service found a request method other than GET.
40
+ *
41
+ * @param HTTPRequestMethod $method Request method
42
+ *
43
+ * @return string The formatted message
44
+ */
45 45
     public static function onlyReadSupport(HTTPRequestMethod $method)
46 46
     {
47 47
         return "This release of library support only GET (read) request, received a request with method $method";
Please login to merge, or discard this patch.
src/POData/Common/Messages/resourceType.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 
4 4
 trait resourceType{
5 5
 /**
6
-     * Format a message to show error when a tyring to set a
7
-     * base class for primitive type.
8
-     *
9
-     * @return string The message
10
-     */
6
+ * Format a message to show error when a tyring to set a
7
+ * base class for primitive type.
8
+ *
9
+ * @return string The message
10
+ */
11 11
     public static function resourceTypeNoBaseTypeForPrimitive()
12 12
     {
13 13
         return 'Primitive type cannot have base type';
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace POData\Common\Messages;
3 3
 
4
-trait resourceType{
4
+trait resourceType {
5 5
 /**
6 6
      * Format a message to show error when a tyring to set a
7 7
      * base class for primitive type.
Please login to merge, or discard this patch.