Algo-Web / POData-Laravel

src/Controllers/ODataController.php

Unused Use Statements -4 removed lines

@@ -4,12 +4,8 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Http\Response;
-
-use App\Http\Requests;
 use App\Http\Controllers\Controller;
 use Illuminate\Support\Facades\App;
-use Illuminate\Foundation\Application;
-
 use POData\OperationContext\ServiceHost as ServiceHost;
 use POData\SimpleDataService as DataService;
 use POData\OperationContext\Web\Illuminate\IlluminateOperationContext as OperationContextAdapter;

src/Models/MetadataTrait.php

Unused Use Statements -14 removed lines

@@ -1,26 +1,12 @@
 <?php
 namespace AlgoWeb\PODataLaravel\Models;
 
-use Doctrine\DBAL\Exception\InvalidArgumentException;
 use Illuminate\Support\Facades\Schema;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\App;
-use Illuminate\Support\Str;
 use Illuminate\Database\Eloquent\Relations\Relation;
-
 use POData\Providers\Metadata\ResourceStreamInfo;
-use POData\Providers\Metadata\ResourceAssociationSetEnd;
-use POData\Providers\Metadata\ResourceAssociationSet;
-use POData\Common\NotImplementedException;
 use POData\Providers\Metadata\Type\EdmPrimitiveType;
-use POData\Providers\Metadata\ResourceSet;
-use POData\Providers\Metadata\ResourcePropertyKind;
-use POData\Providers\Metadata\ResourceProperty;
-use POData\Providers\Metadata\ResourceTypeKind;
-use POData\Providers\Metadata\ResourceType;
-use POData\Common\InvalidOperationException;
-use POData\Providers\Metadata\IMetadataProvider;
-use POData\Providers\Metadata\SimpleMetadataProvider;
 use Illuminate\Database\Eloquent\Model;
 
 trait MetadataTrait

Indentation +10 added lines, -10 removed lines

@@ -229,16 +229,16 @@
                     $begin = strpos($code, 'function(');
                     $code = substr($code, $begin, strrpos($code, '}') - $begin + 1);
                     foreach (array(
-                               'hasMany',
-                               'hasManyThrough',
-                               'belongsToMany',
-                               'hasOne',
-                               'belongsTo',
-                               'morphOne',
-                               'morphTo',
-                               'morphMany',
-                               'morphToMany'
-                             ) as $relation) {
+                                'hasMany',
+                                'hasManyThrough',
+                                'belongsToMany',
+                                'hasOne',
+                                'belongsTo',
+                                'morphOne',
+                                'morphTo',
+                                'morphMany',
+                                'morphToMany'
+                                ) as $relation) {
                         $search = '$this->' . $relation . '(';
                         if ($pos = stripos($code, $search)) {
                             //Resolve the relation's model to a Relation object.

Spacing +7 added lines, -7 removed lines

@@ -60,7 +60,7 @@ 
         }*/
             assert(
                 Schema::connection($connName)->hasTable($this->table),
-                $this->table . ' table not present in current db, ' . $this->getConnectionName()
+                $this->table.' table not present in current db, '.$this->getConnectionName()
             );
         
 
@@ -120,7 +120,7 @@ 
             if ($key == $keyName) {
                 continue;
             }
-            if($secret['type'] == "blob"){
+            if ($secret['type'] == "blob") {
                 $complex->setMediaLinkEntry(true);
                 $streamInfo = new ResourceStreamInfo($key);
                 $complex->addNamedStream($streamInfo);
@@ -219,7 +219,7 @@ 
                     $reflection = new \ReflectionMethod($model, $method);
 
                     $file = new \SplFileObject($reflection->getFileName());
-                    $file->seek($reflection->getStartLine() - 1);
+                    $file->seek($reflection->getStartLine()-1);
                     $code = '';
                     while ($file->key() < $reflection->getEndLine()) {
                         $code .= $file->current();
@@ -227,7 +227,7 @@ 
                     }
                     $code = trim(preg_replace('/\s\s+/', '', $code));
                     $begin = strpos($code, 'function(');
-                    $code = substr($code, $begin, strrpos($code, '}') - $begin + 1);
+                    $code = substr($code, $begin, strrpos($code, '}')-$begin+1);
                     foreach (array(
                                'hasMany',
                                'hasManyThrough',
@@ -239,12 +239,12 @@ 
                                'morphMany',
                                'morphToMany'
                              ) as $relation) {
-                        $search = '$this->' . $relation . '(';
+                        $search = '$this->'.$relation.'(';
                         if ($pos = stripos($code, $search)) {
                             //Resolve the relation's model to a Relation object.
                             $relationObj = $model->$method();
                             if ($relationObj instanceof Relation) {
-                                $relatedModel = '\\' . get_class($relationObj->getRelated());
+                                $relatedModel = '\\'.get_class($relationObj->getRelated());
                                 $relations = ['hasManyThrough', 'belongsToMany', 'hasMany', 'morphMany', 'morphToMany'];
                                 if (in_array($relation, $relations)) {
                                     //Collection or array of models (because Collection is Arrayable)
@@ -269,7 +269,7 @@ 
                                     $relationships["HasOne"][$method] = $relatedModel;
                                     //$this->setProperty($method, $relatedModel, true, null);
                                 }
-                                if (in_array($relation, ["morphMany","morphOne"])) {
+                                if (in_array($relation, ["morphMany", "morphOne"])) {
                                     $relationships["KnownPolyMorphSide"][$method] = $relatedModel;
                                 }
                             }

src/Query/LaravelExpressionProvider.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\PropertyAccessExpression;
 use POData\UriProcessor\QueryProcessor\FunctionDescription;
 use POData\Providers\Expression\IExpressionProvider;
-use Illuminate\Support\Str;
 
 class LaravelExpressionProvider implements IExpressionProvider
 {

Indentation +1 added lines, -1 removed lines

@@ -285,7 +285,7 @@
                 .' ' . $str[1] . self::CLOSE_BRACKET;
         }
         //return self::OPEN_BRACKET . $left . ' ' . $operator . ' ' . $right . self::CLOSE_BRACKET;
-	    return $this->getSql();
+        return $this->getSql();
     }
     /**
      * To format unary expression.

Spacing +9 added lines, -9 removed lines

@@ -240,17 +240,17 @@ 
             case ODataConstants::DATETIME_COMPARE:
                 return "DATETIMECMP($params[0]; $params[1])";
             case ODataConstants::DATETIME_YEAR:
-                return 'EXTRACT(YEAR from ' . $params[0] . ')';
+                return 'EXTRACT(YEAR from '.$params[0].')';
             case ODataConstants::DATETIME_MONTH:
-                return 'EXTRACT(MONTH from ' . $params[0] . ')';
+                return 'EXTRACT(MONTH from '.$params[0].')';
             case ODataConstants::DATETIME_DAY:
-                return 'EXTRACT(DAY from ' . $params[0] . ')';
+                return 'EXTRACT(DAY from '.$params[0].')';
             case ODataConstants::DATETIME_HOUR:
-                return 'EXTRACT(HOUR from ' . $params[0] . ')';
+                return 'EXTRACT(HOUR from '.$params[0].')';
             case ODataConstants::DATETIME_MINUTE:
-                return 'EXTRACT(MINUTE from ' . $params[0] . ')';
+                return 'EXTRACT(MINUTE from '.$params[0].')';
             case ODataConstants::DATETIME_SECOND:
-                return 'EXTRACT(SECOND from ' . $params[0] . ')';
+                return 'EXTRACT(SECOND from '.$params[0].')';
             case ODataConstants::MATHFUN_ROUND:
                 return "ROUND($params[0])";
             case ODataConstants::MATHFUN_CEILING:
@@ -281,8 +281,8 @@ 
             $str = explode(';', $left, 2);
             $str[0] = str_replace('DATETIMECMP', '', $str[0]);
             return self::OPEN_BRACKET
-                .$str[0] . ' ' . $operator
-                .' ' . $str[1] . self::CLOSE_BRACKET;
+                .$str[0].' '.$operator
+                .' '.$str[1].self::CLOSE_BRACKET;
         }
         //return self::OPEN_BRACKET . $left . ' ' . $operator . ' ' . $right . self::CLOSE_BRACKET;
 	    return $this->getSql();
@@ -297,7 +297,7 @@ 
      */
     private function _prepareUnaryExpression($operator, $child)
     {
-        return $operator . self::OPEN_BRACKET . $child . self::CLOSE_BRACKET;
+        return $operator.self::OPEN_BRACKET.$child.self::CLOSE_BRACKET;
     }
 
     private function getSql()

src/Providers/MetadataProvider.php

Spacing +4 added lines, -4 removed lines

@@ -22,7 +22,7 @@ 
     public function boot()
     {
         self::$METANAMESPACE = env('ODataMetaNamespace', 'Data');
-        if(\App::runningInConsole() && count($_SERVER[ 'argv' ]) > 1 && $_SERVER[ 'argv' ][0] == "artisan"){
+        if (\App::runningInConsole() && count($_SERVER['argv']) > 1 && $_SERVER['argv'][0] == "artisan") {
            return;
         }
 
@@ -83,13 +83,13 @@ 
         }
     }
 
-    private static function setupRoute(){
+    private static function setupRoute() {
         $valueArray = [];
 
         Route::any('odata.svc/{section}', 'AlgoWeb\PODataLaravel\Controllers\ODataController@index') ->where(['section' => '.*']);
         Route::any('odata.svc', 'AlgoWeb\PODataLaravel\Controllers\ODataController@index');
 
-        Route::get('/', function () use ($valueArray) {
+        Route::get('/', function() use ($valueArray) {
             $array = array(
                 '@odata.context' => Config::get('app.url').'/$metadata',
                 'value' => $valueArray
@@ -105,7 +105,7 @@ 
      */
     public function register()
     {
-        $this->app->singleton('metadata', function ($app) {
+        $this->app->singleton('metadata', function($app) {
             return new SimpleMetadataProvider('Data', self::$METANAMESPACE);
         });
     }

src/Providers/QueryProvider.php

Indentation +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     public function register()
     {
         $this->app->singleton('odataquery', function ($app) {
-           return new LaravelQuery();
+            return new LaravelQuery();
         });
     }
 }

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      */
     public function register()
     {
-        $this->app->singleton('odataquery', function ($app) {
+        $this->app->singleton('odataquery', function($app) {
            return new LaravelQuery();
         });
     }

src/Query/LaravelQuery.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     public function __construct()
     {
         /* MySQLExpressionProvider();*/
-        $this->expression = new LaravelExpressionProvider(DB::table('dummy'));//PHPExpressionProvider('expression');
+        $this->expression = new LaravelExpressionProvider(DB::table('dummy')); //PHPExpressionProvider('expression');
         $this->queryProviderClassName = get_class($this);
     }