Algo-Web / POData-Laravel

src/Providers/MetadataControllerProvider.php

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
      */
     public function register()
     {
-        $this->app->singleton('metadataControllers', function ($app) {
+        $this->app->singleton('metadataControllers', function($app) {
             return new MetadataControllerContainer();
         });
     }

Unused Use Statements -2 removed lines

@@ -3,9 +3,7 @@
 namespace AlgoWeb\PODataLaravel\Providers;
 
 use AlgoWeb\PODataLaravel\Controllers\MetadataControllerTrait;
-use AlgoWeb\PODataLaravel\Controllers\TestController;
 use Illuminate\Routing\Controller;
-use Illuminate\Support\ServiceProvider;
 use Illuminate\Support\Facades\Cache;
 use AlgoWeb\PODataLaravel\Controllers\MetadataControllerContainer;
 use Illuminate\Support\Facades\App;

src/Providers/QueryProvider.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      */
     public function register()
     {
-        $this->app->singleton('odataquery', function ($app) {
+        $this->app->singleton('odataquery', function($app) {
             return new LaravelQuery();
         });
     }

src/Query/LaravelQuery.php

Doc Comments +2 added lines, -2 removed lines

@@ -315,7 +315,7 @@ 
     }
     /**
      * Delete resource from a resource set.
-     * @param ResourceSet|null $sourceResourceSet
+     * @param ResourceSet $sourceResourceSet
      * @param object           $sourceEntityInstance
      *
      * return bool true if resources sucessfully deteled, otherwise false.
@@ -460,7 +460,7 @@ 
      * @param ResourceSet $sourceResourceSet
      * @param $sourceEntityInstance
      * @param $data
-     * @param $verb
+     * @param string $verb
      * @return mixed
      * @throws ODataException
      * @throws \POData\Common\InvalidOperationException

Spacing +1 added lines, -1 removed lines

@@ -490,7 +490,7 @@
         }
         $outData = $result->getData();
         if (is_object($outData)) {
-            $outData = (array)$outData;
+            $outData = (array) $outData;
         }
 
         if (!is_array($outData)) {

src/Query/LaravelReadQuery.php

Spacing +2 added lines, -2 removed lines

@@ -96,14 +96,14 @@
             // loop thru, chunk by chunk, to reduce chances of exhausting memory
             $sourceEntityInstance->chunk(
                 5000,
-                function ($results) use ($isvalid, &$skipToken, &$resultSet, &$rawCount, $rawTop) {
+                function($results) use ($isvalid, &$skipToken, &$resultSet, &$rawCount, $rawTop) {
                     // apply filter
                     $results = $results->filter($isvalid);
                     // need to iterate through full result set to find count of items matching filter,
                     // so we can't bail out early
                     $rawCount += $results->count();
                     // now bolt on filtrate to accumulating result set if we haven't accumulated enough bitz
-                    if ($rawTop > $resultSet->count() + $skipToken) {
+                    if ($rawTop > $resultSet->count()+$skipToken) {
                         $resultSet = collect(array_merge($resultSet->all(), $results->all()));
                         $sliceAmount = min($skipToken, $resultSet->count());
                         $resultSet = $resultSet->slice($sliceAmount);

Doc Comments +1 added lines

@@ -346,6 +346,7 @@
 
     /**
      * @param $sourceEntityInstance
+     * @param Model $checkInstance
      * @throws ODataException
      */
     private function checkAuth($sourceEntityInstance, $checkInstance = null)

src/Models/MetadataTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -414,8 +414,8 @@
      * @param $first
      * @param $property
      * @param $last
-     * @param $mult
-     * @param $targ
+     * @param string $mult
+     * @param string $targ
      */
     private function addRelationsHook(&$hooks, $first, $property, $last, $mult, $targ)
     {

Spacing +7 added lines, -7 removed lines

@@ -513,10 +513,10 @@ 
 
             $keyRaw = $isBelong ? $foo->$fkMethodName() : $foo->$fkMethodAlternate();
             $keySegments = explode('.', $keyRaw);
-            $keyName = $keySegments[count($keySegments) - 1];
+            $keyName = $keySegments[count($keySegments)-1];
             $localRaw = $isBelong ? $foo->$rkMethodName() : $foo->$rkMethodAlternate();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
             $first = $keyName;
             $last = $localName;
             $this->addRelationsHook($hooks, $first, $property, $last, $mult, $targ);
@@ -543,7 +543,7 @@ 
             $keyName = $isBelong ? $foo->$fkMethodName() : $foo->$fkMethodAlternate();
             $localRaw = $isBelong ? $foo->$rkMethodName() : $foo->$rkMethodAlternate();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
             $first = $isBelong ? $localName : $keyName;
             $last = $isBelong ? $keyName : $localName;
             $this->addRelationsHook($hooks, $first, $property, $last, $mult, $targ);
@@ -567,10 +567,10 @@ 
 
             $keyRaw = $isMany ? $foo->$fkMethodName() : $foo->$fkMethodAlternate();
             $keySegments = explode('.', $keyRaw);
-            $keyName = $keySegments[count($keySegments) - 1];
+            $keyName = $keySegments[count($keySegments)-1];
             $localRaw = $isMany ? $foo->$rkMethodName() : $foo->$rkMethodAlternate();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
             $first = $isMany ? $keyName : $localName;
             $last = $isMany ? $localName : $keyName;
             $this->addRelationsHook($hooks, $first, $property, $last, $mult, $targ);
@@ -593,10 +593,10 @@ 
 
             $keyRaw = $isMany ? $foo->$fkMethodName() : $foo->$fkMethodAlternate();
             $keySegments = explode('.', $keyRaw);
-            $keyName = $keySegments[count($keySegments) - 1];
+            $keyName = $keySegments[count($keySegments)-1];
             $localRaw = $isMany ? $foo->$rkMethodName() : $foo->$rkMethodAlternate();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
 
             $first = $keyName;
             $last = $localName;

src/Providers/MetadataProvider.php

Spacing +6 added lines, -6 removed lines

@@ -12,7 +12,7 @@ 
 
 class MetadataProvider extends MetadataBaseProvider
 {
-    protected $multConstraints = [ '0..1' => ['1'], '1' => ['0..1', '*'], '*' => ['1', '*']];
+    protected $multConstraints = ['0..1' => ['1'], '1' => ['0..1', '*'], '*' => ['1', '*']];
     protected static $METANAMESPACE = "Data";
 
     /**
@@ -75,7 +75,7 @@ 
      */
     public function register()
     {
-        $this->app->singleton('metadata', function ($app) {
+        $this->app->singleton('metadata', function($app) {
             return new SimpleMetadataProvider('Data', self::$METANAMESPACE);
         });
     }
@@ -196,11 +196,11 @@ 
                     $dependentProperty = $foreign[$dependentType]['property'];
                     assert(
                         in_array($dependentMult, $this->multConstraints[$principalMult]),
-                        "Cannot pair multiplicities " . $dependentMult . " and " . $principalMult
+                        "Cannot pair multiplicities ".$dependentMult." and ".$principalMult
                     );
                     assert(
                         in_array($principalMult, $this->multConstraints[$dependentMult]),
-                        "Cannot pair multiplicities " . $principalMult . " and " . $dependentMult
+                        "Cannot pair multiplicities ".$principalMult." and ".$dependentMult
                     );
                     // generate forward and reverse relations
                     list($forward, $reverse) = $this->calculateRoundTripRelationsGenForwardReverse(
@@ -244,11 +244,11 @@ 
                         $dependentProperty = $foreign['property'];
                         assert(
                             in_array($dependentMult, $this->multConstraints[$principalMult]),
-                            "Cannot pair multiplicities " . $dependentMult . " and " . $principalMult
+                            "Cannot pair multiplicities ".$dependentMult." and ".$principalMult
                         );
                         assert(
                             in_array($principalMult, $this->multConstraints[$dependentMult]),
-                            "Cannot pair multiplicities " . $principalMult . " and " . $dependentMult
+                            "Cannot pair multiplicities ".$principalMult." and ".$dependentMult
                         );
                         // generate forward and reverse relations
                         list($forward, $reverse) = $this->calculateRoundTripRelationsGenForwardReverse(

Unused Use Statements -3 removed lines

@@ -3,12 +3,9 @@
 namespace AlgoWeb\PODataLaravel\Providers;
 
 use Illuminate\Support\Facades\App;
-use Illuminate\Support\ServiceProvider;
 use Illuminate\Support\Facades\Cache;
 use POData\Providers\Metadata\IMetadataProvider;
-use POData\Providers\Metadata\ResourceType;
 use POData\Providers\Metadata\SimpleMetadataProvider;
-use Illuminate\Support\Facades\Route;
 use Illuminate\Support\Facades\Schema as Schema;
 
 class MetadataProvider extends MetadataBaseProvider

src/Providers/MetadataRouteProvider.php

Spacing +2 added lines, -2 removed lines

@@ -21,12 +21,12 @@
     {
         Route::any(
             'odata.svc/{section}',
-            [ 'uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
+            ['uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
         )
             ->where(['section' => '.*']);
         Route::any(
             'odata.svc',
-            [ 'uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
+            ['uses' => 'AlgoWeb\PODataLaravel\Controllers\ODataController@index', 'middleware' => 'auth.basic']
         );
     }
 

src/Query/LaravelExpressionProvider.php

Spacing +25 added lines, -25 removed lines

@@ -51,80 +51,80 @@
      */
     public function __construct()
     {
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_COMPARE] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_COMPARE] = function($params) {
             return "strcmp($params[0], $params[1])";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_ENDSWITH] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_ENDSWITH] = function($params) {
             return "(strcmp(substr($params[0], strlen($params[0]) - strlen($params[1])), $params[1]) === 0)";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_INDEXOF] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_INDEXOF] = function($params) {
             return "strpos($params[0], $params[1])";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_REPLACE] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_REPLACE] = function($params) {
             return "str_replace($params[1], $params[2], $params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_STARTSWITH] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_STARTSWITH] = function($params) {
             return "(strpos($params[0], $params[1]) === 0)";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOLOWER] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOLOWER] = function($params) {
             return "strtolower($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOUPPER] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOUPPER] = function($params) {
             return "strtoupper($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_TRIM] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_TRIM] = function($params) {
             return "trim($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRING] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRING] = function($params) {
             return count($params) == 3 ?
                 "substr($params[0], $params[1], $params[2])" : "substr($params[0], $params[1])";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRINGOF] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRINGOF] = function($params) {
             return "(strpos($params[1], $params[0]) !== false)";
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_CONCAT] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_CONCAT] = function($params) {
             return $params[0].' . '.$params[1];
         };
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_LENGTH] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_LENGTH] = function($params) {
             return "strlen($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::GUIDFUN_EQUAL] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::GUIDFUN_EQUAL] = function($params) {
             return self::TYPE_NAMESPACE."Guid::guidEqual($params[0], $params[1])";
         };
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_COMPARE] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_COMPARE] = function($params) {
             return self::TYPE_NAMESPACE."DateTime::dateTimeCmp($params[0], $params[1])";
         };
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_YEAR] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_YEAR] = function($params) {
             return self::TYPE_NAMESPACE."DateTime::year($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_MONTH] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_MONTH] = function($params) {
             return self::TYPE_NAMESPACE."DateTime::month($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_DAY] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_DAY] = function($params) {
             return self::TYPE_NAMESPACE."DateTime::day($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_HOUR] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_HOUR] = function($params) {
             return self::TYPE_NAMESPACE."DateTime::hour($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_MINUTE] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_MINUTE] = function($params) {
             return self::TYPE_NAMESPACE."DateTime::minute($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_SECOND] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_SECOND] = function($params) {
             return self::TYPE_NAMESPACE."DateTime::second($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::MATHFUN_ROUND] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::MATHFUN_ROUND] = function($params) {
             return "round($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::MATHFUN_CEILING] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::MATHFUN_CEILING] = function($params) {
             return "ceil($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::MATHFUN_FLOOR] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::MATHFUN_FLOOR] = function($params) {
             return "floor($params[0])";
         };
-        $this->functionDescriptionParsers[ODataConstants::BINFUL_EQUAL] = function ($params) {
+        $this->functionDescriptionParsers[ODataConstants::BINFUL_EQUAL] = function($params) {
             return self::TYPE_NAMESPACE."Binary::binaryEqual($params[0], $params[1])";
         };
-        $this->functionDescriptionParsers['is_null'] = function ($params) {
+        $this->functionDescriptionParsers['is_null'] = function($params) {
             return "is_null($params[0])";
         };
     }

src/Controllers/ODataController.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     }
 
     /**
-     * @return mixed
+     * @return boolean
      */
     protected function getIsDumping()
     {

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
             $date = Carbon::now(0);
             $timeString = $date->toTimeString();
             $xTest = (null !== $xTest) ? $xTest
-                : $request->method() . ";" . str_replace("/", "-", $request->path()) . ";" . $timeString . ";";
+                : $request->method().";".str_replace("/", "-", $request->path()).";".$timeString.";";
             if (null != $xTest) {
                 $reflectionClass = new \ReflectionClass('Illuminate\Http\Request');
                 $reflectionProperty = $reflectionClass->getProperty('userResolver');