View GitHub Repository POData-Laravel

Schedule Inspection
Subscribe
Test Failed
Pull Request — master (#39)
by Christopher
04:01
created
Status
Category
Toggle Patches
src/Providers/MetadataProvider.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -98,7 +98,7 @@
 
 block discarded – undo
98 98 
      */
99 99 
     public function register()
100 100 
     {
101 
-        $this->app->singleton('metadata', function ($app) {
101 
+        $this->app->singleton('metadata', function($app) {
102 102 
             return new SimpleMetadataProvider('Data', self::$METANAMESPACE);
103 103 
         });
104 104 
     }
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -3,7 +3,6 @@
 
 block discarded – undo
3 3 
 namespace AlgoWeb\PODataLaravel\Providers;
4 4
5 5 
 use Illuminate\Support\Facades\App;
6 
-use Illuminate\Support\ServiceProvider;
7 6 
 use Illuminate\Support\Facades\Cache;
8 7 
 use POData\Providers\Metadata\IMetadataProvider;
9 8 
 use POData\Providers\Metadata\SimpleMetadataProvider;
Please login to merge, or discard this patch.
src/Providers/MetadataControllerProvider.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -79,7 +79,7 @@
 
 block discarded – undo
79 79 
      */
80 80 
     public function register()
81 81 
     {
82 
-        $this->app->singleton('metadataControllers', function ($app) {
82 
+        $this->app->singleton('metadataControllers', function($app) {
83 83 
             return new MetadataControllerContainer();
84 84 
         });
85 85 
     }
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -3,7 +3,6 @@
 
 block discarded – undo
3 3 
 namespace AlgoWeb\PODataLaravel\Providers;
4 4
5 5 
 use AlgoWeb\PODataLaravel\Controllers\MetadataControllerTrait;
6 
-use Illuminate\Support\ServiceProvider;
7 6 
 use Illuminate\Support\Facades\Cache;
8 7 
 use AlgoWeb\PODataLaravel\Controllers\MetadataControllerContainer;
9 8 
 use Illuminate\Support\Facades\App;
Please login to merge, or discard this patch.
src/Providers/QueryProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -24,7 +24,7 @@
 
 block discarded – undo
24 24 
      */
25 25 
     public function register()
26 26 
     {
27 
-        $this->app->singleton('odataquery', function ($app) {
27 
+        $this->app->singleton('odataquery', function($app) {
28 28 
             return new LaravelQuery();
29 29 
         });
30 30 
     }
Please login to merge, or discard this patch.
src/Query/LaravelQuery.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -490,7 +490,7 @@
 
 block discarded – undo
490 490 
         }
491 491 
         $outData = $result->getData();
492 492 
         if (is_object($outData)) {
493 
-            $outData = (array)$outData;
493 
+            $outData = (array) $outData;
494 494 
         }
495 495
496 496 
         if (!is_array($outData)) {
Please login to merge, or discard this patch.
src/Query/LaravelExpressionProvider.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch 
@@ -51,80 +51,80 @@  discard block
 
 block discarded – undo
51 51 
      */
52 52 
     public function __construct()
53 53 
     {
54 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_COMPARE] = function($params){
54 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_COMPARE] = function($params) {
55 55 
             return "strcmp($params[0], $params[1])";
56 56 
         };
57 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_ENDSWITH] = function($params){
57 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_ENDSWITH] = function($params) {
58 58 
             return "(strcmp(substr($params[0], strlen($params[0]) - strlen($params[1])), $params[1]) === 0)";
59 59 
         };
60 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_INDEXOF] = function($params){
60 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_INDEXOF] = function($params) {
61 61 
             return "strpos($params[0], $params[1])";
62 62 
         };
63 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_REPLACE] = function($params){
63 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_REPLACE] = function($params) {
64 64 
             return "str_replace($params[1], $params[2], $params[0])";
65 65 
         };
66 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_STARTSWITH] = function($params){
66 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_STARTSWITH] = function($params) {
67 67 
             return "(strpos($params[0], $params[1]) === 0)";
68 68 
         };
69 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOLOWER] = function($params){
69 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOLOWER] = function($params) {
70 70 
             return "strtolower($params[0])";
71 71 
         };
72 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOUPPER] = function($params){
72 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_TOUPPER] = function($params) {
73 73 
             return "strtoupper($params[0])";
74 74 
         };
75 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_TRIM] = function($params){
75 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_TRIM] = function($params) {
76 76 
             return "trim($params[0])";
77 77 
         };
78 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRING] = function($params){
78 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRING] = function($params) {
79 79 
             return count($params) == 3 ?
80 80 
                 "substr($params[0], $params[1], $params[2])" : "substr($params[0], $params[1])";
81 81 
         };
82 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRINGOF] = function($params){
82 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_SUBSTRINGOF] = function($params) {
83 83 
             return "(strpos($params[1], $params[0]) !== false)";
84 84 
         };
85 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_CONCAT] = function($params){
85 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_CONCAT] = function($params) {
86 86 
             return $params[0].' . '.$params[1];
87 87 
         };
88 
-        $this->functionDescriptionParsers[ODataConstants::STRFUN_LENGTH] = function($params){
88 
+        $this->functionDescriptionParsers[ODataConstants::STRFUN_LENGTH] = function($params) {
89 89 
             return "strlen($params[0])";
90 90 
         };
91 
-        $this->functionDescriptionParsers[ODataConstants::GUIDFUN_EQUAL] = function($params){
91 
+        $this->functionDescriptionParsers[ODataConstants::GUIDFUN_EQUAL] = function($params) {
92 92 
             return self::TYPE_NAMESPACE."Guid::guidEqual($params[0], $params[1])";
93 93 
         };
94 
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_COMPARE] = function($params){
94 
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_COMPARE] = function($params) {
95 95 
             return self::TYPE_NAMESPACE."DateTime::dateTimeCmp($params[0], $params[1])";
96 96 
         };
97 
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_YEAR] = function($params){
97 
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_YEAR] = function($params) {
98 98 
             return self::TYPE_NAMESPACE."DateTime::year($params[0])";
99 99 
         };
100 
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_MONTH] = function($params){
100 
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_MONTH] = function($params) {
101 101 
             return self::TYPE_NAMESPACE."DateTime::month($params[0])";
102 102 
         };
103 
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_DAY] = function($params){
103 
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_DAY] = function($params) {
104 104 
             return self::TYPE_NAMESPACE."DateTime::day($params[0])";
105 105 
         };
106 
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_HOUR] = function($params){
106 
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_HOUR] = function($params) {
107 107 
             return self::TYPE_NAMESPACE."DateTime::hour($params[0])";
108 108 
         };
109 
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_MINUTE] = function($params){
109 
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_MINUTE] = function($params) {
110 110 
             return self::TYPE_NAMESPACE."DateTime::minute($params[0])";
111 111 
         };
112 
-        $this->functionDescriptionParsers[ODataConstants::DATETIME_SECOND] = function($params){
112 
+        $this->functionDescriptionParsers[ODataConstants::DATETIME_SECOND] = function($params) {
113 113 
             return self::TYPE_NAMESPACE."DateTime::second($params[0])";
114 114 
         };
115 
-        $this->functionDescriptionParsers[ODataConstants::MATHFUN_ROUND] = function($params){
115 
+        $this->functionDescriptionParsers[ODataConstants::MATHFUN_ROUND] = function($params) {
116 116 
             return "round($params[0])";
117 117 
         };
118 
-        $this->functionDescriptionParsers[ODataConstants::MATHFUN_CEILING] = function($params){
118 
+        $this->functionDescriptionParsers[ODataConstants::MATHFUN_CEILING] = function($params) {
119 119 
             return "ceil($params[0])";
120 120 
         };
121 
-        $this->functionDescriptionParsers[ODataConstants::MATHFUN_FLOOR] = function($params){
121 
+        $this->functionDescriptionParsers[ODataConstants::MATHFUN_FLOOR] = function($params) {
122 122 
             return "floor($params[0])";
123 123 
         };
124 
-        $this->functionDescriptionParsers[ODataConstants::BINFUL_EQUAL] = function($params){
124 
+        $this->functionDescriptionParsers[ODataConstants::BINFUL_EQUAL] = function($params) {
125 125 
             return self::TYPE_NAMESPACE."Binary::binaryEqual($params[0], $params[1])";
126 126 
         };
127 
-        $this->functionDescriptionParsers['is_null'] = function($params){
127 
+        $this->functionDescriptionParsers['is_null'] = function($params) {
128 128 
             return "is_null($params[0])";
129 129 
         };
130 130 
     }
 
@@ -301,7 +301,7 @@  discard block
 
 block discarded – undo
301 301 
         if (!isset($functionDescription)) {
302 302 
             throw new \InvalidArgumentException('onFunctionCallExpression');
303 303 
         }
304 
-        if(!array_key_exists ($functionDescription->name, $this->functionDescriptionParsers)){
304 
+        if (!array_key_exists($functionDescription->name, $this->functionDescriptionParsers)) {
305 305 
                 throw new \InvalidArgumentException('onFunctionCallExpression');
306 306 
         }
307 307 
         return $this->functionDescriptionParsers[$functionDescription->name]($params);
Please login to merge, or discard this patch.