Algo-Web / POData-Laravel

src/Providers/MetadataControllerProvider.php

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
      */
     public function register()
     {
-        $this->app->singleton('metadataControllers', function ($app) {
+        $this->app->singleton('metadataControllers', function($app) {
             return new MetadataControllerContainer();
         });
     }

Unused Use Statements -2 removed lines

@@ -3,9 +3,7 @@
 namespace AlgoWeb\PODataLaravel\Providers;
 
 use AlgoWeb\PODataLaravel\Controllers\MetadataControllerTrait;
-use AlgoWeb\PODataLaravel\Controllers\TestController;
 use Illuminate\Routing\Controller;
-use Illuminate\Support\ServiceProvider;
 use Illuminate\Support\Facades\Cache;
 use AlgoWeb\PODataLaravel\Controllers\MetadataControllerContainer;
 use Illuminate\Support\Facades\App;

src/Providers/QueryProvider.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      */
     public function register()
     {
-        $this->app->singleton('odataquery', function ($app) {
+        $this->app->singleton('odataquery', function($app) {
             return new LaravelQuery();
         });
     }

src/Query/LaravelQuery.php

Spacing +1 added lines, -1 removed lines

@@ -490,7 +490,7 @@
         }
         $outData = $result->getData();
         if (is_object($outData)) {
-            $outData = (array)$outData;
+            $outData = (array) $outData;
         }
 
         if (!is_array($outData)) {

src/Providers/MetadataProvider.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace AlgoWeb\PODataLaravel\Providers;
 
 use Illuminate\Support\Facades\App;
-use Illuminate\Support\ServiceProvider;
 use Illuminate\Support\Facades\Cache;
 use POData\Providers\Metadata\IMetadataProvider;
 use POData\Providers\Metadata\SimpleMetadataProvider;

Spacing +6 added lines, -6 removed lines

@@ -12,7 +12,7 @@ 
 
 class MetadataProvider extends MetadataBaseProvider
 {
-    protected $multConstraints = [ '0..1' => ['1'], '1' => ['0..1', '*'], '*' => ['1', '*']];
+    protected $multConstraints = ['0..1' => ['1'], '1' => ['0..1', '*'], '*' => ['1', '*']];
     protected static $METANAMESPACE = "Data";
 
     /**
@@ -75,7 +75,7 @@ 
      */
     public function register()
     {
-        $this->app->singleton('metadata', function ($app) {
+        $this->app->singleton('metadata', function($app) {
             return new SimpleMetadataProvider('Data', self::$METANAMESPACE);
         });
     }
@@ -168,11 +168,11 @@ 
                         $dependentProperty = $foreign['property'];
                         assert(
                             in_array($dependentMult, $this->multConstraints[$principalMult]),
-                            "Cannot pair multiplicities ".$dependentMult. " and ".$principalMult
+                            "Cannot pair multiplicities ".$dependentMult." and ".$principalMult
                         );
                         assert(
                             in_array($principalMult, $this->multConstraints[$dependentMult]),
-                            "Cannot pair multiplicities ".$principalMult. " and ".$dependentMult
+                            "Cannot pair multiplicities ".$principalMult." and ".$dependentMult
                         );
                         // add forward relation
                         $forward = ['principalType' => $principalType, 'principalMult' => $principalMult,
@@ -230,11 +230,11 @@ 
                     $dependentProperty = $foreign[$dependentType]['property'];
                     assert(
                         in_array($dependentMult, $this->multConstraints[$principalMult]),
-                        "Cannot pair multiplicities ".$dependentMult. " and ".$principalMult
+                        "Cannot pair multiplicities ".$dependentMult." and ".$principalMult
                     );
                     assert(
                         in_array($principalMult, $this->multConstraints[$dependentMult]),
-                        "Cannot pair multiplicities ".$principalMult. " and ".$dependentMult
+                        "Cannot pair multiplicities ".$principalMult." and ".$dependentMult
                     );
                     // add forward relation
                     $forward = ['principalType' => $principalType, 'principalMult' => $principalMult,

src/Query/LaravelExpressionProvider.php

Spacing +1 added lines, -1 removed lines

@@ -301,7 +301,7 @@
         if (!isset($functionDescription)) {
             throw new \InvalidArgumentException('onFunctionCallExpression');
         }
-        if(!array_key_exists ($functionDescription->name, $this->functionDescriptionParsers)){
+        if (!array_key_exists($functionDescription->name, $this->functionDescriptionParsers)) {
                 throw new \InvalidArgumentException('onFunctionCallExpression');
         }
         return $this->functionDescriptionParsers[$functionDescription->name]($params);

src/Query/LaravelReadQuery.php

Spacing +2 added lines, -2 removed lines

@@ -96,14 +96,14 @@
             // loop thru, chunk by chunk, to reduce chances of exhausting memory
             $sourceEntityInstance->chunk(
                 5000,
-                function ($results) use ($isvalid, &$skipToken, &$resultSet, &$rawCount, $rawTop) {
+                function($results) use ($isvalid, &$skipToken, &$resultSet, &$rawCount, $rawTop) {
                     // apply filter
                     $results = $results->filter($isvalid);
                     // need to iterate through full result set to find count of items matching filter,
                     // so we can't bail out early
                     $rawCount += $results->count();
                     // now bolt on filtrate to accumulating result set if we haven't accumulated enough bitz
-                    if ($rawTop > $resultSet->count() + $skipToken) {
+                    if ($rawTop > $resultSet->count()+$skipToken) {
                         $resultSet = collect(array_merge($resultSet->all(), $results->all()));
                         $sliceAmount = min($skipToken, $resultSet->count());
                         $resultSet = $resultSet->slice($sliceAmount);

src/Models/MetadataTrait.php

Spacing +7 added lines, -7 removed lines

@@ -445,10 +445,10 @@ 
 
             $keyRaw = $isBelong ? $foo->$fkMethodName() : $foo->getForeignKeyName();
             $keySegments = explode('.', $keyRaw);
-            $keyName = $keySegments[count($keySegments) - 1];
+            $keyName = $keySegments[count($keySegments)-1];
             $localRaw = $isBelong ? $foo->$rkMethodName() : $foo->getQualifiedParentKeyName();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
             $first = $keyName;
             $last = $localName;
             $this->addRelationsHook($hooks, $first, $property, $last, $mult, $targ);
@@ -471,7 +471,7 @@ 
             $keyName = $isBelong ? $foo->getForeignKey() : $foo->getForeignKeyName();
             $localRaw = $isBelong ? $foo->getOwnerKey() : $foo->getQualifiedParentKeyName();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
             $first = $isBelong ? $localName : $keyName;
             $last = $isBelong ? $keyName : $localName;
             $this->addRelationsHook($hooks, $first, $property, $last, $mult, $targ);
@@ -496,10 +496,10 @@ 
 
             $keyRaw = $isMany ? $foo->$fkMethodName() : $foo->getForeignKeyName();
             $keySegments = explode('.', $keyRaw);
-            $keyName = $keySegments[count($keySegments) - 1];
+            $keyName = $keySegments[count($keySegments)-1];
             $localRaw = $isMany ? $foo->$rkMethodName() : $foo->getQualifiedParentKeyName();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
             $first = $isMany ? $keyName : $localName;
             $last = $isMany ? $localName : $keyName;
             $this->addRelationsHook($hooks, $first, $property, $last, $mult, $targ);
@@ -523,10 +523,10 @@ 
 
             $keyRaw = $isMany ? $foo->$fkMethodName() : $foo->getForeignKey();
             $keySegments = explode('.', $keyRaw);
-            $keyName = $keySegments[count($keySegments) - 1];
+            $keyName = $keySegments[count($keySegments)-1];
             $localRaw = $isMany ? $foo->$rkMethodName() : $foo->getQualifiedParentKeyName();
             $localSegments = explode('.', $localRaw);
-            $localName = $localSegments[count($localSegments) - 1];
+            $localName = $localSegments[count($localSegments)-1];
 
             $first = $keyName;
             $last = $localName;

Doc Comments +2 added lines, -2 removed lines

@@ -414,8 +414,8 @@
      * @param $first
      * @param $property
      * @param $last
-     * @param $mult
-     * @param $targ
+     * @param string $mult
+     * @param string $targ
      */
     private function addRelationsHook(&$hooks, $first, $property, $last, $mult, $targ)
     {