TrelloCycleTime\Collection\CycleTimesCollection::getFromCardHistory()

Complexity

Conditions	5
Paths	4

Size

Total Lines

15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	5

Importance

Changes

0

<?php
    public function getFromCardHistory(array $cardHistories): array
    {
        foreach ($cardHistories as $history) {
            if ($history->getFrom() === null || $history->getFrom() === '') {
                continue;
            }
            
            $cycleTimeColumn = CycleTime::createFromCardHistory($history);
            if (!isset($this->cycleTimeCollection[$cycleTimeColumn->getName()])) {

Consider using $cycleTimeColumn->name. There is an issue with getName() and APC-enabled PHP versions.

                $this->cycleTimeCollection[$cycleTimeColumn->getName()] = $cycleTimeColumn;

Consider using $cycleTimeColumn->name. There is an issue with getName() and APC-enabled PHP versions.

            }
        }

        return $this->cycleTimeCollection;
    }
}