TrelloCycleTime\Collection\CycleTimesCollection

Complexity

Total Complexity

6

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getFromCardHistory()	0	15	5

<?php

declare(strict_types=1);

namespace TrelloCycleTime\Collection;


use TrelloCycleTime\ValueObject\CycleTime;

class CycleTimesCollection
{
    private $cycleTimeCollection;

    public function __construct()
    {
        $this->cycleTimeCollection = [];
    }

    public function getFromCardHistory(array $cardHistories): array
    {
        foreach ($cardHistories as $history) {
            if ($history->getFrom() === null || $history->getFrom() === '') {
                continue;
            }
            
            $cycleTimeColumn = CycleTime::createFromCardHistory($history);
            if (!isset($this->cycleTimeCollection[$cycleTimeColumn->getName()])) {

Consider using $cycleTimeColumn->name. There is an issue with getName() and APC-enabled PHP versions.

                $this->cycleTimeCollection[$cycleTimeColumn->getName()] = $cycleTimeColumn;

Consider using $cycleTimeColumn->name. There is an issue with getName() and APC-enabled PHP versions.

            }
        }

        return $this->cycleTimeCollection;
    }
}