AlessandroMinoccheri / cakephp-currency-converter

src/Controller/Component/CurrencyConverterComponent.php

Doc Comments +3 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
      * @param float|string $amount the amount to convert.
      * @param string $from currency to convert from
      * @param string $to currency to convert to
-     * @return float $amount converted
+     * @return string $amount converted
      */
     public function convert($amount, $from, $to)
     {
@@ -128,7 +128,8 @@ 
     /**
      * Format float number using configuration
      *
-     * @return floatval
+     * @param double $number
+     * @return string
      */
     private function _formatConvert($number)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace CurrencyConverter\Controller\Component;
 
 use Cake\Controller\Component;
-use Cake\Datasource\ConnectionManager;
 use Cake\ORM\TableRegistry;
 use Cake\I18n\Time;
 

src/View/Helper/CurrencyConverterHelper.php

Doc Comments +4 added lines, -3 removed lines

@@ -48,10 +48,10 @@ 
     /**
      * Convert method take an amount as first parameter and convert it using $from currency and $to currency.
      *
-     * @param float|string $amount the amount to convert.
+     * @param double $amount the amount to convert.
      * @param string $from currency to convert from
      * @param string $to currency to convert to
-     * @return float $amount converted
+     * @return string $amount converted
      */
     public function convert($amount, $from, $to)
     {
@@ -118,7 +118,8 @@ 
     /**
      * Format float number using configuration
      *
-     * @return floatval
+     * @param double $number
+     * @return string
      */
     private function _formatConvert($number)
     {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Cake\View\Helper;
 use Cake\ORM\TableRegistry;
-use Cake\I18n\Time;
 
 /**
  * @property \Cake\View\Helper\HtmlHelper $Html

tests/TestCase/Controller/Component/CurrencyConverterComponentTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use CurrencyConverter\Controller\Component\CurrencyConverterComponent;
 use Cake\Controller\Controller;
 use Cake\Controller\ComponentRegistry;
-use Cake\Event\Event;
 use Cake\Http\ServerRequest;
 use Cake\Http\Response;
 use Cake\TestSuite\TestCase;

tests/TestCase/View/Helper/CurrencyConverterHelperTest.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use Cake\Controller\Controller;
 use Cake\Network\Request;
-use Cake\Routing\Router;
 use Cake\TestSuite\TestCase;
 use Cake\View\View;
 use CurrencyConverter\View\Helper\CurrencyConverterHelper;