Passed
Push — master ( 979b87...272250 )
by Alessandro
02:14
created
src/Controller/Component/CurrencyConverterComponent.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
      * @param boolean $saveIntoDb if develop wants to store convertion rate for use it without resending data to yahoo service.
35 35
      * @param int $hourDifference the hour difference to check if the last convertion is passed, if yes make a new call to yahoo finance api.
36 36
      * @param string $dataSource which dataSOurce need to use
37
-     * @return float the total amount converted into the new currency
37
+     * @return string the total amount converted into the new currency
38 38
      */
39 39
     public function convert(
40 40
         $fromCurrency, 
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Cake\Controller\Component;
6 6
 use Cake\Datasource\ConnectionManager;
7 7
 use Cake\ORM\TableRegistry;
8
-use Cake\Database\Schema\TableSchema;
9 8
 
10 9
 class CurrencyConverterComponent extends Component
11 10
 {
Please login to merge, or discard this patch.
src/Model/Table/CurrencyConvertersTable.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace CurrencyConverter\Model\Table;
4 4
 
5 5
 use Cake\ORM\Table;
6
-use Cake\ORM\Behavior\TimestampBehavior;
7 6
 
8 7
 class CurrencyConvertersTable extends Table
9 8
 {
Please login to merge, or discard this patch.
tests/bootstrap.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use Cake\Cache\Cache;
9 9
 use Cake\Core\Configure;
10 10
 use Cake\Core\Plugin;
11
-use Cake\I18n\I18n;
12 11
 use Cake\Datasource\ConnectionManager;
13 12
 
14 13
 require_once 'vendor/autoload.php';
Please login to merge, or discard this patch.
tests/TestCase/Controller/Component/CurrencyConverterComponentTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,8 +4,6 @@
 block discarded – undo
4 4
 use CurrencyConverter\Controller\Component\CurrencyConverterComponent;
5 5
 use Cake\Controller\Controller;
6 6
 use Cake\Controller\ComponentRegistry;
7
-use Cake\Network\Request;
8
-use Cake\Network\Response;
9 7
 use Cake\TestSuite\TestCase;
10 8
 use Cake\ORM\TableRegistry;
11 9
 
Please login to merge, or discard this patch.