Inspection of "more ajax for component update" - AesopInteractive/lasso - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 498f6d...4e9082 )

unknown

created 2016-10-23 00:57 UTC

Status

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -264,7 +264,7 @@  discard block
 block discarded – undo
 		 );
 		foreach ($_POST as $key => $value) {
 			if ($key !="code" && $key !="action") {
-			    //$shortcode = $shortcode.$key.'="'.$value.'" ';
+				//$shortcode = $shortcode.$key.'="'.$value.'" ';
 				$atts[$key] = $value;
 			}
 		}
@@ -274,32 +274,32 @@  discard block
 block discarded – undo
 		}*/
 		
 		if ($code == "aesop_image") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
-		    echo aesop_image_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
+			echo aesop_image_shortcode($atts);
 		}
 		if ($code == "aesop_quote") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
-		    echo aesop_quote_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
+			echo aesop_quote_shortcode($atts);
 		}
 		
 		if ($code == "aesop_parallax") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
-		    echo aesop_parallax_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
+			echo aesop_parallax_shortcode($atts);
 		}
 		
 		if ($code == "aesop_character") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
-		    echo aesop_character_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
+			echo aesop_character_shortcode($atts);
 		}
 		
 		if ($code == "aesop_chapter") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
-		    echo aesop_chapter_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
+			echo aesop_chapter_shortcode($atts);
 		}
 		
 		if ($code == "aesop_gallery") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
-		    echo do_shortcode( '[aesop_gallery id="'.$atts["id"]."]");
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
+			echo do_shortcode( '[aesop_gallery id="'.$atts["id"]."]");
 		}
 		
 		exit; 

Please login to merge, or discard this patch.

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

@@ -52,12 +52,12 @@  discard block
 block discarded – undo
 		require_once LASSO_DIR.'/public/includes/wrap-shortcodes.php';
 
 		// Activate plugin when new blog is added
-		add_action( 'wpmu_new_blog', array( $this, 'activate_new_site' ) );
+		add_action('wpmu_new_blog', array($this, 'activate_new_site'));
 
 		// Load plugin text domain
-		add_action( 'init', array( $this, 'load_plugin_textdomain' ) );
+		add_action('init', array($this, 'load_plugin_textdomain'));
 		
-		add_action( 'wp_ajax_get_aesop_component',     array( $this, 'get_aesop_component' ) );
+		add_action('wp_ajax_get_aesop_component', array($this, 'get_aesop_component'));
 
 		//enqueue assets
 		new assets();
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
 	public static function get_instance() {
 
 		// If the single instance hasn't been set, set it now.
-		if ( null == self::$instance ) {
+		if (null == self::$instance) {
 			self::$instance = new self;
 		}
 
@@ -102,18 +102,18 @@  discard block
 block discarded – undo
 	 *                                       WPMU is disabled or plugin is
 	 *                                       activated on an individual blog.
 	 */
-	public static function activate( $network_wide ) {
+	public static function activate($network_wide) {
 
-		if ( function_exists( 'is_multisite' ) && is_multisite() ) {
+		if (function_exists('is_multisite') && is_multisite()) {
 
-			if ( $network_wide  ) {
+			if ($network_wide) {
 
 				// Get all blog ids
 				$blog_ids = self::get_blog_ids();
 
-				foreach ( $blog_ids as $blog_id ) {
+				foreach ($blog_ids as $blog_id) {
 
-					switch_to_blog( $blog_id );
+					switch_to_blog($blog_id);
 					self::single_activate();
 				}
 
@@ -139,18 +139,18 @@  discard block
 block discarded – undo
 	 *                                       WPMU is disabled or plugin is
 	 *                                       deactivated on an individual blog.
 	 */
-	public static function deactivate( $network_wide ) {
+	public static function deactivate($network_wide) {
 
-		if ( function_exists( 'is_multisite' ) && is_multisite() ) {
+		if (function_exists('is_multisite') && is_multisite()) {
 
-			if ( $network_wide ) {
+			if ($network_wide) {
 
 				// Get all blog ids
 				$blog_ids = self::get_blog_ids();
 
-				foreach ( $blog_ids as $blog_id ) {
+				foreach ($blog_ids as $blog_id) {
 
-					switch_to_blog( $blog_id );
+					switch_to_blog($blog_id);
 					self::single_deactivate();
 
 				}
@@ -174,13 +174,13 @@  discard block
 block discarded – undo
 	 *
 	 * @param int     $blog_id ID of the new blog.
 	 */
-	public function activate_new_site( $blog_id ) {
+	public function activate_new_site($blog_id) {
 
-		if ( 1 !== did_action( 'wpmu_new_blog' ) ) {
+		if (1 !== did_action('wpmu_new_blog')) {
 			return;
 		}
 
-		switch_to_blog( $blog_id );
+		switch_to_blog($blog_id);
 		self::single_activate();
 		restore_current_blog();
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
 			WHERE archived = '0' AND spam = '0'
 			AND deleted = '0'";
 
-		return $wpdb->get_col( $sql );
+		return $wpdb->get_col($sql);
 
 	}
 
@@ -216,18 +216,18 @@  discard block
 block discarded – undo
 	 */
 	private static function single_activate() {
 
-		$curr_version = get_option( 'lasso_version' );
+		$curr_version = get_option('lasso_version');
 
 		// update upgraded from
-		if ( $curr_version ) {
-			update_option( 'lasso_updated_from', $curr_version );
+		if ($curr_version) {
+			update_option('lasso_updated_from', $curr_version);
 		}
 
 		// update lasso version option
-		update_option( 'lasso_version', LASSO_VERSION );
+		update_option('lasso_version', LASSO_VERSION);
 
 		// set transietn for activation welcome
-		set_transient( '_lasso_welcome_redirect', true, 30 );
+		set_transient('_lasso_welcome_redirect', true, 30);
 
 
 	}
@@ -249,9 +249,9 @@  discard block
 block discarded – undo
 	public function load_plugin_textdomain() {
 
 		$domain = $this->plugin_slug;
-		$locale = apply_filters( 'plugin_locale', get_locale(), $domain );
+		$locale = apply_filters('plugin_locale', get_locale(), $domain);
 
-		$out = load_textdomain( $domain, trailingslashit( LASSO_DIR ). 'languages/' . $domain . '-' . $locale . '.mo' );
+		$out = load_textdomain($domain, trailingslashit(LASSO_DIR).'languages/'.$domain.'-'.$locale.'.mo');
 	}
 	
 	
@@ -259,11 +259,11 @@  discard block
 block discarded – undo
 	{
 		
 		
-		$code= $_POST["code"];
+		$code = $_POST["code"];
 		$atts = array(
 		 );
 		foreach ($_POST as $key => $value) {
-			if ($key !="code" && $key !="action") {
+			if ($key != "code" && $key != "action") {
 			    //$shortcode = $shortcode.$key.'="'.$value.'" ';
 				$atts[$key] = $value;
 			}
@@ -274,32 +274,32 @@  discard block
 block discarded – undo
 		}*/
 		
 		if ($code == "aesop_image") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
+		    require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
 		    echo aesop_image_shortcode($atts);
 		}
 		if ($code == "aesop_quote") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
+		    require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
 		    echo aesop_quote_shortcode($atts);
 		}
 		
 		if ($code == "aesop_parallax") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
+		    require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
 		    echo aesop_parallax_shortcode($atts);
 		}
 		
 		if ($code == "aesop_character") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
+		    require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
 		    echo aesop_character_shortcode($atts);
 		}
 		
 		if ($code == "aesop_chapter") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
+		    require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
 		    echo aesop_chapter_shortcode($atts);
 		}
 		
 		if ($code == "aesop_gallery") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
-		    echo do_shortcode( '[aesop_gallery id="'.$atts["id"]."]");
+		    require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
+		    echo do_shortcode('[aesop_gallery id="'.$atts["id"]."]");
 		}
 		
 		exit; 

Please login to merge, or discard this patch.

		@@ -264,7 +264,7 @@ discard block
		block discarded – undo
264	264	);
265	265	foreach ($_POST as $key => $value) {
266	266	if ($key !="code" && $key !="action") {
267		- //$shortcode = $shortcode.$key.'="'.$value.'" ';
	267	+ //$shortcode = $shortcode.$key.'="'.$value.'" ';
268	268	$atts[$key] = $value;
269	269	}
270	270	}
		@@ -274,32 +274,32 @@ discard block
		block discarded – undo
274	274	}*/
275	275
276	276	if ($code == "aesop_image") {
277		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
278		- echo aesop_image_shortcode($atts);
	277	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
	278	+ echo aesop_image_shortcode($atts);
279	279	}
280	280	if ($code == "aesop_quote") {
281		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
282		- echo aesop_quote_shortcode($atts);
	281	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
	282	+ echo aesop_quote_shortcode($atts);
283	283	}
284	284
285	285	if ($code == "aesop_parallax") {
286		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
287		- echo aesop_parallax_shortcode($atts);
	286	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
	287	+ echo aesop_parallax_shortcode($atts);
288	288	}
289	289
290	290	if ($code == "aesop_character") {
291		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
292		- echo aesop_character_shortcode($atts);
	291	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
	292	+ echo aesop_character_shortcode($atts);
293	293	}
294	294
295	295	if ($code == "aesop_chapter") {
296		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
297		- echo aesop_chapter_shortcode($atts);
	296	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
	297	+ echo aesop_chapter_shortcode($atts);
298	298	}
299	299
300	300	if ($code == "aesop_gallery") {
301		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
302		- echo do_shortcode( '[aesop_gallery id="'.$atts["id"]."]");
	301	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
	302	+ echo do_shortcode( '[aesop_gallery id="'.$atts["id"]."]");
303	303	}
304	304
305	305	exit;

		@@ -52,12 +52,12 @@ discard block
		block discarded – undo
52	52	require_once LASSO_DIR.'/public/includes/wrap-shortcodes.php';
53	53
54	54	// Activate plugin when new blog is added
55		- add_action( 'wpmu_new_blog', array( $this, 'activate_new_site' ) );
	55	+ add_action('wpmu_new_blog', array($this, 'activate_new_site'));
56	56
57	57	// Load plugin text domain
58		- add_action( 'init', array( $this, 'load_plugin_textdomain' ) );
	58	+ add_action('init', array($this, 'load_plugin_textdomain'));
59	59
60		- add_action( 'wp_ajax_get_aesop_component', array( $this, 'get_aesop_component' ) );
	60	+ add_action('wp_ajax_get_aesop_component', array($this, 'get_aesop_component'));
61	61
62	62	//enqueue assets
63	63	new assets();
		@@ -85,7 +85,7 @@ discard block
		block discarded – undo
85	85	public static function get_instance() {
86	86
87	87	// If the single instance hasn't been set, set it now.
88		- if ( null == self::$instance ) {
	88	+ if (null == self::$instance) {
89	89	self::$instance = new self;
90	90	}
91	91
		@@ -102,18 +102,18 @@ discard block
		block discarded – undo
102	102	* WPMU is disabled or plugin is
103	103	* activated on an individual blog.
104	104	*/
105		- public static function activate( $network_wide ) {
	105	+ public static function activate($network_wide) {
106	106
107		- if ( function_exists( 'is_multisite' ) && is_multisite() ) {
	107	+ if (function_exists('is_multisite') && is_multisite()) {
108	108
109		- if ( $network_wide ) {
	109	+ if ($network_wide) {
110	110
111	111	// Get all blog ids
112	112	$blog_ids = self::get_blog_ids();
113	113
114		- foreach ( $blog_ids as $blog_id ) {
	114	+ foreach ($blog_ids as $blog_id) {
115	115
116		- switch_to_blog( $blog_id );
	116	+ switch_to_blog($blog_id);
117	117	self::single_activate();
118	118	}
119	119
		@@ -139,18 +139,18 @@ discard block
		block discarded – undo
139	139	* WPMU is disabled or plugin is
140	140	* deactivated on an individual blog.
141	141	*/
142		- public static function deactivate( $network_wide ) {
	142	+ public static function deactivate($network_wide) {
143	143
144		- if ( function_exists( 'is_multisite' ) && is_multisite() ) {
	144	+ if (function_exists('is_multisite') && is_multisite()) {
145	145
146		- if ( $network_wide ) {
	146	+ if ($network_wide) {
147	147
148	148	// Get all blog ids
149	149	$blog_ids = self::get_blog_ids();
150	150
151		- foreach ( $blog_ids as $blog_id ) {
	151	+ foreach ($blog_ids as $blog_id) {
152	152
153		- switch_to_blog( $blog_id );
	153	+ switch_to_blog($blog_id);
154	154	self::single_deactivate();
155	155
156	156	}
		@@ -174,13 +174,13 @@ discard block
		block discarded – undo
174	174	*
175	175	* @param int $blog_id ID of the new blog.
176	176	*/
177		- public function activate_new_site( $blog_id ) {
	177	+ public function activate_new_site($blog_id) {
178	178
179		- if ( 1 !== did_action( 'wpmu_new_blog' ) ) {
	179	+ if (1 !== did_action('wpmu_new_blog')) {
180	180	return;
181	181	}
182	182
183		- switch_to_blog( $blog_id );
	183	+ switch_to_blog($blog_id);
184	184	self::single_activate();
185	185	restore_current_blog();
186	186
		@@ -205,7 +205,7 @@ discard block
		block discarded – undo
205	205	WHERE archived = '0' AND spam = '0'
206	206	AND deleted = '0'";
207	207
208		- return $wpdb->get_col( $sql );
	208	+ return $wpdb->get_col($sql);
209	209
210	210	}
211	211
		@@ -216,18 +216,18 @@ discard block
		block discarded – undo
216	216	*/
217	217	private static function single_activate() {
218	218
219		- $curr_version = get_option( 'lasso_version' );
	219	+ $curr_version = get_option('lasso_version');
220	220
221	221	// update upgraded from
222		- if ( $curr_version ) {
223		- update_option( 'lasso_updated_from', $curr_version );
	222	+ if ($curr_version) {
	223	+ update_option('lasso_updated_from', $curr_version);
224	224	}
225	225
226	226	// update lasso version option
227		- update_option( 'lasso_version', LASSO_VERSION );
	227	+ update_option('lasso_version', LASSO_VERSION);
228	228
229	229	// set transietn for activation welcome
230		- set_transient( '_lasso_welcome_redirect', true, 30 );
	230	+ set_transient('_lasso_welcome_redirect', true, 30);
231	231
232	232
233	233	}
		@@ -249,9 +249,9 @@ discard block
		block discarded – undo
249	249	public function load_plugin_textdomain() {
250	250
251	251	$domain = $this->plugin_slug;
252		- $locale = apply_filters( 'plugin_locale', get_locale(), $domain );
	252	+ $locale = apply_filters('plugin_locale', get_locale(), $domain);
253	253
254		- $out = load_textdomain( $domain, trailingslashit( LASSO_DIR ). 'languages/' . $domain . '-' . $locale . '.mo' );
	254	+ $out = load_textdomain($domain, trailingslashit(LASSO_DIR).'languages/'.$domain.'-'.$locale.'.mo');
255	255	}
256	256
257	257
		@@ -259,11 +259,11 @@ discard block
		block discarded – undo
259	259	{
260	260
261	261
262		- $code= $_POST["code"];
	262	+ $code = $_POST["code"];
263	263	$atts = array(
264	264	);
265	265	foreach ($_POST as $key => $value) {
266		- if ($key !="code" && $key !="action") {
	266	+ if ($key != "code" && $key != "action") {
267	267	//$shortcode = $shortcode.$key.'="'.$value.'" ';
268	268	$atts[$key] = $value;
269	269	}
		@@ -274,32 +274,32 @@ discard block
		block discarded – undo
274	274	}*/
275	275
276	276	if ($code == "aesop_image") {
277		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
	277	+ require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
278	278	echo aesop_image_shortcode($atts);
279	279	}
280	280	if ($code == "aesop_quote") {
281		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
	281	+ require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
282	282	echo aesop_quote_shortcode($atts);
283	283	}
284	284
285	285	if ($code == "aesop_parallax") {
286		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
	286	+ require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
287	287	echo aesop_parallax_shortcode($atts);
288	288	}
289	289
290	290	if ($code == "aesop_character") {
291		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
	291	+ require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
292	292	echo aesop_character_shortcode($atts);
293	293	}
294	294
295	295	if ($code == "aesop_chapter") {
296		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
	296	+ require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
297	297	echo aesop_chapter_shortcode($atts);
298	298	}
299	299
300	300	if ($code == "aesop_gallery") {
301		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
302		- echo do_shortcode( '[aesop_gallery id="'.$atts["id"]."]");
	301	+ require_once(ABSPATH.'/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
	302	+ echo do_shortcode('[aesop_gallery id="'.$atts["id"]."]");
303	303	}
304	304
305	305	exit;

AesopInteractive / lasso

Push — master ( 498f6d...4e9082 )

Status

Category

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch