Completed
Pull Request — typo3v9 (#432)
by Benni
15:30
created
Classes/Hooks/StaticFileCacheCreateUriHook.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      * @param string $uri
54 54
      * @param TypoScriptFrontendController $frontend
55 55
      *
56
-     * @return array
56
+     * @return string[]
57 57
      *
58 58
      * @throws \Exception
59 59
      *
Please login to merge, or discard this patch.
Classes/Domain/Repository/QueueRepository.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param $processId
63
+     * @param string $processId
64 64
      */
65 65
     public function unsetQueueProcessId($processId)
66 66
     {
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
     /**
439 439
      * Determines if a page is queued
440 440
      *
441
-     * @param $uid
441
+     * @param integer $uid
442 442
      * @param bool $unprocessed_only
443 443
      * @param bool $timed_only
444 444
      * @param bool $timestamp
Please login to merge, or discard this patch.
Classes/Command/CrawlerCommandController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -250,7 +250,7 @@
 block discarded – undo
250 250
     /**
251 251
      * Obtains configuration keys from the CLI arguments
252 252
      *
253
-     * @param $conf string
253
+     * @param string $conf string
254 254
      * @return array
255 255
      */
256 256
     private function getConfigurationKeys($conf)
Please login to merge, or discard this patch.
Classes/Api/CrawlerApi.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@
 block discarded – undo
297 297
      * scheduled but have note been crawled yet.
298 298
      *
299 299
      * @param int $uid uid of the page
300
-     * @param bool $limit
300
+     * @param integer $limit
301 301
      *
302 302
      * @return array array with the crawl-history of a page => 0 : scheduled time , 1 : executed_time, 2 : set_id
303 303
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use TYPO3\CMS\Core\Database\ConnectionPool;
32 32
 use TYPO3\CMS\Core\Database\Query\QueryBuilder;
33 33
 use TYPO3\CMS\Core\Utility\GeneralUtility;
34
-use TYPO3\CMS\Core\Utility\MathUtility;
35 34
 use TYPO3\CMS\Extbase\Object\ObjectManager;
36 35
 use TYPO3\CMS\Frontend\Page\PageRepository;
37 36
 
Please login to merge, or discard this patch.
Classes/Controller/CrawlerController.php 1 patch
Doc Comments   +11 added lines, -5 removed lines patch added patch discarded remove patch
@@ -419,6 +419,10 @@  discard block
 block discarded – undo
419 419
      * @param    array        Array which is passed by reference and contains the an id per url to secure we will not crawl duplicates
420 420
      * @param    array        Array which will be filled with URLS for download if flag is set.
421 421
      * @param    array        Array of processing instructions
422
+     * @param integer $scheduledTime
423
+     * @param integer $reqMinute
424
+     * @param boolean $submitCrawlUrls
425
+     * @param boolean $downloadCrawlUrls
422 426
      * @return    string        List of URLs (meant for display in backend module)
423 427
      *
424 428
      */
@@ -719,7 +723,7 @@  discard block
 block discarded – undo
719 723
     }
720 724
 
721 725
     /**
722
-     * @param $rootid
726
+     * @param integer $rootid
723 727
      * @param $depth
724 728
      * @return array
725 729
      *
@@ -980,7 +984,7 @@  discard block
 block discarded – undo
980 984
      * The number of URLs will be the multiplication of the number of parameter values for each key
981 985
      *
982 986
      * @param array $paramArray Output of expandParameters(): Array with keys (GET var names) and for each an array of values
983
-     * @param array $urls URLs accumulated in this array (for recursion)
987
+     * @param string[] $urls URLs accumulated in this array (for recursion)
984 988
      * @return array
985 989
      */
986 990
     public function compileUrls($paramArray, $urls = [])
@@ -1740,7 +1744,7 @@  discard block
 block discarded – undo
1740 1744
      * @param array $url
1741 1745
      * @param string $crawlerId
1742 1746
      *
1743
-     * @return array
1747
+     * @return string[]
1744 1748
      */
1745 1749
     protected function buildRequestHeaderArray(array $url, $crawlerId)
1746 1750
     {
@@ -2013,6 +2017,7 @@  discard block
 block discarded – undo
2013 2017
      *
2014 2018
      * @param    array        Page row
2015 2019
      * @param    string        Page icon and title for row
2020
+     * @param string $pageTitleAndIcon
2016 2021
      * @return    string        HTML <tr> content (one or more)
2017 2022
      */
2018 2023
     public function drawURLs_addRowsForPage(array $pageRow, $pageTitleAndIcon)
@@ -2137,7 +2142,7 @@  discard block
 block discarded – undo
2137 2142
      * @param int $countInARun
2138 2143
      * @param int $sleepTime
2139 2144
      * @param int $sleepAfterFinish
2140
-     * @return string
2145
+     * @return integer
2141 2146
      */
2142 2147
     public function CLI_run($countInARun, $sleepTime, $sleepAfterFinish)
2143 2148
     {
@@ -2436,6 +2441,7 @@  discard block
 block discarded – undo
2436 2441
      * Used to determine timeouts and to ensure a proper cleanup if there's a timeout
2437 2442
      *
2438 2443
      * @param  string  identification string for the process
2444
+     * @param string $pid
2439 2445
      * @return boolean determines if the process is still active / has resources
2440 2446
      *
2441 2447
      * TODO: Please consider moving this to Domain Model for Process or in ProcessRepository
@@ -2595,7 +2601,7 @@  discard block
 block discarded – undo
2595 2601
      * Check whether the Crawling Protocol should be http or https
2596 2602
      *
2597 2603
      * @param $crawlerConfiguration
2598
-     * @param $pageConfiguration
2604
+     * @param boolean $pageConfiguration
2599 2605
      *
2600 2606
      * @return bool
2601 2607
      */
Please login to merge, or discard this patch.