AOEpeople / crawler

domain/process/class.tx_crawler_domain_process_repository.php

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
             $this->tableName,
             $where,
             '',
-            htmlspecialchars($orderField) . ' ' . htmlspecialchars($orderDirection),
+            htmlspecialchars($orderField).' '.htmlspecialchars($orderDirection),
             self::getLimitFromItemCountAndOffset($itemCount, $offset)
         );
 
@@ -111,7 +111,7 @@ 
      */
     public function countNotTimeouted($ttl)
     {
-        return $this->countByWhere('deleted = 0 AND ttl > ' . intval($ttl));
+        return $this->countByWhere('deleted = 0 AND ttl > '.intval($ttl));
     }
 
     /**
@@ -127,7 +127,7 @@ 
     {
         $itemCount = filter_var($itemCount, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'default' => 20]]);
         $offset = filter_var($offset, FILTER_VALIDATE_INT, ['options' => ['min_range' => 0, 'default' => 0]]);
-        $limit = $offset . ', ' . $itemCount;
+        $limit = $offset.', '.$itemCount;
 
         return $limit;
     }

domain/reason/class.tx_crawler_domain_reason.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      * This method is used to set the uid of the queue entry
      * where the reason is relevant for.
      *
-     * @param int $entry_id
+     * @param int $entry_uid
      */
     public function setQueueEntryUid($entry_uid)
     {

template/process/list.php

Braces +5 added lines, -2 removed lines

@@ -71,8 +71,11 @@
 					</div>
 				<?php elseif ($process->getState() == 'cancelled'): ?>
 					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.cancelled'); ?>
-				<?php else: ?>
-					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success'); ?>
+				<?php else {
+    : ?>
+					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success');
+}
+?>
 				<?php endif; ?>
 				</td>
 			</tr>

Spacing +3 added lines, -3 removed lines

@@ -53,16 +53,16 @@
 	</thead>
 	<tbody>
 		<?php foreach ($this->getProcessCollection() as $process): /* @var $process tx_crawler_domain_process */ ?>
-			<tr class="<?php echo (++$count % 2 == 0) ? 'odd': 'even' ?>">
+			<tr class="<?php echo (++$count % 2 == 0) ? 'odd' : 'even' ?>">
 				<td><?php echo $this->getIconForState(htmlspecialchars($process->getState())); ?></td>
 				<td><?php echo htmlspecialchars($process->getProcess_id()); ?></td>
 				<td><?php echo htmlspecialchars($this->asDate($process->getTimeForFirstItem())); ?></td>
 				<td><?php echo htmlspecialchars($this->asDate($process->getTimeForLastItem())); ?></td>
-				<td><?php echo htmlspecialchars(floor($process->getRuntime()/ 60)); ?> min. <?php echo htmlspecialchars($process->getRuntime()) % 60 ?> sec.</td>
+				<td><?php echo htmlspecialchars(floor($process->getRuntime() / 60)); ?> min. <?php echo htmlspecialchars($process->getRuntime()) % 60 ?> sec.</td>
 				<td><?php echo htmlspecialchars($this->asDate($process->getTTL())); ?></td>
 				<td><?php echo htmlspecialchars($process->countItemsProcessed()); ?></td>
 				<td><?php echo htmlspecialchars($process->countItemsAssigned()); ?></td>
-				<td><?php echo htmlspecialchars($process->countItemsToProcess()+$process->countItemsProcessed()); ?></td>
+				<td><?php echo htmlspecialchars($process->countItemsToProcess() + $process->countItemsProcessed()); ?></td>
 				<td>
 				<?php if ($process->getState() == 'running'): ?>
 					<div class="crawlerprocessprogress" style="width: 200px;">

domain/queue/class.tx_crawler_domain_queue_repository.php

Indentation +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     {
         $db = $this->getDB();
         $where = 'process_id_completed='.$db->fullQuoteStr($process->getProcess_id(), $this->tableName).
-                 ' AND exec_time > 0 ';
+                    ' AND exec_time > 0 ';
         $limit = 1;
         $groupby = '';
 

Spacing +6 added lines, -6 removed lines

@@ -67,9 +67,9 @@ 
         $limit = 1;
         $groupby = '';
 
-        $res 	= $db->exec_SELECTgetRows('*', 'tx_crawler_queue', $where, $groupby, $orderby, $limit);
+        $res = $db->exec_SELECTgetRows('*', 'tx_crawler_queue', $where, $groupby, $orderby, $limit);
         if ($res) {
-            $first 	= $res[0];
+            $first = $res[0];
         } else {
             $first = [];
         }
@@ -143,7 +143,7 @@ 
     {
         $db 	= $this->getDB();
         $rs 	= $db->exec_SELECTquery('count(*) as anz', $this->tableName, $where);
-        $res 	= $db->sql_fetch_assoc($rs);
+        $res = $db->sql_fetch_assoc($rs);
 
         return $res['anz'];
     }
@@ -212,7 +212,7 @@ 
             $res = $db->exec_SELECTquery(
                 'configuration, count(*) as c',
                 $this->tableName,
-                'set_id in ('. implode(',', $setIds).') AND scheduled < '.time(),
+                'set_id in ('.implode(',', $setIds).') AND scheduled < '.time(),
                 'configuration'
             );
             while ($row = $db->sql_fetch_assoc($res)) {
@@ -258,7 +258,7 @@ 
      * @author Fabrizio Branca <fabrizio.branca@aoemedia.de>
      * @since 2010-11-16
      */
-    public function getLastProcessedEntries($selectFields='*', $limit='100')
+    public function getLastProcessedEntries($selectFields = '*', $limit = '100')
     {
         $db = $this->getDB();
         $res = $db->exec_SELECTquery(
@@ -292,7 +292,7 @@ 
         $res = $db->exec_SELECTquery(
             'process_id_completed, min(exec_time) as start, max(exec_time) as end, count(*) as urlcount',
             $this->tableName,
-            'exec_time != 0 and exec_time >= '.intval($start). ' and exec_time <= ' . intval($end),
+            'exec_time != 0 and exec_time >= '.intval($start).' and exec_time <= '.intval($end),
             'process_id_completed'
         );
 

modfunc1/class.tx_crawler_modfunc1.php

Doc Comments +3 added lines

@@ -717,6 +717,7 @@ 
      * @param	array		Page row or set-id
      * @param	string		Title string
      * @param	int			Items per Page setting
+     * @param string $titleString
      * @return	string		HTML <tr> content (one or more)
      */
     public function drawLog_addRows($pageRow_setId, $titleString, $itemsPerPage=10)
@@ -1239,6 +1240,8 @@ 
      * @param	string		Selector box name
      * @param	string		Selector box value (array for multiple...)
      * @param	boolean		If set, will draw multiple box.
+     * @param string $name
+     * @param integer $multiple
      * @return	string		HTML select element
      */
     public function selectorBox($optArray, $name, $value, $multiple)

Spacing +48 added lines, -48 removed lines

@@ -200,7 +200,7 @@ 
         */
 
         // Additional menus for the log type:
-        if ($this->pObj->MOD_SETTINGS['crawlaction']==='log') {
+        if ($this->pObj->MOD_SETTINGS['crawlaction'] === 'log') {
             $h_func .= \TYPO3\CMS\Backend\Utility\BackendUtility::getFuncMenu(
                 $this->pObj->id,
                 'SET[depth]',
@@ -209,15 +209,15 @@ 
                 'index.php'
             );
 
-            $quiPart = \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('qid_details') ? '&qid_details=' . intval(\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('qid_details')) : '';
+            $quiPart = \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('qid_details') ? '&qid_details='.intval(\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('qid_details')) : '';
 
             $setId = intval(\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('setID'));
 
-            $h_func.= '<hr/>'.
-                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.display').': '.\TYPO3\CMS\Backend\Utility\BackendUtility::getFuncMenu($this->pObj->id, 'SET[log_display]', $this->pObj->MOD_SETTINGS['log_display'], $this->pObj->MOD_MENU['log_display'], 'index.php', '&setID='.$setId) . ' - ' .
-                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.showresultlog').': '.\TYPO3\CMS\Backend\Utility\BackendUtility::getFuncCheck($this->pObj->id, 'SET[log_resultLog]', $this->pObj->MOD_SETTINGS['log_resultLog'], 'index.php', '&setID='.$setId . $quiPart) . ' - ' .
-                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.showfevars').': '.\TYPO3\CMS\Backend\Utility\BackendUtility::getFuncCheck($this->pObj->id, 'SET[log_feVars]', $this->pObj->MOD_SETTINGS['log_feVars'], 'index.php', '&setID='.$setId . $quiPart) . ' - ' .
-                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.itemsPerPage').': ' .
+            $h_func .= '<hr/>'.
+                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.display').': '.\TYPO3\CMS\Backend\Utility\BackendUtility::getFuncMenu($this->pObj->id, 'SET[log_display]', $this->pObj->MOD_SETTINGS['log_display'], $this->pObj->MOD_MENU['log_display'], 'index.php', '&setID='.$setId).' - '.
+                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.showresultlog').': '.\TYPO3\CMS\Backend\Utility\BackendUtility::getFuncCheck($this->pObj->id, 'SET[log_resultLog]', $this->pObj->MOD_SETTINGS['log_resultLog'], 'index.php', '&setID='.$setId.$quiPart).' - '.
+                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.showfevars').': '.\TYPO3\CMS\Backend\Utility\BackendUtility::getFuncCheck($this->pObj->id, 'SET[log_feVars]', $this->pObj->MOD_SETTINGS['log_feVars'], 'index.php', '&setID='.$setId.$quiPart).' - '.
+                    $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.itemsPerPage').': '.
                     \TYPO3\CMS\Backend\Utility\BackendUtility::getFuncMenu(
                         $this->pObj->id,
                         'SET[itemsPerPage]',
@@ -227,11 +227,11 @@ 
                     );
         }
 
-        $theOutput= $this->pObj->doc->spacer(5);
-        $theOutput.= $this->pObj->doc->section($LANG->getLL('title'), $h_func, 0, 1);
+        $theOutput = $this->pObj->doc->spacer(5);
+        $theOutput .= $this->pObj->doc->section($LANG->getLL('title'), $h_func, 0, 1);
 
         // Branch based on type:
-        switch ((string)$this->pObj->MOD_SETTINGS['crawlaction']) {
+        switch ((string) $this->pObj->MOD_SETTINGS['crawlaction']) {
             case 'start':
                 if (empty($this->pObj->id)) {
                     $this->addErrorMessage($GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.noPageSelected'));
@@ -289,12 +289,12 @@ 
         $this->downloadCrawlUrls = \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('_download');
         $this->makeCrawlerProcessableChecks();
 
-        switch ((string)\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('tstamp')) {
+        switch ((string) \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('tstamp')) {
             case 'midnight':
                 $this->scheduledTime = mktime(0, 0, 0);
             break;
             case '04:00':
-                $this->scheduledTime = mktime(0, 0, 0)+4*3600;
+                $this->scheduledTime = mktime(0, 0, 0) + 4 * 3600;
             break;
             case 'now':
             default:
@@ -314,9 +314,9 @@ 
         $this->crawlerObj->setID = \TYPO3\CMS\Core\Utility\GeneralUtility::md5int(microtime());
 
         if (empty($this->incomingConfigurationSelection)
-            || (count($this->incomingConfigurationSelection)==1 && empty($this->incomingConfigurationSelection[0]))
+            || (count($this->incomingConfigurationSelection) == 1 && empty($this->incomingConfigurationSelection[0]))
             ) {
-            $code= '
+            $code = '
 			<tr>
 				<td colspan="7"><b>'.$GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.noConfigSelected').'</b></td>
 			</tr>';
@@ -333,7 +333,7 @@ 
                 tx_crawler_domain_events_dispatcher::getInstance()->post(
                     'invokeQueueChange',
                                                                             $this->findCrawler()->setID,
-                                                                            [	'reason' => $reason ]
+                                                                            ['reason' => $reason]
                 );
             }
 
@@ -417,11 +417,11 @@ 
             $this->pObj->MOD_SETTINGS['depth'],
             0
         );
-        $availableConfigurations = $this->crawlerObj->getConfigurationsForBranch($this->pObj->id, $this->pObj->MOD_SETTINGS['depth']?$this->pObj->MOD_SETTINGS['depth']:0);
+        $availableConfigurations = $this->crawlerObj->getConfigurationsForBranch($this->pObj->id, $this->pObj->MOD_SETTINGS['depth'] ? $this->pObj->MOD_SETTINGS['depth'] : 0);
 
         // Configurations
         $cell[] = $this->selectorBox(
-            empty($availableConfigurations)?[]:array_combine($availableConfigurations, $availableConfigurations),
+            empty($availableConfigurations) ? [] : array_combine($availableConfigurations, $availableConfigurations),
             'configurationSelection',
             $this->incomingConfigurationSelection,
             1
@@ -561,12 +561,12 @@ 
             // Print rudimentary details:
             $output .= '
 				<br /><br />
-				<input type="submit" value="' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.back') . '" name="_back" />
-				<input type="hidden" value="' . $this->pObj->id . '" name="id" />
-				<input type="hidden" value="' . $showSetId . '" name="setID" />
+				<input type="submit" value="' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.back').'" name="_back" />
+				<input type="hidden" value="' . $this->pObj->id.'" name="id" />
+				<input type="hidden" value="' . $showSetId.'" name="setID" />
 				<br />
-				Current server time: ' . date('H:i:s', time()) . '<br />' .
-                'Status: ' . $resStatus . '<br />' .
+				Current server time: ' . date('H:i:s', time()).'<br />'.
+                'Status: '.$resStatus.'<br />'.
                 \TYPO3\CMS\Core\Utility\DebugUtility::viewArray($q_entry);
         } else {	// Show list:
 
@@ -596,7 +596,7 @@ 
                     foreach ($tree->tree as $data) {
                         $code .= $this->drawLog_addRows(
                                     $data['row'],
-                                    $data['HTML'] . \TYPO3\CMS\Backend\Utility\BackendUtility::getRecordTitle('pages', $data['row'], true),
+                                    $data['HTML'].\TYPO3\CMS\Backend\Utility\BackendUtility::getRecordTitle('pages', $data['row'], true),
                                     intval($this->pObj->MOD_SETTINGS['itemsPerPage'])
                                 );
                         if (++$count == 1000) {
@@ -605,7 +605,7 @@ 
                     }
                 } else {
                     $code = '';
-                    $code.= $this->drawLog_addRows(
+                    $code .= $this->drawLog_addRows(
                                 $showSetId,
                                 'Set ID: '.$showSetId
                             );
@@ -647,10 +647,10 @@ 
 					</tr>
 				';
 
-                $cc=0;
+                $cc = 0;
                 foreach ($setList as $set) {
-                    $code.= '
-						<tr class="bgColor'.($cc%2 ? '-20':'-10').'">
+                    $code .= '
+						<tr class="bgColor'.($cc % 2 ? '-20' : '-10').'">
 							<td><a href="'.htmlspecialchars('index.php?setID='.$set['set_id']).'">'.$set['set_id'].'</a></td>
 							<td>'.$set['count_value'].'</td>
 							<td>'.\TYPO3\CMS\Backend\Utility\BackendUtility::dateTimeAge($set['scheduled']).'</td>
@@ -719,7 +719,7 @@ 
      * @param	int			Items per Page setting
      * @return	string		HTML <tr> content (one or more)
      */
-    public function drawLog_addRows($pageRow_setId, $titleString, $itemsPerPage=10)
+    public function drawLog_addRows($pageRow_setId, $titleString, $itemsPerPage = 10)
     {
 
             // If Flush button is pressed, flush tables instead of selecting entries:
@@ -750,7 +750,7 @@ 
         if (count($res)) {
             // Traverse parameter combinations:
             $c = 0;
-            $content='';
+            $content = '';
             foreach ($res as $kk => $vv) {
 
                     // Title column:
@@ -774,7 +774,7 @@ 
                 if ($this->pObj->MOD_SETTINGS['log_resultLog']) {
                     $rowData['result_log'] = $resLog;
                 } else {
-                    $rowData['scheduled'] = ($vv['scheduled']> 0) ? \TYPO3\CMS\Backend\Utility\BackendUtility::datetime($vv['scheduled']) : ' '.$GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.immediate');
+                    $rowData['scheduled'] = ($vv['scheduled'] > 0) ? \TYPO3\CMS\Backend\Utility\BackendUtility::datetime($vv['scheduled']) : ' '.$GLOBALS['LANG']->sL('LLL:EXT:crawler/modfunc1/locallang.xml:labels.immediate');
                     $rowData['exec_time'] = $vv['exec_time'] ? \TYPO3\CMS\Backend\Utility\BackendUtility::datetime($vv['exec_time']) : '-';
                 }
                 $rowData['result_status'] = \TYPO3\CMS\Core\Utility\GeneralUtility::fixed_lgd_cs($resStatus, 50);
@@ -791,27 +791,27 @@ 
 
                 $setId = intval(\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('setID'));
 
-                $refreshIcon = $GLOBALS['BACK_PATH'] . 'gfx/refresh_n.gif';
+                $refreshIcon = $GLOBALS['BACK_PATH'].'gfx/refresh_n.gif';
                 if (version_compare(TYPO3_version, '7.0', '>=')) {
-                    $refreshIcon = $GLOBALS['BACK_PATH'] . 'sysext/t3skin/extjs/images/grid/refresh.gif';
+                    $refreshIcon = $GLOBALS['BACK_PATH'].'sysext/t3skin/extjs/images/grid/refresh.gif';
                 }
 
                 // Put rows together:
-                $content.= '
-					<tr class="bgColor'.($c%2 ? '-20':'-10').'">
+                $content .= '
+					<tr class="bgColor'.($c % 2 ? '-20' : '-10').'">
 						'.$titleClm.'
-						<td><a href="' . $this->getModuleUrl(['qid_details' => $vv['qid'], 'setID' => $setId]) . '">'.htmlspecialchars($vv['qid']).'</a></td>
-						<td><a href="' . $this->getModuleUrl(['qid_read' => $vv['qid'], 'setID' => $setId]) . '"><img src="' . $refreshIcon . '" width="14" hspace="1" vspace="2" height="14" border="0" title="'.htmlspecialchars('Read').'" alt="" /></a></td>';
+						<td><a href="' . $this->getModuleUrl(['qid_details' => $vv['qid'], 'setID' => $setId]).'">'.htmlspecialchars($vv['qid']).'</a></td>
+						<td><a href="' . $this->getModuleUrl(['qid_read' => $vv['qid'], 'setID' => $setId]).'"><img src="'.$refreshIcon.'" width="14" hspace="1" vspace="2" height="14" border="0" title="'.htmlspecialchars('Read').'" alt="" /></a></td>';
                 foreach ($rowData as $fKey => $value) {
                     if (\TYPO3\CMS\Core\Utility\GeneralUtility::inList('url', $fKey)) {
-                        $content.= '
+                        $content .= '
 						<td>'.$value.'</td>';
                     } else {
-                        $content.= '
+                        $content .= '
 						<td>'.nl2br(htmlspecialchars($value)).'</td>';
                     }
                 }
-                $content.= '
+                $content .= '
 					</tr>';
                 $c++;
 
@@ -967,11 +967,11 @@ 
             $this->addErrorMessage($e->getMessage());
         }
 
-        $offset 	= intval(\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('offset'));
-        $perpage 	= 20;
+        $offset = intval(\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('offset'));
+        $perpage = 20;
 
-        $processRepository	= new tx_crawler_domain_process_repository();
-        $queueRepository	= new tx_crawler_domain_queue_repository();
+        $processRepository = new tx_crawler_domain_process_repository();
+        $queueRepository = new tx_crawler_domain_queue_repository();
 
         $mode = $this->pObj->MOD_SETTINGS['processListMode'];
         if ($mode == 'detail') {
@@ -980,7 +980,7 @@ 
             $where = 'active = 1';
         }
 
-        $allProcesses 		= $processRepository->findAll('ttl', 'DESC', $perpage, $offset, $where);
+        $allProcesses = $processRepository->findAll('ttl', 'DESC', $perpage, $offset, $where);
         $allCount			= $processRepository->countAll($where);
 
         $listView			= new tx_crawler_view_process_list();
@@ -995,7 +995,7 @@ 
         $listView->setMaxActiveProcessCount(tx_crawler_api::forceIntegerInRange($this->extensionSettings['processLimit'], 1, 99, 1));
         $listView->setMode($mode);
 
-        $paginationView		= new tx_crawler_view_pagination();
+        $paginationView = new tx_crawler_view_pagination();
         $paginationView->setCurrentOffset($offset);
         $paginationView->setPerPage($perpage);
         $paginationView->setTotalItemCount($allCount);
@@ -1033,7 +1033,7 @@ 
 
         $exitCode = 0;
         $out = [];
-        exec(escapeshellcmd($this->extensionSettings['phpPath'] . ' -v'), $out, $exitCode);
+        exec(escapeshellcmd($this->extensionSettings['phpPath'].' -v'), $out, $exitCode);
         if ($exitCode > 0) {
             $this->addErrorMessage(sprintf($LANG->sL('LLL:EXT:crawler/modfunc1/locallang.xml:message.phpBinaryNotFound'), htmlspecialchars($this->extensionSettings['phpPath'])));
         }
@@ -1246,10 +1246,10 @@ 
         $options = [];
         foreach ($optArray as $key => $val) {
             $options[] = '
-				<option value="'.htmlspecialchars($key).'"'.((!$multiple && !strcmp($value, $key)) || ($multiple && in_array($key, (array)$value))?' selected="selected"':'').'>'.htmlspecialchars($val).'</option>';
+				<option value="'.htmlspecialchars($key).'"'.((!$multiple && !strcmp($value, $key)) || ($multiple && in_array($key, (array) $value)) ? ' selected="selected"' : '').'>'.htmlspecialchars($val).'</option>';
         }
 
-        $output = '<select name="'.htmlspecialchars($name.($multiple?'[]':'')).'"'.($multiple ? ' multiple="multiple" size="'.count($options).'"' : '').'>'.implode('', $options).'</select>';
+        $output = '<select name="'.htmlspecialchars($name.($multiple ? '[]' : '')).'"'.($multiple ? ' multiple="multiple" size="'.count($options).'"' : '').'>'.implode('', $options).'</select>';
 
         return $output;
     }

view/process/class.tx_crawler_view_process_list.php

Doc Comments +3 added lines, -2 removed lines

@@ -116,6 +116,7 @@ 
      * Set the page id
      *
      * @param int page id
+     * @param integer $pageId
      */
     public function setPageId($pageId)
     {
@@ -293,7 +294,7 @@ 
      * Converts seconds into minutes
      *
      * @param int $seconds
-     * @return int
+     * @return double
      */
     protected function asMinutes($seconds)
     {
@@ -444,7 +445,7 @@ 
      * just a wrapper should be done in a cleaner way
      * later on
      *
-     * @param $label
+     * @param string $label
      * @return string
      */
     protected function getLLLabel($label)

Spacing +8 added lines, -8 removed lines

@@ -343,7 +343,7 @@ 
      */
     protected function getRefreshLink()
     {
-        return '<input onclick="window.location=\'' . \TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl('web_info') . '&SET[crawlaction]=multiprocess&id=' . $this->pageId . '\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'arrow_refresh.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.refresh') . '" />';
+        return '<input onclick="window.location=\''.\TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl('web_info').'&SET[crawlaction]=multiprocess&id='.$this->pageId.'\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'arrow_refresh.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.refresh').'" />';
     }
 
     /**
@@ -364,9 +364,9 @@ 
     protected function getEnableDisableLink()
     {
         if ($this->getIsCrawlerEnabled()) {
-            return '<input onclick="window.location+=\'&action=stopCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'control_stop_blue.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.disablecrawling') . '" />';
+            return '<input onclick="window.location+=\'&action=stopCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'control_stop_blue.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.disablecrawling').'" />';
         } else {
-            return '<input onclick="window.location+=\'&action=resumeCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'control_play.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.enablecrawling') . '" />';
+            return '<input onclick="window.location+=\'&action=resumeCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'control_play.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.enablecrawling').'" />';
         }
     }
 
@@ -379,9 +379,9 @@ 
     protected function getModeLink()
     {
         if ($this->getMode() == 'detail') {
-            return '<input onclick="window.location+=\'&SET[processListMode]=simple\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'arrow_in.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.running') . '" />';
+            return '<input onclick="window.location+=\'&SET[processListMode]=simple\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'arrow_in.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.running').'" />';
         } elseif ($this->getMode() == 'simple') {
-            return '<input onclick="window.location+=\'&SET[processListMode]=detail\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'arrow_out.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.all') . '" />';
+            return '<input onclick="window.location+=\'&SET[processListMode]=detail\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'arrow_out.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.all').'" />';
         }
     }
 
@@ -394,7 +394,7 @@ 
     protected function getAddLink()
     {
         if ($this->getActiveProcessCount() < $this->getMaxActiveProcessCount() && $this->getIsCrawlerEnabled()) {
-            return '<input onclick="window.location+=\'&action=addProcess\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'add.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.add') . '" />';
+            return '<input onclick="window.location+=\'&action=addProcess\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'add.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.add').'" />';
         } else {
             return '';
         }
@@ -416,12 +416,12 @@ 
      * @param string $icon
      * @return string html tag for icon
      */
-    protected function getIcon($icon, $title='')
+    protected function getIcon($icon, $title = '')
     {
         if (!empty($title)) {
             $title = ' title="'.$title.'"';
         }
-        return '<img src="'.$this->getIconPath().$icon.'.png" ' . $title . ' />';
+        return '<img src="'.$this->getIconPath().$icon.'.png" '.$title.' />';
     }
 
     /**

cli/bootstrap.php

Spacing +10 added lines, -10 removed lines

@@ -12,12 +12,12 @@ 
 if (!isAbsPath($tempPathThisScript)) {
     $workingDirectory = $_SERVER['PWD'] ? $_SERVER['PWD'] : getcwd();
     if ($workingDirectory) {
-        $tempPathThisScript = $workingDirectory . '/' . preg_replace('/\.\//', '', $tempPathThisScript);
+        $tempPathThisScript = $workingDirectory.'/'.preg_replace('/\.\//', '', $tempPathThisScript);
         if (!@is_file($tempPathThisScript)) {
-            die('Relative path found, but an error occured during resolving of the absolute path: ' . $tempPathThisScript . PHP_EOL);
+            die('Relative path found, but an error occured during resolving of the absolute path: '.$tempPathThisScript.PHP_EOL);
         }
     } else {
-        die('Relative path found, but resolving absolute path is not supported on this platform.' . PHP_EOL);
+        die('Relative path found, but resolving absolute path is not supported on this platform.'.PHP_EOL);
     }
 }
 
@@ -35,7 +35,7 @@ 
             list($key, $value) = explode(':', $additionalHeader, 2);
             $key = str_replace('-', '_', strtoupper(trim($key)));
             if ($key != 'HOST') {
-                $_SERVER['HTTP_' . $key] = $value;
+                $_SERVER['HTTP_'.$key] = $value;
             }
         }
     }
@@ -57,18 +57,18 @@ 
 $typo3SitePath = $_SERVER['argv'][1];
 
     // faking the environment
-$_SERVER['DOCUMENT_ROOT'] = preg_replace('#' . preg_quote($typo3SitePath, '#') . '$#', '', $typo3Root);
+$_SERVER['DOCUMENT_ROOT'] = preg_replace('#'.preg_quote($typo3SitePath, '#').'$#', '', $typo3Root);
 $_SERVER['HTTP_USER_AGENT'] = 'CLI Mode';
 $_SERVER['HTTP_HOST'] = $_SERVER['SERVER_NAME'] = $urlParts['host'];
-$_SERVER['SCRIPT_NAME'] = $_SERVER['PHP_SELF'] = $typo3SitePath . 'index.php';
-$_SERVER['SCRIPT_FILENAME'] = $_SERVER['PATH_TRANSLATED'] = $typo3Root . 'index.php';
+$_SERVER['SCRIPT_NAME'] = $_SERVER['PHP_SELF'] = $typo3SitePath.'index.php';
+$_SERVER['SCRIPT_FILENAME'] = $_SERVER['PATH_TRANSLATED'] = $typo3Root.'index.php';
 $_SERVER['QUERY_STRING'] = (isset($urlParts['query']) ? $urlParts['query'] : '');
-$_SERVER['REQUEST_URI'] = $urlParts['path'] . (isset($urlParts['query']) ? '?' . $urlParts['query'] : '');
+$_SERVER['REQUEST_URI'] = $urlParts['path'].(isset($urlParts['query']) ? '?'.$urlParts['query'] : '');
 $_SERVER['REQUEST_METHOD'] = 'GET';
 
     // Define a port if used in the URL:
 if (isset($urlParts['port'])) {
-    $_SERVER['HTTP_HOST'] .= ':' . $urlParts['port'];
+    $_SERVER['HTTP_HOST'] .= ':'.$urlParts['port'];
     $_SERVER['SERVER_PORT'] = $urlParts['port'];
 }
 
@@ -78,7 +78,7 @@ 
 }
 
 chdir($typo3Root);
-include($typo3Root . '/index.php');
+include($typo3Root.'/index.php');
 
 
 /**

cli/class.tx_crawler_cli_im.php

Indentation +5 added lines, -5 removed lines

@@ -49,11 +49,11 @@
 
         // Adding options to help archive:
         /**
-        * We removed the "proc" option as it seemd not to be working any more. But as the complete handling of the crawler has changed regarding the configuration
-        * this is completely ok. Since configuration records were introduced to configure "what should be done" additionally to page ts the way to setup jobs
-        * has drifted from selecting filtering processing instructions to selecting/filtering configuration keys (you can configure the processing instructions there).
-        * This is also reflected in the backend modules and allows you a much clearer and powerful way to work with the crawler extension.
-        */
+         * We removed the "proc" option as it seemd not to be working any more. But as the complete handling of the crawler has changed regarding the configuration
+         * this is completely ok. Since configuration records were introduced to configure "what should be done" additionally to page ts the way to setup jobs
+         * has drifted from selecting filtering processing instructions to selecting/filtering configuration keys (you can configure the processing instructions there).
+         * This is also reflected in the backend modules and allows you a much clearer and powerful way to work with the crawler extension.
+         */
         // $this->cli_options[] = array('-proc listOfProcInstr', 'Comma list of processing instructions. These are the "actions" carried out when crawling and you must specify at least one. Depends on third-party extensions. Examples are "tx_cachemgm_recache" from "cachemgm" extension (will recache pages), "tx_staticpub_publish" from "staticpub" (publishing pages to static files) or "tx_indexedsearch_reindex" from "indexed_search" (indexes pages).');
         // TODO: cleanup here!
         $this->cli_options[] = ['-d depth', 'Tree depth, 0-99', "How many levels under the 'page_id' to include."];

Spacing +2 added lines, -2 removed lines

@@ -59,7 +59,7 @@ 
         $this->cli_options[] = ['-d depth', 'Tree depth, 0-99', "How many levels under the 'page_id' to include."];
         $this->cli_options[] = ['-o mode', 'Output mode: "url", "exec", "queue"', "Specifies output modes\nurl : Will list URLs which wget could use as input.\nqueue: Will put entries in queue table.\nexec: Will execute all entries right away!"];
         $this->cli_options[] = ['-n number', 'Number of items per minute.', 'Specifies how many items are put in the queue per minute. Only valid for output mode "queue"'];
-        $this->cli_options[] = ['-conf configurationkeys','List of Configuration Keys','A commaseperated list of crawler configurations'];
+        $this->cli_options[] = ['-conf configurationkeys', 'List of Configuration Keys', 'A commaseperated list of crawler configurations'];
         #		$this->cli_options[] = array('-v level', 'Verbosity level 0-3', "The value of level can be:\n  0 = all output\n  1 = info and greater (default)\n  2 = warnings and greater\n  3 = errors");
 
         // Setting help texts:
@@ -67,7 +67,7 @@ 
         $this->cli_help['synopsis'] = 'page_id ###OPTIONS###';
         $this->cli_help['description'] = "Works as a CLI interface to some functionality from the Web > Info > Site Crawler module; It can put entries in the queue from command line options, return the list of URLs and even execute all entries right away without having to queue them up - this can be useful for immediate re-cache, re-indexing or static publishing from command line.";
         $this->cli_help['examples'] = "/.../cli_dispatch.phpsh crawler_im 7 -d=2 -conf=<configurationKey> -o=exec\nWill re-cache pages from page 7 and two levels down, executed immediately.\n";
-        $this->cli_help['examples'].= "/.../cli_dispatch.phpsh crawler_im 7 -d=0 -conf=<configurationKey> -n=4 -o=queue\nWill put entries for re-caching pages from page 7 into queue, 4 every minute.\n";
+        $this->cli_help['examples'] .= "/.../cli_dispatch.phpsh crawler_im 7 -d=0 -conf=<configurationKey> -n=4 -o=queue\nWill put entries for re-caching pages from page 7 into queue, 4 every minute.\n";
         $this->cli_help['author'] = 'Kasper Skaarhoj, Daniel Poetzinger, Fabrizio Branca, Tolleiv Nietsch, Timo Schmidt - AOE media 2009';
     }
 }

cli/crawler_multiprocess.php

Spacing +1 added lines, -1 removed lines

@@ -9,5 +9,5 @@
 try {
     $processManager->multiProcess($timeout);
 } catch (Exception $e) {
-    echo PHP_EOL . $e->getMessage();
+    echo PHP_EOL.$e->getMessage();
 }