AOEpeople / crawler

Classes/Hooks/StaticFileCacheCreateUriHook.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * @param string $uri
      * @param TypoScriptFrontendController $frontend
      *
-     * @return array
+     * @return string[]
      *
      * @throws \Exception
      *

Spacing +2 added lines, -2 removed lines

@@ -67,9 +67,9 @@
             $speakingUri = $frontend->cObj->typoLink_URL(['parameter' => $matches[1], 'additionalParams' => $matches[2]]);
             $speakingUriParts = parse_url($speakingUri);
             if (false === $speakingUriParts) {
-                throw new \Exception('Could not parse URI: ' . $speakingUri, 1289915976);
+                throw new \Exception('Could not parse URI: '.$speakingUri, 1289915976);
             }
-            $speakingUrlPath = '/' . ltrim($speakingUriParts['path'], '/');
+            $speakingUrlPath = '/'.ltrim($speakingUriParts['path'], '/');
             // Don't change anything if speaking URL is part of old URI:
             // (it might be the case the using the speaking URL failed)
             if (strpos($uri, $speakingUrlPath) !== 0 || $speakingUrlPath === '/') {

Classes/Api/CrawlerApi.php

Doc Comments +1 added lines, -1 removed lines

@@ -209,7 +209,7 @@
     /**
      * Determines if a page is queued
      *
-     * @param $uid
+     * @param integer $uid
      * @param bool $unprocessed_only
      * @param bool $timed_only
      * @param bool $timestamp

Spacing +11 added lines, -11 removed lines

@@ -91,7 +91,7 @@ 
      */
     protected function findCrawler()
     {
-        if (! is_object($this->crawlerObj)) {
+        if (!is_object($this->crawlerObj)) {
             $this->crawlerObj = GeneralUtility::makeInstance('tx_crawler_lib');
             $this->crawlerObj->setID = GeneralUtility::md5int(microtime());
         }
@@ -126,7 +126,7 @@ 
         if (count($this->allowedConfigrations) > 0) {
             // 	remove configuration that does not match the current selection
             foreach ($configurations as $confKey => $confArray) {
-                if (! in_array($confKey, $this->allowedConfigrations)) {
+                if (!in_array($confKey, $this->allowedConfigrations)) {
                     unset($configurations[$confKey]);
                 }
             }
@@ -191,12 +191,12 @@ 
         //if the same page is scheduled for the same time and has not be executed?
         if ($schedule_timestamp == 0) {
             //untimed elements need an exec_time with 0 because they can occure multiple times
-            $where = 'page_id=' . $page_uid . ' AND exec_time = 0 AND scheduled=' . $schedule_timestamp;
+            $where = 'page_id='.$page_uid.' AND exec_time = 0 AND scheduled='.$schedule_timestamp;
         } else {
             //timed elementes have got a fixed schedule time, if a record with this time
             //exists it is maybe queued for the future, or is has been queue for the past and therefore
             //also been processed.
-            $where = 'page_id=' . $page_uid . ' AND scheduled=' . $schedule_timestamp;
+            $where = 'page_id='.$page_uid.' AND scheduled='.$schedule_timestamp;
         }
 
         $row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($GLOBALS['TYPO3_DB']->exec_SELECTquery(
@@ -226,7 +226,7 @@ 
 
         $isPageInQueue = false;
 
-        $whereClause = 'page_id = ' . (integer)$uid;
+        $whereClause = 'page_id = '.(integer) $uid;
 
         if (false !== $unprocessed_only) {
             $whereClause .= ' AND exec_time = 0';
@@ -237,7 +237,7 @@ 
         }
 
         if (false !== $timestamp) {
-            $whereClause .= ' AND scheduled = ' . (integer)$timestamp;
+            $whereClause .= ' AND scheduled = '.(integer) $timestamp;
         }
 
         $count = $GLOBALS['TYPO3_DB']->exec_SELECTcountRows(
@@ -266,10 +266,10 @@ 
     {
         $uid = intval($uid);
         $query = 'max(scheduled) as latest';
-        $where = ' page_id = ' . $uid;
+        $where = ' page_id = '.$uid;
 
         if ($future_crawldates_only) {
-            $where .= ' AND scheduled > ' . time();
+            $where .= ' AND scheduled > '.time();
         }
 
         if ($unprocessed_only) {
@@ -302,7 +302,7 @@ 
         $limit = $GLOBALS['TYPO3_DB']->fullQuoteStr($limit, 'tx_crawler_queue');
 
         $query = 'scheduled, exec_time, set_id';
-        $where = ' page_id = ' . $uid;
+        $where = ' page_id = '.$uid;
 
         $limit_query = ($limit) ? $limit : null;
 
@@ -379,7 +379,7 @@ 
     {
         $qid = intval($qid);
         $table = 'tx_crawler_queue';
-        $where = ' qid=' . $qid;
+        $where = ' qid='.$qid;
         $GLOBALS['TYPO3_DB']->exec_DELETEquery($table, $where);
     }
 
@@ -407,7 +407,7 @@ 
      */
     protected function getQueueRepository()
     {
-        if (! $this->queueRepository instanceof \tx_crawler_domain_queue_repository) {
+        if (!$this->queueRepository instanceof \tx_crawler_domain_queue_repository) {
             $this->queueRepository = new \tx_crawler_domain_queue_repository();
         }
 

domain/process/class.tx_crawler_domain_process_repository.php

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
             $this->tableName,
             $where,
             '',
-            htmlspecialchars($orderField) . ' ' . htmlspecialchars($orderDirection),
+            htmlspecialchars($orderField).' '.htmlspecialchars($orderDirection),
             self::getLimitFromItemCountAndOffset($itemCount, $offset)
         );
 
@@ -111,7 +111,7 @@ 
      */
     public function countNotTimeouted($ttl)
     {
-        return $this->countByWhere('deleted = 0 AND ttl > ' . intval($ttl));
+        return $this->countByWhere('deleted = 0 AND ttl > '.intval($ttl));
     }
 
     /**
@@ -127,7 +127,7 @@ 
     {
         $itemCount = filter_var($itemCount, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'default' => 20]]);
         $offset = filter_var($offset, FILTER_VALIDATE_INT, ['options' => ['min_range' => 0, 'default' => 0]]);
-        $limit = $offset . ', ' . $itemCount;
+        $limit = $offset.', '.$itemCount;
 
         return $limit;
     }

Classes/Task/CrawlMultiProcessTask.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     public function execute()
     {
         $processManager = new \tx_crawler_domain_process_manager();
-        $timeout = is_int($this->timeOut) ? (int)$this->timeOut : 1800;
+        $timeout = is_int($this->timeOut) ? (int) $this->timeOut : 1800;
 
         try {
             $processManager->multiProcess($timeout);

template/process/list.php

Braces +5 added lines, -2 removed lines

@@ -71,8 +71,11 @@
 					</div>
 				<?php elseif ($process->getState() == 'cancelled'): ?>
 					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.cancelled'); ?>
-				<?php else: ?>
-					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success'); ?>
+				<?php else {
+    : ?>
+					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success');
+}
+?>
 				<?php endif; ?>
 				</td>
 			</tr>

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 	</thead>
 	<tbody>
 		<?php foreach ($this->getProcessCollection() as $process): /* @var $process tx_crawler_domain_process */ ?>
-			<tr class="<?php echo (++$count % 2 == 0) ? 'odd': 'even' ?>">
+			<tr class="<?php echo (++$count % 2 == 0) ? 'odd' : 'even' ?>">
 				<td><?php echo $this->getIconForState(htmlspecialchars($process->getState())); ?></td>
 				<td><?php echo htmlspecialchars($process->getProcess_id()); ?></td>
 				<td><?php echo htmlspecialchars($this->asDate($process->getTimeForFirstItem())); ?></td>

cli/class.tx_crawler_cli_im.php

Indentation +5 added lines, -5 removed lines

@@ -49,11 +49,11 @@
 
         // Adding options to help archive:
         /**
-        * We removed the "proc" option as it seemd not to be working any more. But as the complete handling of the crawler has changed regarding the configuration
-        * this is completely ok. Since configuration records were introduced to configure "what should be done" additionally to page ts the way to setup jobs
-        * has drifted from selecting filtering processing instructions to selecting/filtering configuration keys (you can configure the processing instructions there).
-        * This is also reflected in the backend modules and allows you a much clearer and powerful way to work with the crawler extension.
-        */
+         * We removed the "proc" option as it seemd not to be working any more. But as the complete handling of the crawler has changed regarding the configuration
+         * this is completely ok. Since configuration records were introduced to configure "what should be done" additionally to page ts the way to setup jobs
+         * has drifted from selecting filtering processing instructions to selecting/filtering configuration keys (you can configure the processing instructions there).
+         * This is also reflected in the backend modules and allows you a much clearer and powerful way to work with the crawler extension.
+         */
         // $this->cli_options[] = array('-proc listOfProcInstr', 'Comma list of processing instructions. These are the "actions" carried out when crawling and you must specify at least one. Depends on third-party extensions. Examples are "tx_cachemgm_recache" from "cachemgm" extension (will recache pages), "tx_staticpub_publish" from "staticpub" (publishing pages to static files) or "tx_indexedsearch_reindex" from "indexed_search" (indexes pages).');
         // TODO: cleanup here!
         $this->cli_options[] = ['-d depth', 'Tree depth, 0-99', "How many levels under the 'page_id' to include."];

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         $this->cli_options[] = ['-d depth', 'Tree depth, 0-99', "How many levels under the 'page_id' to include."];
         $this->cli_options[] = ['-o mode', 'Output mode: "url", "exec", "queue"', "Specifies output modes\nurl : Will list URLs which wget could use as input.\nqueue: Will put entries in queue table.\nexec: Will execute all entries right away!"];
         $this->cli_options[] = ['-n number', 'Number of items per minute.', 'Specifies how many items are put in the queue per minute. Only valid for output mode "queue"'];
-        $this->cli_options[] = ['-conf configurationkeys','List of Configuration Keys','A commaseperated list of crawler configurations'];
+        $this->cli_options[] = ['-conf configurationkeys', 'List of Configuration Keys', 'A commaseperated list of crawler configurations'];
         #		$this->cli_options[] = array('-v level', 'Verbosity level 0-3', "The value of level can be:\n  0 = all output\n  1 = info and greater (default)\n  2 = warnings and greater\n  3 = errors");
 
         // Setting help texts:

cli/crawler_multiprocess.php

Spacing +1 added lines, -1 removed lines

@@ -9,5 +9,5 @@
 try {
     $processManager->multiProcess($timeout);
 } catch (Exception $e) {
-    echo PHP_EOL . $e->getMessage();
+    echo PHP_EOL.$e->getMessage();
 }

domain/events/class.tx_crawler_domain_events_dispatcher.php

Spacing +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
     {
         if (is_array($this->observers[$event])) {
             foreach ($this->observers[$event] as $eventObserver) {
-                call_user_func([$eventObserver['object'],$eventObserver['method']], $event, $group, $attachedData);
+                call_user_func([$eventObserver['object'], $eventObserver['method']], $event, $group, $attachedData);
             }
         }
     }

Classes/Utility/HookUtility.php

Spacing +5 added lines, -5 removed lines

@@ -45,17 +45,17 @@
     public static function registerHooks($extKey)
     {
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['connectToDB']['tx_crawler'] =
-            TsfeHook::class . '->fe_init';
+            TsfeHook::class.'->fe_init';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['initFEuser']['tx_crawler'] =
-            TsfeHook::class . '->fe_feuserInit';
+            TsfeHook::class.'->fe_feuserInit';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting']['tx_crawler'] =
-            TsfeHook::class . '->fe_isOutputting';
+            TsfeHook::class.'->fe_isOutputting';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_eofe']['tx_crawler'] =
-            TsfeHook::class . '->fe_eofe';
+            TsfeHook::class.'->fe_eofe';
 
         // Activating NC Static File Cache hook
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['nc_staticfilecache/class.tx_ncstaticfilecache.php']['createFile_initializeVariables']['tx_crawler'] =
-            StaticFileCacheCreateUriHook::class . '->initialize';
+            StaticFileCacheCreateUriHook::class.'->initialize';
 
         // Activating Crawler cli_hooks
         $GLOBALS['TYPO3_CONF_VARS']['EXTCONF'][$extKey]['cli_hooks'][] =