AOE\Crawler\Configuration\ExtensionConfigurationProvider

Complexity

Total Complexity

3

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Test Coverage

Coverage

33.33%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getExtensionConfiguration()	0	8	3

<?php

declare(strict_types=1);

namespace AOE\Crawler\Configuration;

 /*
 * (c) 2020 AOE GmbH <dev@aoe.com>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationExtensionNotConfiguredException;
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationPathDoesNotExistException;
use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
use TYPO3\CMS\Core\Utility\GeneralUtility;

class ExtensionConfigurationProvider implements LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * Return full extension configuration array.
     */
    public function getExtensionConfiguration(): array
    {
        try {
            return GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('crawler');
        } catch (ExtensionConfigurationExtensionNotConfiguredException $e) {
            $this->logger->error($e->getMessage());

In this branch, the function will implicitly return null which is incompatible with the type-hinted return array. Consider adding a return statement or allowing null as return value.

        } catch (ExtensionConfigurationPathDoesNotExistException $e) {
            $this->logger->error($e->getMessage());
        }
    }
}