ExtensionConfigurationProvider::getExtensionConfiguration() - Code Metrics - Inspection of "[WIP] Documentation" - AOEpeople/crawler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — features/addFlushedPagesToCraw... ( 44f5f4...d700c8 )

by Tomas Norre

created 2020-07-13 20:19 UTC

getExtensionConfiguration() A

↳ Parent: ExtensionConfigurationProvider

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	5.667

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	0
dl	0
loc	8
ccs	2
cts	6
cp	0.3333
crap	5.667
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace AOE\Crawler\Configuration;

 /*
 * (c) 2020 AOE GmbH <[email protected]>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationExtensionNotConfiguredException;
use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationPathDoesNotExistException;
use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
use TYPO3\CMS\Core\Utility\GeneralUtility;

class ExtensionConfigurationProvider implements LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * Return full extension configuration array.
     */
    public function getExtensionConfiguration(): array
    {
        try {
            return GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('crawler');
        } catch (ExtensionConfigurationExtensionNotConfiguredException $e) {
            $this->logger->error($e->getMessage());
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        } catch (ExtensionConfigurationPathDoesNotExistException $e) {
            $this->logger->error($e->getMessage());
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace AOE\Crawler\Configuration;
6
7		/*
8		* (c) 2020 AOE GmbH <[email protected]>
9		*
10		* This file is part of the TYPO3 Crawler Extension.
11		*
12		* It is free software; you can redistribute it and/or modify it under
13		* the terms of the GNU General Public License, either version 2
14		* of the License, or any later version.
15		*
16		* For the full copyright and license information, please read the
17		* LICENSE.txt file that was distributed with this source code.
18		*
19		* The TYPO3 project - inspiring people to share!
20		*/
21
22		use Psr\Log\LoggerAwareInterface;
23		use Psr\Log\LoggerAwareTrait;
24		use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationExtensionNotConfiguredException;
25		use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationPathDoesNotExistException;
26		use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
27		use TYPO3\CMS\Core\Utility\GeneralUtility;
28
29		class ExtensionConfigurationProvider implements LoggerAwareInterface
30		{
31		use LoggerAwareTrait;
32
33		/**
34		* Return full extension configuration array.
35		*/
36	82	public function getExtensionConfiguration(): array
37		{
38		try {
39	82	return GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('crawler');
40		} catch (ExtensionConfigurationExtensionNotConfiguredException $e) {
41		$this->logger->error($e->getMessage());
		0 ignored issues – show Bug Best Practice introduced 2020-02-25 20:00 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `array`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
42		} catch (ExtensionConfigurationPathDoesNotExistException $e) {
43		$this->logger->error($e->getMessage());
44		}
45		}
46		}
47

AOEpeople / crawler

Push — features/addFlushedPagesToCraw... ( 44f5f4...d700c8 )

getExtensionConfiguration() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like