Completed
Pull Request — typo3v9 (#435)
by Benni
26:24 queued 09:18
created
Classes/Hooks/StaticFileCacheCreateUriHook.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      * @param string $uri
54 54
      * @param TypoScriptFrontendController $frontend
55 55
      *
56
-     * @return array
56
+     * @return string[]
57 57
      *
58 58
      * @throws \Exception
59 59
      *
Please login to merge, or discard this patch.
Classes/Domain/Repository/QueueRepository.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param $processId
63
+     * @param string $processId
64 64
      */
65 65
     public function unsetQueueProcessId($processId)
66 66
     {
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
     /**
439 439
      * Determines if a page is queued
440 440
      *
441
-     * @param $uid
441
+     * @param integer $uid
442 442
      * @param bool $unprocessed_only
443 443
      * @param bool $timed_only
444 444
      * @param bool $timestamp
Please login to merge, or discard this patch.
Classes/Command/CrawlerCommandController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -250,7 +250,7 @@
 block discarded – undo
250 250
     /**
251 251
      * Obtains configuration keys from the CLI arguments
252 252
      *
253
-     * @param $conf string
253
+     * @param string $conf string
254 254
      * @return array
255 255
      */
256 256
     private function getConfigurationKeys($conf)
Please login to merge, or discard this patch.
Classes/Api/CrawlerApi.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@
 block discarded – undo
297 297
      * scheduled but have note been crawled yet.
298 298
      *
299 299
      * @param int $uid uid of the page
300
-     * @param bool $limit
300
+     * @param integer $limit
301 301
      *
302 302
      * @return array array with the crawl-history of a page => 0 : scheduled time , 1 : executed_time, 2 : set_id
303 303
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use TYPO3\CMS\Core\Database\ConnectionPool;
32 32
 use TYPO3\CMS\Core\Database\Query\QueryBuilder;
33 33
 use TYPO3\CMS\Core\Utility\GeneralUtility;
34
-use TYPO3\CMS\Core\Utility\MathUtility;
35 34
 use TYPO3\CMS\Extbase\Object\ObjectManager;
36 35
 use TYPO3\CMS\Frontend\Page\PageRepository;
37 36
 
Please login to merge, or discard this patch.
Classes/Controller/CrawlerController.php 1 patch
Doc Comments   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -407,6 +407,10 @@  discard block
 block discarded – undo
407 407
      * @param    array        Array which is passed by reference and contains the an id per url to secure we will not crawl duplicates
408 408
      * @param    array        Array which will be filled with URLS for download if flag is set.
409 409
      * @param    array        Array of processing instructions
410
+     * @param integer $scheduledTime
411
+     * @param integer $reqMinute
412
+     * @param boolean $submitCrawlUrls
413
+     * @param boolean $downloadCrawlUrls
410 414
      * @return    string        List of URLs (meant for display in backend module)
411 415
      *
412 416
      */
@@ -701,7 +705,7 @@  discard block
 block discarded – undo
701 705
     }
702 706
 
703 707
     /**
704
-     * @param $rootid
708
+     * @param integer $rootid
705 709
      * @param $depth
706 710
      * @return array
707 711
      *
@@ -962,7 +966,7 @@  discard block
 block discarded – undo
962 966
      * The number of URLs will be the multiplication of the number of parameter values for each key
963 967
      *
964 968
      * @param array $paramArray Output of expandParameters(): Array with keys (GET var names) and for each an array of values
965
-     * @param array $urls URLs accumulated in this array (for recursion)
969
+     * @param string[] $urls URLs accumulated in this array (for recursion)
966 970
      * @return array
967 971
      */
968 972
     public function compileUrls($paramArray, $urls = [])
@@ -1722,7 +1726,7 @@  discard block
 block discarded – undo
1722 1726
      * @param array $url
1723 1727
      * @param string $crawlerId
1724 1728
      *
1725
-     * @return array
1729
+     * @return string[]
1726 1730
      */
1727 1731
     protected function buildRequestHeaderArray(array $url, $crawlerId)
1728 1732
     {
@@ -1995,6 +1999,7 @@  discard block
 block discarded – undo
1995 1999
      *
1996 2000
      * @param    array        Page row
1997 2001
      * @param    string        Page icon and title for row
2002
+     * @param string $pageTitleAndIcon
1998 2003
      * @return    string        HTML <tr> content (one or more)
1999 2004
      */
2000 2005
     public function drawURLs_addRowsForPage(array $pageRow, $pageTitleAndIcon)
@@ -2119,7 +2124,7 @@  discard block
 block discarded – undo
2119 2124
      * @param int $countInARun
2120 2125
      * @param int $sleepTime
2121 2126
      * @param int $sleepAfterFinish
2122
-     * @return string
2127
+     * @return integer
2123 2128
      */
2124 2129
     public function CLI_run($countInARun, $sleepTime, $sleepAfterFinish)
2125 2130
     {
@@ -2421,6 +2426,7 @@  discard block
 block discarded – undo
2421 2426
      * Used to determine timeouts and to ensure a proper cleanup if there's a timeout
2422 2427
      *
2423 2428
      * @param  string  identification string for the process
2429
+     * @param string $pid
2424 2430
      * @return boolean determines if the process is still active / has resources
2425 2431
      *
2426 2432
      * TODO: Please consider moving this to Domain Model for Process or in ProcessRepository
Please login to merge, or discard this patch.