Completed
Push — remove/command-line-controller ( ce3e0b )
by Tomas Norre
14:48
created
Classes/Hooks/StaticFileCacheCreateUriHook.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      * @param string $uri
54 54
      * @param TypoScriptFrontendController $frontend
55 55
      *
56
-     * @return array
56
+     * @return string[]
57 57
      *
58 58
      * @throws \Exception
59 59
      *
Please login to merge, or discard this patch.
Classes/Backend/View/ProcessListView.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
     /**
358 358
      * Returns a tag for the refresh icon
359 359
      *
360
-     * @return string
360
+     * @return ButtonUtility
361 361
      */
362 362
     protected function getRefreshLink()
363 363
     {
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
     /**
372 372
      * Returns a link for the panel to enable or disable the crawler
373 373
      *
374
-     * @return string
374
+     * @return ButtonUtility
375 375
      */
376 376
     protected function getEnableDisableLink()
377 377
     {
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
      *
398 398
      * @param void
399 399
      *
400
-     * @return string a-tag
400
+     * @return ButtonUtility|null a-tag
401 401
      */
402 402
     protected function getModeLink()
403 403
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -28,9 +28,7 @@
 block discarded – undo
28 28
 use AOE\Crawler\Domain\Model\ProcessCollection;
29 29
 use AOE\Crawler\Utility\BackendModuleUtility;
30 30
 use AOE\Crawler\Utility\ButtonUtility;
31
-use TYPO3\CMS\Backend\Utility\BackendUtility;
32 31
 use TYPO3\CMS\Core\Utility\GeneralUtility;
33
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
34 32
 
35 33
 /**
36 34
  * Class ProcessListView
Please login to merge, or discard this patch.
Classes/Api/CrawlerApi.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
     /**
224 224
      * Determines if a page is queued
225 225
      *
226
-     * @param $uid
226
+     * @param integer $uid
227 227
      * @param bool $unprocessed_only
228 228
      * @param bool $timed_only
229 229
      * @param bool $timestamp
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
      * scheduled but have note been crawled yet.
305 305
      *
306 306
      * @param int $uid uid of the page
307
-     * @param bool $limit
307
+     * @param integer $limit
308 308
      *
309 309
      * @return array array with the crawl-history of a page => 0 : scheduled time , 1 : executed_time, 2 : set_id
310 310
      */
Please login to merge, or discard this patch.
Classes/Domain/Repository/QueueRepository.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param $processId
63
+     * @param string $processId
64 64
      */
65 65
     public function unsetQueueProcessId($processId)
66 66
     {
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
     /**
439 439
      * Determines if a page is queued
440 440
      *
441
-     * @param $uid
441
+     * @param integer $uid
442 442
      * @param bool $unprocessed_only
443 443
      * @param bool $timed_only
444 444
      * @param bool $timestamp
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -29,10 +29,8 @@
 block discarded – undo
29 29
 use AOE\Crawler\Domain\Model\Queue;
30 30
 use TYPO3\CMS\Core\Database\ConnectionPool;
31 31
 use TYPO3\CMS\Core\Database\Query\QueryBuilder;
32
-use TYPO3\CMS\Core\Exception;
33 32
 use TYPO3\CMS\Core\Utility\GeneralUtility;
34 33
 use TYPO3\CMS\Core\Utility\MathUtility;
35
-use TYPO3\CMS\Extbase\Persistence\Generic\QueryResult;
36 34
 
37 35
 /**
38 36
  * Class QueueRepository
Please login to merge, or discard this patch.
Classes/Controller/CrawlerController.php 2 patches
Doc Comments   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -436,6 +436,10 @@  discard block
 block discarded – undo
436 436
      * @param    array        Array which is passed by reference and contains the an id per url to secure we will not crawl duplicates
437 437
      * @param    array        Array which will be filled with URLS for download if flag is set.
438 438
      * @param    array        Array of processing instructions
439
+     * @param integer $scheduledTime
440
+     * @param integer $reqMinute
441
+     * @param boolean $submitCrawlUrls
442
+     * @param boolean $downloadCrawlUrls
439 443
      * @return    string        List of URLs (meant for display in backend module)
440 444
      *
441 445
      */
@@ -560,7 +564,7 @@  discard block
 block discarded – undo
560 564
      *
561 565
      * @param string $piString PI to test
562 566
      * @param array $incomingProcInstructions Processing instructions
563
-     * @return boolean
567
+     * @return boolean|null
564 568
      */
565 569
     public function drawURLs_PIfilter($piString, array $incomingProcInstructions)
566 570
     {
@@ -781,7 +785,7 @@  discard block
 block discarded – undo
781 785
     }
782 786
 
783 787
     /**
784
-     * @param $rootid
788
+     * @param integer $rootid
785 789
      * @param $depth
786 790
      * @return array
787 791
      *
@@ -1043,7 +1047,7 @@  discard block
 block discarded – undo
1043 1047
      * The number of URLs will be the multiplication of the number of parameter values for each key
1044 1048
      *
1045 1049
      * @param array $paramArray Output of expandParameters(): Array with keys (GET var names) and for each an array of values
1046
-     * @param array $urls URLs accumulated in this array (for recursion)
1050
+     * @param string[] $urls URLs accumulated in this array (for recursion)
1047 1051
      * @return array
1048 1052
      */
1049 1053
     public function compileUrls($paramArray, $urls = [])
@@ -1780,6 +1784,7 @@  discard block
 block discarded – undo
1780 1784
 
1781 1785
     /**
1782 1786
      * @param message
1787
+     * @param string $message
1783 1788
      */
1784 1789
     protected function log($message)
1785 1790
     {
@@ -1797,7 +1802,7 @@  discard block
 block discarded – undo
1797 1802
      * @param array $url
1798 1803
      * @param string $crawlerId
1799 1804
      *
1800
-     * @return array
1805
+     * @return string[]
1801 1806
      */
1802 1807
     protected function buildRequestHeaderArray(array $url, $crawlerId)
1803 1808
     {
@@ -2074,6 +2079,7 @@  discard block
 block discarded – undo
2074 2079
      *
2075 2080
      * @param    array        Page row
2076 2081
      * @param    string        Page icon and title for row
2082
+     * @param string $pageTitleAndIcon
2077 2083
      * @return    string        HTML <tr> content (one or more)
2078 2084
      */
2079 2085
     public function drawURLs_addRowsForPage(array $pageRow, $pageTitleAndIcon)
@@ -2436,7 +2442,7 @@  discard block
 block discarded – undo
2436 2442
      * @param int $countInARun
2437 2443
      * @param int $sleepTime
2438 2444
      * @param int $sleepAfterFinish
2439
-     * @return string
2445
+     * @return integer
2440 2446
      */
2441 2447
     public function CLI_run($countInARun, $sleepTime, $sleepAfterFinish)
2442 2448
     {
@@ -2761,6 +2767,7 @@  discard block
 block discarded – undo
2761 2767
      * Used to determine timeouts and to ensure a proper cleanup if there's a timeout
2762 2768
      *
2763 2769
      * @param  string  identification string for the process
2770
+     * @param string $pid
2764 2771
      * @return boolean determines if the process is still active / has resources
2765 2772
      *
2766 2773
      * TODO: Please consider moving this to Domain Model for Process or in ProcessRepository
@@ -2801,7 +2808,7 @@  discard block
 block discarded – undo
2801 2808
     /**
2802 2809
      * @param bool $get_as_float
2803 2810
      *
2804
-     * @return mixed
2811
+     * @return string
2805 2812
      */
2806 2813
     protected function microtime($get_as_float = false)
2807 2814
     {
@@ -2922,7 +2929,7 @@  discard block
 block discarded – undo
2922 2929
      * Check whether the Crawling Protocol should be http or https
2923 2930
      *
2924 2931
      * @param $crawlerConfiguration
2925
-     * @param $pageConfiguration
2932
+     * @param boolean $pageConfiguration
2926 2933
      *
2927 2934
      * @return bool
2928 2935
      */
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@  discard block
 block discarded – undo
25 25
  *  This copyright notice MUST APPEAR in all copies of the script!
26 26
  ***************************************************************/
27 27
 
28
-use AOE\Crawler\Domain\Model\Reason;
29 28
 use AOE\Crawler\Domain\Repository\ProcessRepository;
30 29
 use AOE\Crawler\Domain\Repository\QueueRepository;
31 30
 use AOE\Crawler\Event\EventDispatcher;
@@ -36,10 +35,8 @@  discard block
 block discarded – undo
36 35
 use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
37 36
 use TYPO3\CMS\Core\Database\Connection;
38 37
 use TYPO3\CMS\Core\Database\ConnectionPool;
39
-use TYPO3\CMS\Core\Database\DatabaseConnection;
40 38
 use TYPO3\CMS\Core\Log\Logger;
41 39
 use TYPO3\CMS\Core\Log\LogLevel;
42
-use TYPO3\CMS\Core\TimeTracker\NullTimeTracker;
43 40
 use TYPO3\CMS\Core\TimeTracker\TimeTracker;
44 41
 use TYPO3\CMS\Core\Utility\DebugUtility;
45 42
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
@@ -47,7 +44,6 @@  discard block
 block discarded – undo
47 44
 use TYPO3\CMS\Core\Utility\MathUtility;
48 45
 use TYPO3\CMS\Extbase\Object\ObjectManager;
49 46
 use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
50
-use TYPO3\CMS\Frontend\Page\PageGenerator;
51 47
 use TYPO3\CMS\Frontend\Page\PageRepository;
52 48
 use TYPO3\CMS\Frontend\Utility\EidUtility;
53 49
 use TYPO3\CMS\Lang\LanguageService;
Please login to merge, or discard this patch.
Classes/Backend/BackendModule.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,6 @@  discard block
 block discarded – undo
41 41
 use TYPO3\CMS\Backend\Tree\View\PageTreeView;
42 42
 use TYPO3\CMS\Backend\Utility\BackendUtility;
43 43
 use TYPO3\CMS\Beuser\Domain\Model\BackendUser;
44
-use TYPO3\CMS\Beuser\Domain\Model\Demand;
45 44
 use TYPO3\CMS\Beuser\Domain\Repository\BackendUserRepository;
46 45
 use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
47 46
 use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
@@ -56,7 +55,6 @@  discard block
 block discarded – undo
56 55
 use TYPO3\CMS\Core\Utility\VersionNumberUtility;
57 56
 use TYPO3\CMS\Extbase\Object\ObjectManager;
58 57
 use TYPO3\CMS\Extbase\Persistence\Generic\QueryResult;
59
-use TYPO3\CMS\Backend\Routing\UriBuilder;
60 58
 
61 59
 /**
62 60
  * Class BackendModule
Please login to merge, or discard this patch.
Classes/Utility/TcaUtility.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 
22 22
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
23
-use TYPO3\CMS\Core\Utility\PathUtility;
24 23
 
25 24
 /**
26 25
  * Class TcaUtility
Please login to merge, or discard this patch.