AOEpeople / crawler

domain/process/class.tx_crawler_domain_process_repository.php

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
             $this->tableName,
             $where,
             '',
-            htmlspecialchars($orderField) . ' ' . htmlspecialchars($orderDirection),
+            htmlspecialchars($orderField).' '.htmlspecialchars($orderDirection),
             self::getLimitFromItemCountAndOffset($itemCount, $offset)
         );
 
@@ -111,7 +111,7 @@ 
      */
     public function countNotTimeouted($ttl)
     {
-        return $this->countByWhere('deleted = 0 AND ttl > ' . intval($ttl));
+        return $this->countByWhere('deleted = 0 AND ttl > '.intval($ttl));
     }
 
     /**
@@ -127,7 +127,7 @@ 
     {
         $itemCount = filter_var($itemCount, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'default' => 20]]);
         $offset = filter_var($offset, FILTER_VALIDATE_INT, ['options' => ['min_range' => 0, 'default' => 0]]);
-        $limit = $offset . ', ' . $itemCount;
+        $limit = $offset.', '.$itemCount;
 
         return $limit;
     }

domain/reason/class.tx_crawler_domain_reason.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      * This method is used to set the uid of the queue entry
      * where the reason is relevant for.
      *
-     * @param int $entry_id
+     * @param int $entry_uid
      */
     public function setQueueEntryUid($entry_uid)
     {

template/process/list.php

Braces +5 added lines, -2 removed lines

@@ -71,8 +71,11 @@
 					</div>
 				<?php elseif ($process->getState() == 'cancelled'): ?>
 					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.cancelled'); ?>
-				<?php else: ?>
-					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success'); ?>
+				<?php else {
+    : ?>
+					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success');
+}
+?>
 				<?php endif; ?>
 				</td>
 			</tr>

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 	</thead>
 	<tbody>
 		<?php foreach ($this->getProcessCollection() as $process): /* @var $process tx_crawler_domain_process */ ?>
-			<tr class="<?php echo (++$count % 2 == 0) ? 'odd': 'even' ?>">
+			<tr class="<?php echo (++$count % 2 == 0) ? 'odd' : 'even' ?>">
 				<td><?php echo $this->getIconForState(htmlspecialchars($process->getState())); ?></td>
 				<td><?php echo htmlspecialchars($process->getProcess_id()); ?></td>
 				<td><?php echo htmlspecialchars($this->asDate($process->getTimeForFirstItem())); ?></td>

domain/queue/class.tx_crawler_domain_queue_repository.php

Indentation +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     {
         $db = $this->getDB();
         $where = 'process_id_completed='.$db->fullQuoteStr($process->getProcess_id(), $this->tableName).
-                 ' AND exec_time > 0 ';
+                    ' AND exec_time > 0 ';
         $limit = 1;
         $groupby = '';
 

Spacing +2 added lines, -2 removed lines

@@ -211,7 +211,7 @@ 
             $res = $db->exec_SELECTquery(
                 'configuration, count(*) as c',
                 $this->tableName,
-                'set_id in ('. implode(',', $setIds).') AND scheduled < '.time(),
+                'set_id in ('.implode(',', $setIds).') AND scheduled < '.time(),
                 'configuration'
             );
             while ($row = $db->sql_fetch_assoc($res)) {
@@ -291,7 +291,7 @@ 
         $res = $db->exec_SELECTquery(
             'process_id_completed, min(exec_time) as start, max(exec_time) as end, count(*) as urlcount',
             $this->tableName,
-            'exec_time != 0 and exec_time >= '.intval($start). ' and exec_time <= ' . intval($end),
+            'exec_time != 0 and exec_time >= '.intval($start).' and exec_time <= '.intval($end),
             'process_id_completed'
         );
 

view/process/class.tx_crawler_view_process_list.php

Doc Comments +3 added lines, -2 removed lines

@@ -116,6 +116,7 @@ 
      * Set the page id
      *
      * @param int page id
+     * @param integer $pageId
      */
     public function setPageId($pageId)
     {
@@ -293,7 +294,7 @@ 
      * Converts seconds into minutes
      *
      * @param int $seconds
-     * @return int
+     * @return double
      */
     protected function asMinutes($seconds)
     {
@@ -444,7 +445,7 @@ 
      * just a wrapper should be done in a cleaner way
      * later on
      *
-     * @param $label
+     * @param string $label
      * @return string
      */
     protected function getLLLabel($label)

Spacing +7 added lines, -7 removed lines

@@ -339,7 +339,7 @@ 
      */
     protected function getRefreshLink()
     {
-        return '<input onclick="window.location=\'' . \TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl('web_info') . '&SET[crawlaction]=multiprocess&id=' . $this->pageId . '\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'arrow_refresh.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.refresh') . '" />';
+        return '<input onclick="window.location=\''.\TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl('web_info').'&SET[crawlaction]=multiprocess&id='.$this->pageId.'\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'arrow_refresh.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.refresh').'" />';
     }
 
     /**
@@ -360,9 +360,9 @@ 
     protected function getEnableDisableLink()
     {
         if ($this->getIsCrawlerEnabled()) {
-            return '<input onclick="window.location+=\'&action=stopCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'control_stop_blue.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.disablecrawling') . '" />';
+            return '<input onclick="window.location+=\'&action=stopCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'control_stop_blue.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.disablecrawling').'" />';
         } else {
-            return '<input onclick="window.location+=\'&action=resumeCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'control_play.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.enablecrawling') . '" />';
+            return '<input onclick="window.location+=\'&action=resumeCrawling\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'control_play.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.enablecrawling').'" />';
         }
     }
 
@@ -375,9 +375,9 @@ 
     protected function getModeLink()
     {
         if ($this->getMode() == 'detail') {
-            return '<input onclick="window.location+=\'&SET[processListMode]=simple\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'arrow_in.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.running') . '" />';
+            return '<input onclick="window.location+=\'&SET[processListMode]=simple\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'arrow_in.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.running').'" />';
         } elseif ($this->getMode() == 'simple') {
-            return '<input onclick="window.location+=\'&SET[processListMode]=detail\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'arrow_out.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.all') . '" />';
+            return '<input onclick="window.location+=\'&SET[processListMode]=detail\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'arrow_out.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.show.all').'" />';
         }
     }
 
@@ -390,7 +390,7 @@ 
     protected function getAddLink()
     {
         if ($this->getActiveProcessCount() < $this->getMaxActiveProcessCount() && $this->getIsCrawlerEnabled()) {
-            return '<input onclick="window.location+=\'&action=addProcess\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\'' . $this->getIconPath() . 'add.png' . '\'); background-repeat: no-repeat;" value="' . $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.add') . '" />';
+            return '<input onclick="window.location+=\'&action=addProcess\';" type="button" style="padding:4px 4px 4px 20px; background-position: 3px 3px; background-image: url(\''.$this->getIconPath().'add.png'.'\'); background-repeat: no-repeat;" value="'.$this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.add').'" />';
         } else {
             return '';
         }
@@ -417,7 +417,7 @@ 
         if (!empty($title)) {
             $title = ' title="'.$title.'"';
         }
-        return '<img src="'.$this->getIconPath().$icon.'.png" ' . $title . ' />';
+        return '<img src="'.$this->getIconPath().$icon.'.png" '.$title.' />';
     }
 
     /**

cli/class.tx_crawler_cli_im.php

Indentation +5 added lines, -5 removed lines

@@ -49,11 +49,11 @@
 
         // Adding options to help archive:
         /**
-        * We removed the "proc" option as it seemd not to be working any more. But as the complete handling of the crawler has changed regarding the configuration
-        * this is completely ok. Since configuration records were introduced to configure "what should be done" additionally to page ts the way to setup jobs
-        * has drifted from selecting filtering processing instructions to selecting/filtering configuration keys (you can configure the processing instructions there).
-        * This is also reflected in the backend modules and allows you a much clearer and powerful way to work with the crawler extension.
-        */
+         * We removed the "proc" option as it seemd not to be working any more. But as the complete handling of the crawler has changed regarding the configuration
+         * this is completely ok. Since configuration records were introduced to configure "what should be done" additionally to page ts the way to setup jobs
+         * has drifted from selecting filtering processing instructions to selecting/filtering configuration keys (you can configure the processing instructions there).
+         * This is also reflected in the backend modules and allows you a much clearer and powerful way to work with the crawler extension.
+         */
         // $this->cli_options[] = array('-proc listOfProcInstr', 'Comma list of processing instructions. These are the "actions" carried out when crawling and you must specify at least one. Depends on third-party extensions. Examples are "tx_cachemgm_recache" from "cachemgm" extension (will recache pages), "tx_staticpub_publish" from "staticpub" (publishing pages to static files) or "tx_indexedsearch_reindex" from "indexed_search" (indexes pages).');
         // TODO: cleanup here!
         $this->cli_options[] = ['-d depth', 'Tree depth, 0-99', "How many levels under the 'page_id' to include."];

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         $this->cli_options[] = ['-d depth', 'Tree depth, 0-99', "How many levels under the 'page_id' to include."];
         $this->cli_options[] = ['-o mode', 'Output mode: "url", "exec", "queue"', "Specifies output modes\nurl : Will list URLs which wget could use as input.\nqueue: Will put entries in queue table.\nexec: Will execute all entries right away!"];
         $this->cli_options[] = ['-n number', 'Number of items per minute.', 'Specifies how many items are put in the queue per minute. Only valid for output mode "queue"'];
-        $this->cli_options[] = ['-conf configurationkeys','List of Configuration Keys','A commaseperated list of crawler configurations'];
+        $this->cli_options[] = ['-conf configurationkeys', 'List of Configuration Keys', 'A commaseperated list of crawler configurations'];
         #		$this->cli_options[] = array('-v level', 'Verbosity level 0-3', "The value of level can be:\n  0 = all output\n  1 = info and greater (default)\n  2 = warnings and greater\n  3 = errors");
 
         // Setting help texts:

cli/crawler_multiprocess.php

Spacing +1 added lines, -1 removed lines

@@ -9,5 +9,5 @@
 try {
     $processManager->multiProcess($timeout);
 } catch (Exception $e) {
-    echo PHP_EOL . $e->getMessage();
+    echo PHP_EOL.$e->getMessage();
 }

domain/events/class.tx_crawler_domain_events_dispatcher.php

Spacing +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
     {
         if (is_array($this->observers[$event])) {
             foreach ($this->observers[$event] as $eventObserver) {
-                call_user_func([$eventObserver['object'],$eventObserver['method']], $event, $group, $attachedData);
+                call_user_func([$eventObserver['object'], $eventObserver['method']], $event, $group, $attachedData);
             }
         }
     }

Classes/Utility/HookUtility.php

Spacing +5 added lines, -5 removed lines

@@ -45,17 +45,17 @@
     public static function registerHooks($extKey)
     {
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['connectToDB']['tx_crawler'] =
-            TsfeHook::class . '->fe_init';
+            TsfeHook::class.'->fe_init';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['initFEuser']['tx_crawler'] =
-            TsfeHook::class . '->fe_feuserInit';
+            TsfeHook::class.'->fe_feuserInit';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting']['tx_crawler'] =
-            TsfeHook::class . '->fe_isOutputting';
+            TsfeHook::class.'->fe_isOutputting';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_eofe']['tx_crawler'] =
-            TsfeHook::class . '->fe_eofe';
+            TsfeHook::class.'->fe_eofe';
 
         // Activating NC Static File Cache hook
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['nc_staticfilecache/class.tx_ncstaticfilecache.php']['createFile_initializeVariables']['tx_crawler'] =
-            StaticFileCacheCreateUriHook::class . '->initialize';
+            StaticFileCacheCreateUriHook::class.'->initialize';
 
         // Activating Crawler cli_hooks
         $GLOBALS['TYPO3_CONF_VARS']['EXTCONF'][$extKey]['cli_hooks'][] =