Completed
Pull Request — typo3v9 (#451)
by Benni
13:56
created
Classes/Hooks/StaticFileCacheCreateUriHook.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      * @param string $uri
54 54
      * @param TypoScriptFrontendController $frontend
55 55
      *
56
-     * @return array
56
+     * @return string[]
57 57
      *
58 58
      * @throws \Exception
59 59
      *
Please login to merge, or discard this patch.
Classes/Domain/Repository/QueueRepository.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param $processId
63
+     * @param string $processId
64 64
      */
65 65
     public function unsetQueueProcessId($processId)
66 66
     {
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
     /**
439 439
      * Determines if a page is queued
440 440
      *
441
-     * @param $uid
441
+     * @param integer $uid
442 442
      * @param bool $unprocessed_only
443 443
      * @param bool $timed_only
444 444
      * @param bool $timestamp
Please login to merge, or discard this patch.
Classes/Command/CrawlerCommandController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -250,7 +250,7 @@
 block discarded – undo
250 250
     /**
251 251
      * Obtains configuration keys from the CLI arguments
252 252
      *
253
-     * @param $conf string
253
+     * @param string $conf string
254 254
      * @return array
255 255
      */
256 256
     private function getConfigurationKeys($conf)
Please login to merge, or discard this patch.
Classes/Api/CrawlerApi.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@
 block discarded – undo
297 297
      * scheduled but have note been crawled yet.
298 298
      *
299 299
      * @param int $uid uid of the page
300
-     * @param bool $limit
300
+     * @param integer $limit
301 301
      *
302 302
      * @return array array with the crawl-history of a page => 0 : scheduled time , 1 : executed_time, 2 : set_id
303 303
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use TYPO3\CMS\Core\Database\ConnectionPool;
32 32
 use TYPO3\CMS\Core\Database\Query\QueryBuilder;
33 33
 use TYPO3\CMS\Core\Utility\GeneralUtility;
34
-use TYPO3\CMS\Core\Utility\MathUtility;
35 34
 use TYPO3\CMS\Extbase\Object\ObjectManager;
36 35
 use TYPO3\CMS\Frontend\Page\PageRepository;
37 36
 
Please login to merge, or discard this patch.
Classes/Controller/CrawlerController.php 2 patches
Doc Comments   +9 added lines, -4 removed lines patch added patch discarded remove patch
@@ -414,6 +414,10 @@  discard block
 block discarded – undo
414 414
      * @param    array        Array which is passed by reference and contains the an id per url to secure we will not crawl duplicates
415 415
      * @param    array        Array which will be filled with URLS for download if flag is set.
416 416
      * @param    array        Array of processing instructions
417
+     * @param integer $scheduledTime
418
+     * @param integer $reqMinute
419
+     * @param boolean $submitCrawlUrls
420
+     * @param boolean $downloadCrawlUrls
417 421
      * @return    string        List of URLs (meant for display in backend module)
418 422
      *
419 423
      */
@@ -538,7 +542,6 @@  discard block
 block discarded – undo
538 542
      * This methods returns an array of configurations.
539 543
      * And no urls!
540 544
      *
541
-     * @param integer $id Page ID
542 545
      * @return array
543 546
      */
544 547
     public function getUrlsForPageId($pageId)
@@ -907,7 +910,7 @@  discard block
 block discarded – undo
907 910
      * The number of URLs will be the multiplication of the number of parameter values for each key
908 911
      *
909 912
      * @param array $paramArray Output of expandParameters(): Array with keys (GET var names) and for each an array of values
910
-     * @param array $urls URLs accumulated in this array (for recursion)
913
+     * @param string[] $urls URLs accumulated in this array (for recursion)
911 914
      * @return array
912 915
      */
913 916
     public function compileUrls($paramArray, array $urls)
@@ -1650,7 +1653,7 @@  discard block
 block discarded – undo
1650 1653
      * @param array $url
1651 1654
      * @param string $crawlerId
1652 1655
      *
1653
-     * @return array
1656
+     * @return string[]
1654 1657
      */
1655 1658
     protected function buildRequestHeaderArray(array $url, $crawlerId)
1656 1659
     {
@@ -1923,6 +1926,7 @@  discard block
 block discarded – undo
1923 1926
      *
1924 1927
      * @param    array        Page row
1925 1928
      * @param    string        Page icon and title for row
1929
+     * @param string $pageTitleAndIcon
1926 1930
      * @return    string        HTML <tr> content (one or more)
1927 1931
      */
1928 1932
     public function drawURLs_addRowsForPage(array $pageRow, $pageTitleAndIcon)
@@ -2047,7 +2051,7 @@  discard block
 block discarded – undo
2047 2051
      * @param int $countInARun
2048 2052
      * @param int $sleepTime
2049 2053
      * @param int $sleepAfterFinish
2050
-     * @return string
2054
+     * @return integer
2051 2055
      */
2052 2056
     public function CLI_run($countInARun, $sleepTime, $sleepAfterFinish)
2053 2057
     {
@@ -2349,6 +2353,7 @@  discard block
 block discarded – undo
2349 2353
      * Used to determine timeouts and to ensure a proper cleanup if there's a timeout
2350 2354
      *
2351 2355
      * @param  string  identification string for the process
2356
+     * @param string $pid
2352 2357
      * @return boolean determines if the process is still active / has resources
2353 2358
      *
2354 2359
      * TODO: Please consider moving this to Domain Model for Process or in ProcessRepository
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -40,9 +40,7 @@
 block discarded – undo
40 40
 use TYPO3\CMS\Core\Database\Connection;
41 41
 use TYPO3\CMS\Core\Database\ConnectionPool;
42 42
 use TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction;
43
-use TYPO3\CMS\Core\Database\Query\Restriction\EndTimeRestriction;
44 43
 use TYPO3\CMS\Core\Database\Query\Restriction\HiddenRestriction;
45
-use TYPO3\CMS\Core\Database\Query\Restriction\StartTimeRestriction;
46 44
 use TYPO3\CMS\Core\TypoScript\Parser\TypoScriptParser;
47 45
 use TYPO3\CMS\Core\Utility\DebugUtility;
48 46
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
Please login to merge, or discard this patch.