Aoe\Asdis\System\Log\Logger::logException()

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

0

<?php
    public function logException($context, \Exception $e)
    {
        if (true === version_compare(\TYPO3\CMS\Core\Utility\VersionNumberUtility::getCurrentTypo3Version(), '9.5.0', '<')) {
            $this->syslog(
                $context,
                'Exception occured ' . PHP_EOL .

'Exception occured ' . Aoe\Asdis\System\Log\PHP_EOL . ' Code: ' . $e->getCode() . Aoe\Asdis\System\Log\PHP_EOL . ' Message: "' . $e->getMessage() . '"' . Aoe\Asdis\System\Log\PHP_EOL . ' Trace:' . Aoe\Asdis\System\Log\PHP_EOL . $e->getTraceAsString() of type string is incompatible with the type integer expected by parameter $severity of Aoe\Asdis\System\Log\Logger::syslog().

                '  Code:    ' . $e->getCode() . PHP_EOL .
                '  Message: "' . $e->getMessage() . '"' . PHP_EOL .
                '  Trace:' . PHP_EOL . $e->getTraceAsString(),
                4

The call to Aoe\Asdis\System\Log\Logger::syslog() has too many arguments starting with 4.

            );
            return;
        }

        $this->logger = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Log\LogManager::class)->getLogger(__CLASS__);

The property logger does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->logger->error(
            $context . ': ' . $e->getMessage(),
            $e->getTrace()
        );
}