Aoe\Asdis\System\Log\Logger

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	syslog()	0	3	1
A	logException()	0	18	2

<?php
namespace Aoe\Asdis\System\Log;

use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\SingletonInterface;

/**
 * System logger.
 */
class Logger implements SingletonInterface
{
    /**
     * @param string $context
     * @param Exception $e

The type Aoe\Asdis\System\Log\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

     */
    public function logException($context, \Exception $e)
    {
        if (true === version_compare(\TYPO3\CMS\Core\Utility\VersionNumberUtility::getCurrentTypo3Version(), '9.5.0', '<')) {
            $this->syslog(
                $context,
                'Exception occured ' . PHP_EOL .

'Exception occured ' . Aoe\Asdis\System\Log\PHP_EOL . ' Code: ' . $e->getCode() . Aoe\Asdis\System\Log\PHP_EOL . ' Message: "' . $e->getMessage() . '"' . Aoe\Asdis\System\Log\PHP_EOL . ' Trace:' . Aoe\Asdis\System\Log\PHP_EOL . $e->getTraceAsString() of type string is incompatible with the type integer expected by parameter $severity of Aoe\Asdis\System\Log\Logger::syslog().

                '  Code:    ' . $e->getCode() . PHP_EOL .
                '  Message: "' . $e->getMessage() . '"' . PHP_EOL .
                '  Trace:' . PHP_EOL . $e->getTraceAsString(),
                4

The call to Aoe\Asdis\System\Log\Logger::syslog() has too many arguments starting with 4.

            );
            return;
        }

        $this->logger = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Log\LogManager::class)->getLogger(__CLASS__);

The property logger does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->logger->error(
            $context . ': ' . $e->getMessage(),
            $e->getTrace()
        );
    }

    /**
     * @param string $message
     * @param integer $severity
     */
    private function syslog($message, $severity)
    {
        GeneralUtility::sysLog($message, 'asdis', $severity);

The method sysLog() does not exist on TYPO3\CMS\Core\Utility\GeneralUtility.

    }
}