Issues (5)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Classes/Hooks/Tcemain.php (3 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
namespace AOE\AoeIpauth\Hooks;
3
4
/***************************************************************
5
 *  Copyright notice
6
 *
7
 *  (c) 2019 AOE GmbH <[email protected]>
8
 *
9
 *  All rights reserved
10
 *
11
 *  This script is part of the TYPO3 project. The TYPO3 project is
12
 *  free software; you can redistribute it and/or modify
13
 *  it under the terms of the GNU General Public License as published by
14
 *  the Free Software Foundation; either version 3 of the License, or
15
 *  (at your option) any later version.
16
 *
17
 *  The GNU General Public License can be found at
18
 *  http://www.gnu.org/copyleft/gpl.html.
19
 *
20
 *  This script is distributed in the hope that it will be useful,
21
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
22
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
23
 *  GNU General Public License for more details.
24
 *
25
 *  This copyright notice MUST APPEAR in all copies of the script!
26
 ***************************************************************/
27
28
use AOE\AoeIpauth\Service\IpMatchingService;
29
use TYPO3\CMS\Core\DataHandling\DataHandler;
30
use TYPO3\CMS\Core\Messaging\FlashMessage;
31
use TYPO3\CMS\Core\Messaging\FlashMessageQueue;
32
use TYPO3\CMS\Core\Messaging\FlashMessageService;
33
use TYPO3\CMS\Core\Utility\GeneralUtility;
34
use TYPO3\CMS\Extbase\Object\ObjectManager;
35
36
/**
37
 * Class Tcemain
38
 *
39
 * @package AOE\AoeIpauth\Hooks
40
 */
41
class Tcemain
42
{
43
44
    const IP_TABLE = 'tx_aoeipauth_domain_model_ip';
45
46
    /**
47
     * @var ObjectManager
48
     */
49
    protected $objectManager;
50
51
    /**
52
     * Post process
53
     *
54
     * @param string $status
55
     * @param string $table
56
     * @param string $id
57
     * @param array $fieldArray
58
     * @param DataHandler $pObj
59
     * @return void
60
     */
61
    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray, &$pObj)
0 ignored issues
show
The parameter $status is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
The parameter $id is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
The parameter $pObj is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
62
    {
63
        /** @var ObjectManager $this->objectManager */
64
        $this->objectManager = GeneralUtility::makeInstance(ObjectManager::class);
65
66
        if (self::IP_TABLE != $table || empty($fieldArray) || !isset($fieldArray['ip'])) {
67
            return;
68
        }
69
70
        /** @var \AOE\AoeIpauth\Service\IpMatchingService $ipMatchingService */
71
        $ipMatchingService = $this->objectManager->get(IpMatchingService::class);
72
73
        $potentialIp = $fieldArray['ip'];
74
75
        // If it is a valid IP, return. No further action needed.
76
        $isValidIp = $ipMatchingService->isValidIp($potentialIp);
77
        if ($isValidIp) {
78
            $fieldArray['range_type'] = IpMatchingService::NORMAL_IP_TYPE;
79
            return;
80
        }
81
82
        // Allow wildcard notations
83
        $isValidWildcard = $ipMatchingService->isValidWildcardIp($potentialIp);
84
        if ($isValidWildcard) {
85
            $fieldArray['range_type'] = IpMatchingService::WILDCARD_IP_TYPE;
86
            return;
87
        }
88
89
        // Allow dash-range notations
90
        $isValidDashRange = $ipMatchingService->isValidDashRange($potentialIp);
91
        if ($isValidDashRange) {
92
            $fieldArray['range_type'] = IpMatchingService::DASHRANGE_IP_TYPE;
93
            return;
94
        }
95
96
        // Check if it is a valid CIDR range
97
        $isValidRange = $ipMatchingService->isValidCidrRange($potentialIp);
98
        if ($isValidRange) {
99
            $fieldArray['range_type'] = IpMatchingService::CIDR_IP_TYPE;
100
            return;
101
        }
102
103
        // Neither a valid IP nor a valid range
104
        unset($fieldArray['ip']);
105
106
        $this->addFlashMessage(
107
            'The new IP (<strong>' . $potentialIp . '</strong>) ' .
108
                'you entered was neither a valid IP nor a valid range. ' .
109
                'The change was rejected.',
110
            FlashMessage::ERROR
111
        );
112
    }
113
114
    /**
115
     * Adds a simple flash message
116
     *
117
     * @param string $message
118
     * @param int $code
119
     * @return void
120
     */
121
    protected function addFlashMessage($message, $code)
122
    {
123
        $flashMessage = GeneralUtility::makeInstance(FlashMessage::class,
124
            $message,
125
            '',
126
            $code,
127
            true
128
        );
129
130
        $flashMessageService = $this->objectManager->get(FlashMessageService::class);
131
        $messageQueue = $flashMessageService->getMessageQueueByIdentifier();
132
        $messageQueue->addMessage($flashMessage);
133
    }
134
}
135