Tcemain::processDatamap_postProcessFieldArray() - Code Metrics - AOEpeople/aoe_ipauth - Measure and Improve Code Quality continuously with Scrutinizer

Tcemain::processDatamap_postProcessFieldArray() B
last analyzed 2020-11-24 11:21 UTC

↳ Parent: Tcemain

Complexity

Conditions	8
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	52
rs	7.8028
c	0
b	0
f	0
cc	8
nc	6
nop	5

How to fix Long Method

<?php
namespace AOE\AoeIpauth\Hooks;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2019 AOE GmbH <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

use AOE\AoeIpauth\Service\IpMatchingService;
use TYPO3\CMS\Core\DataHandling\DataHandler;
use TYPO3\CMS\Core\Messaging\FlashMessage;
use TYPO3\CMS\Core\Messaging\FlashMessageQueue;
use TYPO3\CMS\Core\Messaging\FlashMessageService;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Extbase\Object\ObjectManager;

/**
 * Class Tcemain
 *
 * @package AOE\AoeIpauth\Hooks
 */
class Tcemain
{

    const IP_TABLE = 'tx_aoeipauth_domain_model_ip';

    /**
     * @var ObjectManager
     */
    protected $objectManager;

    /**
     * Post process
     *
     * @param string $status
     * @param string $table
     * @param string $id
     * @param array $fieldArray
     * @param DataHandler $pObj
     * @return void
     */
    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray, &$pObj)

    {
        /** @var ObjectManager $this->objectManager */
        $this->objectManager = GeneralUtility::makeInstance(ObjectManager::class);

        if (self::IP_TABLE != $table || empty($fieldArray) || !isset($fieldArray['ip'])) {
            return;
        }

        /** @var \AOE\AoeIpauth\Service\IpMatchingService $ipMatchingService */
        $ipMatchingService = $this->objectManager->get(IpMatchingService::class);

        $potentialIp = $fieldArray['ip'];

        // If it is a valid IP, return. No further action needed.
        $isValidIp = $ipMatchingService->isValidIp($potentialIp);
        if ($isValidIp) {
            $fieldArray['range_type'] = IpMatchingService::NORMAL_IP_TYPE;
            return;
        }

        // Allow wildcard notations
        $isValidWildcard = $ipMatchingService->isValidWildcardIp($potentialIp);
        if ($isValidWildcard) {
            $fieldArray['range_type'] = IpMatchingService::WILDCARD_IP_TYPE;
            return;
        }

        // Allow dash-range notations
        $isValidDashRange = $ipMatchingService->isValidDashRange($potentialIp);
        if ($isValidDashRange) {
            $fieldArray['range_type'] = IpMatchingService::DASHRANGE_IP_TYPE;
            return;
        }

        // Check if it is a valid CIDR range
        $isValidRange = $ipMatchingService->isValidCidrRange($potentialIp);
        if ($isValidRange) {
            $fieldArray['range_type'] = IpMatchingService::CIDR_IP_TYPE;
            return;
        }

        // Neither a valid IP nor a valid range
        unset($fieldArray['ip']);

        $this->addFlashMessage(
            'The new IP (<strong>' . $potentialIp . '</strong>) ' .
                'you entered was neither a valid IP nor a valid range. ' .
                'The change was rejected.',
            FlashMessage::ERROR
        );
    }

    /**
     * Adds a simple flash message
     *
     * @param string $message
     * @param int $code
     * @return void
     */
    protected function addFlashMessage($message, $code)
    {
        $flashMessage = GeneralUtility::makeInstance(FlashMessage::class,
            $message,
            '',
            $code,
            true
        );

        $flashMessageService = $this->objectManager->get(FlashMessageService::class);
        $messageQueue = $flashMessageService->getMessageQueueByIdentifier();
        $messageQueue->addMessage($flashMessage);
    }
}


1			<?php
2			namespace AOE\AoeIpauth\Hooks;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2019 AOE GmbH <[email protected]>
8			*
9			* All rights reserved
10			*
11			* This script is part of the TYPO3 project. The TYPO3 project is
12			* free software; you can redistribute it and/or modify
13			* it under the terms of the GNU General Public License as published by
14			* the Free Software Foundation; either version 3 of the License, or
15			* (at your option) any later version.
16			*
17			* The GNU General Public License can be found at
18			* http://www.gnu.org/copyleft/gpl.html.
19			*
20			* This script is distributed in the hope that it will be useful,
21			* but WITHOUT ANY WARRANTY; without even the implied warranty of
22			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			* GNU General Public License for more details.
24			*
25			* This copyright notice MUST APPEAR in all copies of the script!
26			***************************************************************/
27
28			use AOE\AoeIpauth\Service\IpMatchingService;
29			use TYPO3\CMS\Core\DataHandling\DataHandler;
30			use TYPO3\CMS\Core\Messaging\FlashMessage;
31			use TYPO3\CMS\Core\Messaging\FlashMessageQueue;
32			use TYPO3\CMS\Core\Messaging\FlashMessageService;
33			use TYPO3\CMS\Core\Utility\GeneralUtility;
34			use TYPO3\CMS\Extbase\Object\ObjectManager;
35
36			/**
37			* Class Tcemain
38			*
39			* @package AOE\AoeIpauth\Hooks
40			*/
41			class Tcemain
42			{
43
44			const IP_TABLE = 'tx_aoeipauth_domain_model_ip';
45
46			/**
47			* @var ObjectManager
48			*/
49			protected $objectManager;
50
51			/**
52			* Post process
53			*
54			* @param string $status
55			* @param string $table
56			* @param string $id
57			* @param array $fieldArray
58			* @param DataHandler $pObj
59			* @return void
60			*/
61			public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray, &$pObj)
			0 ignored issues – show Unused Code introduced 2017-09-07 15:36 UTC by Report Bug Copy Issue Report The parameter `$status` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-09-07 15:36 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-09-07 15:36 UTC by Report Bug Copy Issue Report The parameter `$pObj` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
62			{
63			/** @var ObjectManager $this->objectManager */
64			$this->objectManager = GeneralUtility::makeInstance(ObjectManager::class);
65
66			if (self::IP_TABLE != $table \|\| empty($fieldArray) \|\| !isset($fieldArray['ip'])) {
67			return;
68			}
69
70			/** @var \AOE\AoeIpauth\Service\IpMatchingService $ipMatchingService */
71			$ipMatchingService = $this->objectManager->get(IpMatchingService::class);
72
73			$potentialIp = $fieldArray['ip'];
74
75			// If it is a valid IP, return. No further action needed.
76			$isValidIp = $ipMatchingService->isValidIp($potentialIp);
77			if ($isValidIp) {
78			$fieldArray['range_type'] = IpMatchingService::NORMAL_IP_TYPE;
79			return;
80			}
81
82			// Allow wildcard notations
83			$isValidWildcard = $ipMatchingService->isValidWildcardIp($potentialIp);
84			if ($isValidWildcard) {
85			$fieldArray['range_type'] = IpMatchingService::WILDCARD_IP_TYPE;
86			return;
87			}
88
89			// Allow dash-range notations
90			$isValidDashRange = $ipMatchingService->isValidDashRange($potentialIp);
91			if ($isValidDashRange) {
92			$fieldArray['range_type'] = IpMatchingService::DASHRANGE_IP_TYPE;
93			return;
94			}
95
96			// Check if it is a valid CIDR range
97			$isValidRange = $ipMatchingService->isValidCidrRange($potentialIp);
98			if ($isValidRange) {
99			$fieldArray['range_type'] = IpMatchingService::CIDR_IP_TYPE;
100			return;
101			}
102
103			// Neither a valid IP nor a valid range
104			unset($fieldArray['ip']);
105
106			$this->addFlashMessage(
107			'The new IP (<strong>' . $potentialIp . '</strong>) ' .
108			'you entered was neither a valid IP nor a valid range. ' .
109			'The change was rejected.',
110			FlashMessage::ERROR
111			);
112			}
113
114			/**
115			* Adds a simple flash message
116			*
117			* @param string $message
118			* @param int $code
119			* @return void
120			*/
121			protected function addFlashMessage($message, $code)
122			{
123			$flashMessage = GeneralUtility::makeInstance(FlashMessage::class,
124			$message,
125			'',
126			$code,
127			true
128			);
129
130			$flashMessageService = $this->objectManager->get(FlashMessageService::class);
131			$messageQueue = $flashMessageService->getMessageQueueByIdentifier();
132			$messageQueue->addMessage($flashMessage);
133			}
134			}
135

AOEpeople / aoe_ipauth

Tcemain::processDatamap_postProcessFieldArray() B last analyzed 2020-11-24 11:21 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Tcemain::processDatamap_postProcessFieldArray() B
last analyzed 2020-11-24 11:21 UTC