Inspection of "Return Type based result instead of rule validatio..." - 2DSharp/Phypes - Measure and Improve Code Quality continuously with Scrutinizer

Phypes

Passed

Push — master ( 658045...68d667 )

by Dedipyaman

created 2019-07-22 18:22 UTC

Status

All Patches
35
New
1

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -56,8 +56,9 @@
 block discarded – undo
             new MaximumLength($this->maxLength));
 
         $result = $rule->validate($username);
-        if ($result->isValid())
-            return new Success();
+        if ($result->isValid()) {
+                    return new Success();
+        }
         /**
          * @var Failure $result
          */

Please login to merge, or discard this patch.

		@@ -56,8 +56,9 @@
		block discarded – undo
56	56	new MaximumLength($this->maxLength));
57	57
58	58	$result = $rule->validate($username);
59		- if ($result->isValid())
60		- return new Success();
	59	+ if ($result->isValid()) {
	60	+ return new Success();
	61	+ }
61	62	/**
62	63	* @var Failure $result
63	64	*/

2DSharp / Phypes

Push — master ( 658045...68d667 )

Status

Category

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch