newicon / neon

neon/firefly/services/FileManager.php

Braces +15 added lines, -7 removed lines

@@ -66,7 +66,9 @@ 
 		neon()->firefly->isFileObjectValid($file);
 		$stream = fopen($file->getRealPath(), 'r+');
 		$uuid = $this->save($stream, $file->getFilename(), $meta);
-		if (is_resource($stream)) fclose($stream);
+		if (is_resource($stream)) {
+			fclose($stream);
+		}
 		return $uuid;
 	}
 
@@ -246,7 +248,9 @@ 
 	public function destroy($uuid)
 	{
 		$file = Model::findWithDeleted()->where(['uuid' => $uuid])->one();
-		if ($file === null) return false;
+		if ($file === null) {
+			return false;
+		}
 		return $file->destroy();
 	}
 
@@ -329,7 +333,9 @@ 
 			$driver = $this->getDriveFor($uuid, $file);
 			$hash = $driver->hash($file['path']);
 			$model = $this->_get($uuid);
-			if (!$hash) return false;
+			if (!$hash) {
+				return false;
+			}
 			$model->file_hash = $hash;
 			$model->save();
 		}
@@ -393,8 +399,9 @@ 
 	{
 		$model = $this->_get($uuid);
 		$model->attributes = $updates;
-		if (!$model->save())
-			throw new HttpException(400, $model->getErrors());
+		if (!$model->save()) {
+					throw new HttpException(400, $model->getErrors());
+		}
 		return $model->toArray();
 	}
 
@@ -408,8 +415,9 @@ 
 	public function findFile($drive, $path)
 	{
 		$model = Model::find()->where(['drive' => $drive, 'path' => $path])->one();
-		if ($model === null)
-			return null;
+		if ($model === null) {
+					return null;
+		}
 		return $model->toArray();
 	}
 

neon/core/form/fields/ImageMultiple.php

Spacing +3 added lines, -3 removed lines

@@ -47,14 +47,14 @@
 		];
 	}
 
-	public function getValueDisplay($context='')
+	public function getValueDisplay($context = '')
 	{
 		$json = $this->getValue();
 		if (empty($json))
 			return neon()->formatter->asJson($this->getValue());
-		if ($context==='grid') {
+		if ($context === 'grid') {
 			$out = '';
-			foreach($json as $image) {
+			foreach ($json as $image) {
 				$url = neon()->firefly->getImage($image);
 				$out .= "<img src='$url' />";
 			}

Braces +9 added lines, -6 removed lines

@@ -23,10 +23,12 @@ 
 
 	public function setValue($value)
 	{
-		if (is_array($value))
-			$this->_value = $value;
-		if (is_string($value))
-			$this->_value = json_decode($value);
+		if (is_array($value)) {
+					$this->_value = $value;
+		}
+		if (is_string($value)) {
+					$this->_value = json_decode($value);
+		}
 	}
 
 	public function getData()
@@ -50,8 +52,9 @@ 
 	public function getValueDisplay($context='')
 	{
 		$json = $this->getValue();
-		if (empty($json))
-			return neon()->formatter->asJson($this->getValue());
+		if (empty($json)) {
+					return neon()->formatter->asJson($this->getValue());
+		}
 		if ($context==='grid') {
 			$out = '';
 			foreach($json as $image) {

neon/core/form/fields/ChoiceMultiple.php

Braces +9 added lines, -6 removed lines

@@ -41,8 +41,9 @@ 
 	public function setValueFromDb($value)
 	{
 		$items = [];
-		foreach ($value as $item)
-			$items[] = $item['key'];
+		foreach ($value as $item) {
+					$items[] = $item['key'];
+		}
 		return parent::setValueFromDb($items);
 	}
 
@@ -55,10 +56,12 @@ 
 	public function getSelectedItems()
 	{
 		$values = $this->getValue();
-		if (!is_array($values))
-			$values = [$values];
-		if ($this->create === false)
-			return Arr::only($this->getItems(), $values);
+		if (!is_array($values)) {
+					$values = [$values];
+		}
+		if ($this->create === false) {
+					return Arr::only($this->getItems(), $values);
+		}
 		return $values;
 	}
 

neon/cms/components/Daedalus.php

Braces +91 added lines, -66 removed lines

@@ -209,10 +209,11 @@ 
 				// $result['edit'] = $this->createEditable($data);
 			}
 		}
-		if ($this->renderer)
-			$this->renderer->assign($this->params['assign'], $result);
-		else
-			return $result;
+		if ($this->renderer) {
+					$this->renderer->assign($this->params['assign'], $result);
+		} else {
+					return $result;
+		}
 	}
 
 	/**
@@ -230,19 +231,22 @@ 
 	protected function queryChoice($template=true)
 	{
 		// check usage
-		if (!isset($this->params['member']))
-			return "Usage: you must provide a 'member' parameter. You provided ".print_r($this->params,true);
-		if ($this->renderer && !isset($this->params['assign']))
-			return "Usage: you must provide an 'assign' parameter. You provided ".print_r($this->params,true);
-		if (strpos($this->params['member'],':') === false && !isset($this->params['class']))
-			return "Usage: if you do not scope the member as class::member then you must provide the class parameter";
+		if (!isset($this->params['member'])) {
+					return "Usage: you must provide a 'member' parameter. You provided ".print_r($this->params,true);
+		}
+		if ($this->renderer && !isset($this->params['assign'])) {
+					return "Usage: you must provide an 'assign' parameter. You provided ".print_r($this->params,true);
+		}
+		if (strpos($this->params['member'],':') === false && !isset($this->params['class'])) {
+					return "Usage: if you do not scope the member as class::member then you must provide the class parameter";
+		}
 
 		// extract out class and member
 		$class = null;
 		$member = null;
-		if (strpos($this->params['member'],':') !== false)
-			list ($class, $member) = explode(':', str_replace('::',':',$this->params['member']));
-		else {
+		if (strpos($this->params['member'],':') !== false) {
+					list ($class, $member) = explode(':', str_replace('::',':',$this->params['member']));
+		} else {
 			$class = $this->params['class'];
 			$member = $this->params['member'];
 		}
@@ -254,10 +258,11 @@ 
 		if (!isset(self::$_choices[$key])) {
 			$dds = neon('dds')->iDdsClassManagement;
 			$result = $dds->getMember($class, $member, ['choices']);
-			if (!empty($result) && isset($result['choices']))
-				self::$_choices[$key] = $result['choices'];
-			else
-				self::$_choices[$key] = [];
+			if (!empty($result) && isset($result['choices'])) {
+							self::$_choices[$key] = $result['choices'];
+			} else {
+							self::$_choices[$key] = [];
+			}
 		}
 		$choices = self::$_choices[$key];
 		if (isset($this->params['order'])) {
@@ -267,10 +272,11 @@ 
 				asort($choices);
 			}
 		}
-		if ($this->renderer)
-			$this->renderer->assign($this->params['assign'], $choices);
-		else
-			return $choices;
+		if ($this->renderer) {
+					$this->renderer->assign($this->params['assign'], $choices);
+		} else {
+					return $choices;
+		}
 	}
 
 	/**
@@ -288,11 +294,13 @@ 
 	protected function queryMap()
 	{
 		// check usage
-		if (!isset($this->params['class']))
-			return "Usage: you must provide a 'class' parameter. You provided ".print_r($this->params,true);
+		if (!isset($this->params['class'])) {
+					return "Usage: you must provide a 'class' parameter. You provided ".print_r($this->params,true);
+		}
 
-		if ($this->renderer && !isset($this->params['assign']))
-			return "Usage: you must provide an 'assign' parameter. You provided ".print_r($this->params,true);
+		if ($this->renderer && !isset($this->params['assign'])) {
+					return "Usage: you must provide an 'assign' parameter. You provided ".print_r($this->params,true);
+		}
 
 		$fields = isset($this->params['fields']) ? $this->params['fields'] : [];
 
@@ -311,11 +319,13 @@ 
 			self::$_maps[$class] = $result;
 		}
 		$map = self::$_maps[$class];
-		if (isset($this->params['flip']))
-			$map = array_flip($map);
+		if (isset($this->params['flip'])) {
+					$map = array_flip($map);
+		}
 
-		if ($this->renderer)
-			$this->renderer->assign($this->params['assign'], $map);
+		if ($this->renderer) {
+					$this->renderer->assign($this->params['assign'], $map);
+		}
 		return $map;
 	}
 
@@ -331,11 +341,13 @@ 
 		$json = trim(str_replace("'", '"', $data));
 		if (strlen($json) > 0) {
 			// for convenience the beginning and ending brackets are optional so add if not supplied
-			if (strpos($json, '{') !== 0)
-				$json = '{'.$json.'}';
+			if (strpos($json, '{') !== 0) {
+							$json = '{'.$json.'}';
+			}
 			$request = json_decode($json, true);
-			if ($request === null)
-				throw new \Exception("Failing to json decode the data request: $json converted from $data. ");
+			if ($request === null) {
+							throw new \Exception("Failing to json decode the data request: $json converted from $data. ");
+			}
 		}
 		return $request;
 	}
@@ -360,10 +372,12 @@ 
 		$dps = array_intersect_key($params, array_flip($dpa));
 		if (count($dps)) {
 			$data = [];
-			if ((isset($dps['dds']) || isset($dps['dds_page'])) && empty($dps['dds_class']))
-				$dps['dds_class'] = $params['type'];
-			if (isset($dps['dds_class']))
-				$data[] = "'class':'$dps[dds_class]'";
+			if ((isset($dps['dds']) || isset($dps['dds_page'])) && empty($dps['dds_class'])) {
+							$dps['dds_class'] = $params['type'];
+			}
+			if (isset($dps['dds_class'])) {
+							$data[] = "'class':'$dps[dds_class]'";
+			}
 
 			// create the filters
 			$filters = [];
@@ -371,9 +385,9 @@ 
 			// create the page specific filter
 			if (!empty($dps['dds_page'])) {
 				$pageId = null;
-				if ($dps['dds_page'] === true || $dps['dds_page'] === 'true')
-					$pageId = neon()->cms->getPage()->getId();
-				else {
+				if ($dps['dds_page'] === true || $dps['dds_page'] === 'true') {
+									$pageId = neon()->cms->getPage()->getId();
+				} else {
 					// either a nice id or a page id
 					// $pageId = self::$page->niceId2PageId($dps['dds_page']);
 					// if (!$pageId)
@@ -381,43 +395,51 @@ 
 					// object therefore has not worked for a while!
 					$pageId = $dps['dds_page'];
 				}
-				if ($pageId)
-					$filters[] = "['page_id','=','$pageId']";
+				if ($pageId) {
+									$filters[] = "['page_id','=','$pageId']";
+				}
 			}
 
 			// add other filters
 			if (isset($dps['dds_filter']) && !empty($dps['dds_filter'])) {
-				if (is_array($dps['dds_filter']))
-					$filters[] = json_encode($dps['dds_filter']);
+				if (is_array($dps['dds_filter'])) {
+									$filters[] = json_encode($dps['dds_filter']);
+				}
 				// else deprecated json approach
-				else if (strpos(trim($dps['dds_filter']), '[')!==0)
-					$filters[] = "[$dps[dds_filter]]";
-				else
-					$filters[] = $dps['dds_filter'];
+				else if (strpos(trim($dps['dds_filter']), '[')!==0) {
+									$filters[] = "[$dps[dds_filter]]";
+				} else {
+									$filters[] = $dps['dds_filter'];
+				}
 			}
 
 			// create the filters clause
-			if (count($filters))
-				$data[] = "'filters':".implode(',',$filters);
+			if (count($filters)) {
+							$data[] = "'filters':".implode(',',$filters);
+			}
 
 			// sort out the order
 			if (isset($dps['dds_order'])) {
-				if (is_array($dps['dds_order']))
-					$data[] = "'order':".json_encode($dps['dds_order']);
+				if (is_array($dps['dds_order'])) {
+									$data[] = "'order':".json_encode($dps['dds_order']);
+				}
 				// else deprecated json approach
-				else
-					$data[] = "'order':{".$dps['dds_order']."}";
+				else {
+									$data[] = "'order':{".$dps['dds_order']."}";
+				}
 			}
 
 			// sort out the limit
 			if (isset($dps['dds_limit'])) {
-				if (is_numeric($dps['dds_limit']))
-					$data[] = "'limit':{'length':$dps[dds_limit]}";
-				else if (is_array($dps['dds_limit']))
-					$data[] = "'limit':".json_encode($dps['dds_limit']);
+				if (is_numeric($dps['dds_limit'])) {
+									$data[] = "'limit':{'length':$dps[dds_limit]}";
+				} else if (is_array($dps['dds_limit'])) {
+									$data[] = "'limit':".json_encode($dps['dds_limit']);
+				}
 				// else deprecated json approach
-				else
-					$data[] = "'limit':{".$dps['dds_limit']."}";
+				else {
+									$data[] = "'limit':{".$dps['dds_limit']."}";
+				}
 			}
 			$params['data'] = '{'.implode(', ', $data).'}';
 		}
@@ -434,8 +456,9 @@ 
 	protected function canonicalise($params)
 	{
 		$canon = [];
-		if (empty($params['assign']) && $this->renderer !== null)
-			throw new \InvalidArgumentException("You must set an 'assign' parameter when using the 'dds' tag");
+		if (empty($params['assign']) && $this->renderer !== null) {
+					throw new \InvalidArgumentException("You must set an 'assign' parameter when using the 'dds' tag");
+		}
 		foreach ($params as $k => $v) {
 			if ($k == 'assign') {
 				$canon[$k] = $v;
@@ -465,8 +488,9 @@ 
 				$classType = $d['_class_type'];
 				foreach ($d as $field=>$value) {
 					// ignore all bookkeeping fields
-					if (strpos($field, '_')===0)
-						continue;
+					if (strpos($field, '_')===0) {
+											continue;
+					}
 					$edit[$i][$field] = self::createFieldEditable($classType, $field, $d['_uuid'], $value);
 				}
 			}
@@ -488,8 +512,9 @@ 
 	 */
 	public static function createFieldEditable($classType, $field, $key, $value)
 	{
-		if (is_array($value))
-			return $value;
+		if (is_array($value)) {
+					return $value;
+		}
 
 		/**
 		 * This needs to be changed to generate an appropriate form to edit the