zwarthoorn / ping

src/Service/PingService.php

<?php


namespace Zwarthoorn\Ping\Service;


use Zwarthoorn\Ping\Entity\Result;
use Zwarthoorn\Ping\Entity\Url;

class PingService
{
    public function ping(Url $urlEntity): array {
        $urls = $urlEntity->getUrl();
        $result = [];
        foreach ($urls as $iValue) {
            $result[] = $this->pingSingle($iValue);
        }

        return $result;
    }

    public function pingSingle(string $url): Result{
        $result = new Result();
        return $result
            ->setResult($this->pingHandler($url))
            ->setUrl($url);
    }

    private function pingHandler(string $url): bool {

        $ch = curl_init($url);
        curl_setopt($ch, CURLOPT_TIMEOUT, 5);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 5);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        $httpcode = curl_getinfo($ch, CURLINFO_HTTP_CODE);

It seems like $ch can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

        curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        return $httpcode >= 200 && $httpcode < 300;
    }
}