Issues in WebPushMessage.php (master) - Issues in master - zupago/webpush - Measure and Improve Code Quality continuously with Scrutinizer

Issues (13)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/WebPushMessage.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace NotificationChannels\WebPush;

class WebPushMessage
{
    /**
     * The notification id.
     *
     * @var string
     */
    protected $id = null;

    /**
     * The notification title.
     *
     * @var string
     */
    protected $title;
    protected $badge;

    /**
     * The notification body.
     *
     * @var string
     */
    protected $body;

    /**
     * The notification icon.
     *
     * @var string
     */
    protected $icon = null;

    /**
     * The notification actions.
     *
     * @var array
     */
    protected $actions = [];

    /**
     * @param string $body
     *
     * @return static
     */
    public static function create($body = '')
    {
        return new static($body);
    }

    /**
     * @param string $body
     */
    public function __construct($body = '')
    {
        $this->title = '';

        $this->body = $body;
    }

    /**
     * Set the notification id.
     *
     * @param  string $value
     * @return $this
     */
    public function id($value)
    {
        $this->id = $value;

        return $this;
    }

    /**
     * Set the notification title.
     *
     * @param  string $value
     * @return $this
     */
    public function title($value)
    {
        $this->title = $value;

        return $this;
    }

    public function badge($badge)
    {
        $this->title = $badge;

        return $this;
    }

    /**
     * Set the notification body.
     *
     * @param  string $value
     * @return $this
     */
    public function body($value)
    {
        $this->body = $value;

        return $this;
    }

    /**
     * Set the notification icon.
     *
     * @param  string $value
     * @return $this
     */
    public function icon($value)
    {
        $this->icon = $value;

        return $this;
    }

    /**
     * Set an action.
     *
     * @return $this
     */
    public function action($value)
    {
        $this->actions = $value;

        return $this;
    }

    // public function action($value)

    //     {
    //         $this->action = $value;


    //         return $this;
    //     }

    /**
     * Get an array representation of the message.
     *
     * @return array
     */
    public function toArray()
    {
        return [
            //'id' => $this->id,

            'title' => $this->title,
            'body' => $this->body,
            'actions' => $this->actions,
            'badge' => $this->badge,
            'icon' => $this->icon,
        ];
    }
}


1			<?php
2
3			namespace NotificationChannels\WebPush;
4
5			class WebPushMessage
6			{
7			/**
8			* The notification id.
9			*
10			* @var string
11			*/
12			protected $id = null;
13
14			/**
15			* The notification title.
16			*
17			* @var string
18			*/
19			protected $title;
20			protected $badge;
21
22			/**
23			* The notification body.
24			*
25			* @var string
26			*/
27			protected $body;
28
29			/**
30			* The notification icon.
31			*
32			* @var string
33			*/
34			protected $icon = null;
35
36			/**
37			* The notification actions.
38			*
39			* @var array
40			*/
41			protected $actions = [];
42
43			/**
44			* @param string $body
45			*
46			* @return static
47			*/
48			public static function create($body = '')
49			{
50			return new static($body);
51			}
52
53			/**
54			* @param string $body
55			*/
56			public function __construct($body = '')
57			{
58			$this->title = '';
59
60			$this->body = $body;
61			}
62
63			/**
64			* Set the notification id.
65			*
66			* @param string $value
67			* @return $this
68			*/
69			public function id($value)
70			{
71			$this->id = $value;
72
73			return $this;
74			}
75
76			/**
77			* Set the notification title.
78			*
79			* @param string $value
80			* @return $this
81			*/
82			public function title($value)
83			{
84			$this->title = $value;
85
86			return $this;
87			}
88
89			public function badge($badge)
90			{
91			$this->title = $badge;
92
93			return $this;
94			}
95
96			/**
97			* Set the notification body.
98			*
99			* @param string $value
100			* @return $this
101			*/
102			public function body($value)
103			{
104			$this->body = $value;
105
106			return $this;
107			}
108
109			/**
110			* Set the notification icon.
111			*
112			* @param string $value
113			* @return $this
114			*/
115			public function icon($value)
116			{
117			$this->icon = $value;
118
119			return $this;
120			}
121
122			/**
123			* Set an action.
124			*
125			* @return $this
126			*/
127			public function action($value)
128			{
129			$this->actions = $value;
130
131			return $this;
132			}
133
134			// public function action($value)
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-16 22:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
135			// {
136			// $this->action = $value;
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-16 22:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
137
138			// return $this;
139			// }
140
141			/**
142			* Get an array representation of the message.
143			*
144			* @return array
145			*/
146			public function toArray()
147			{
148			return [
149			//'id' => $this->id,
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-16 22:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
150			'title' => $this->title,
151			'body' => $this->body,
152			'actions' => $this->actions,
153			'badge' => $this->badge,
154			'icon' => $this->icon,
155			];
156			}
157			}
158

zupago / webpush

Issues (13)

Security Analysis not enabled

src/WebPushMessage.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like