DateTimeEntitySerializer::unserialize() - Code Metrics - Inspection of "Add fluent custom serializers handling" - zumba/json-serializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#31)

unknown

created 2017-02-21 13:57 UTC

DateTimeEntitySerializer::unserialize() A

↳ Parent: DateTimeEntitySerializer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Zumba\JsonSerializer\EntitySerializers;

use Zumba\Contracts\EntitySerializer;

class DateTimeEntitySerializer implements EntitySerializer
{
    const FORMAT = \DateTime::ATOM;

    /**
     * @return string
     */
    public function getType()
    {
        return 'DateTime';
    }

    /**
     * @param $object
     * @return array
     */
    public function serialize($object)
    {
        return [
            'time'     => $object->format(self::FORMAT),
            'timezone' => $object->getTimezone()->getName()
        ];
    }

    /**
     * @param array $data
     * @return \DateTime
     */
    public function unserialize($data)
    {
        return \DateTime::createFromFormat(self::FORMAT, $data['time'], new \DateTimeZone($data['timezone']));

    }
}


1			<?php
2
3			namespace Zumba\JsonSerializer\EntitySerializers;
4
5			use Zumba\Contracts\EntitySerializer;
6
7			class DateTimeEntitySerializer implements EntitySerializer
8			{
9			const FORMAT = \DateTime::ATOM;
10
11			/**
12			* @return string
13			*/
14			public function getType()
15			{
16			return 'DateTime';
17			}
18
19			/**
20			* @param $object
21			* @return array
22			*/
23			public function serialize($object)
24			{
25			return [
26			'time' => $object->format(self::FORMAT),
27			'timezone' => $object->getTimezone()->getName()
28			];
29			}
30
31			/**
32			* @param array $data
33			* @return \DateTime
34			*/
35			public function unserialize($data)
36			{
37			return \DateTime::createFromFormat(self::FORMAT, $data['time'], new \DateTimeZone($data['timezone']));
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-02-21 12:15 UTC by Report Bug Copy Issue Report The expression `\DateTime::createFromFor...ne($data['timezone']));` of type `DateTime\|false` adds `false` to the return on line 37 which is incompatible with the return type documented by `Zumba\JsonSerializer\Ent...Serializer::unserialize` of type `DateTime`. It seems like you forgot to handle an error condition. Loading history...
38			}
39			}
40

zumba / json-serializer

GitHub Access Token became invalid

Pull Request — master (#31)

DateTimeEntitySerializer::unserialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like