Zumba\JsonSerializer\EntitySerializers\DateTimeEntitySerializer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getType()	0	4	1
A	serialize()	0	7	1
A	unserialize()	0	4	1

<?php

namespace Zumba\JsonSerializer\EntitySerializers;

use Zumba\Contracts\EntitySerializer;

class DateTimeEntitySerializer implements EntitySerializer
{
    const FORMAT = \DateTime::ATOM;

    /**
     * @return string
     */
    public function getType()
    {
        return 'DateTime';
    }

    /**
     * @param $object
     * @return array
     */
    public function serialize($object)
    {
        return [
            'time'     => $object->format(self::FORMAT),
            'timezone' => $object->getTimezone()->getName()
        ];
    }

    /**
     * @param array $data
     * @return \DateTime
     */
    public function unserialize($data)
    {
        return \DateTime::createFromFormat(self::FORMAT, $data['time'], new \DateTimeZone($data['timezone']));

The expression \DateTime::createFromFormat(self::FORMAT, $data['time'], new \DateTimeZone($data['timezone'])); of type DateTime|false adds false to the return on line 37 which is incompatible with the return type documented by Zumba\JsonSerializer\EntitySerializers\DateTimeEntitySerializer::unserialize of type DateTime. It seems like you forgot to handle an error condition.

    }
}