JsonSerializer - Code Metrics - Inspection of "Merge pull request #19 from zumba/new-namespace" - zumba/json-serializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4a67f9...fffa0d )

by Chris

created 2016-04-06 02:14 UTC

JsonSerializer B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	302
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	42
c	1
b	0
f	0
lcom	1
cbo	1
dl	0
loc	302
rs	8.295

13 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	serialize()	6	1
A	calculateEncodeOptions()	8	2
A	processEncodedValue()	7	2
A	unserialize()	9	3
D	serializeData()	27	10
A	serializeObject()	14	2
A	getObjectProperties()	12	3
A	extractObjectData()	14	3
B	unserializeData()	19	6
C	unserializeObject()	37	7
A	restoreUsingUnserialize()	6	1
A	reset()	6	1

How to fix Complexity

<?php

namespace Zumba\JsonSerializer;

use ReflectionClass;
use ReflectionException;
use SplObjectStorage;
use Zumba\JsonSerializer\Exception\JsonSerializerException;
use SuperClosure\SerializerInterface as ClosureSerializerInterface;

class JsonSerializer
{

    const CLASS_IDENTIFIER_KEY = '@type';
    const CLOSURE_IDENTIFIER_KEY = '@closure';
    const FLOAT_ADAPTER = 'JsonSerializerFloatAdapter';

    /**
     * Storage for object
     *
     * Used for recursion
     *
     * @var SplObjectStorage
     */
    protected $objectStorage;

    /**
     * Object mapping for recursion
     *
     * @var array
     */
    protected $objectMapping = array();

    /**
     * Object mapping index
     *
     * @var integer
     */
    protected $objectMappingIndex = 0;

    /**
     * Support PRESERVE_ZERO_FRACTION json option
     *
     * @var boolean
     */
    protected $preserveZeroFractionSupport;

    /**
     * Closure serializer instance
     *
     * @var SuperClosure\SerializerInterface
     */
    protected $closureSerializer;

    /**
     * Constructor.
     *
     * @param SuperClosure\SerializerInterface $closureSerializer
     */
    public function __construct(ClosureSerializerInterface $closureSerializer = null)
    {
        $this->preserveZeroFractionSupport = defined('JSON_PRESERVE_ZERO_FRACTION');
        $this->closureSerializer = $closureSerializer;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Serialize the value in JSON
     *
     * @param mixed $value
     * @return string JSON encoded
     * @throws Zumba\JsonSerializer\Exception\JsonSerializerException
     */
    public function serialize($value)
    {
        $this->reset();
        $encoded = json_encode($this->serializeData($value), $this->calculateEncodeOptions());
        return $this->processEncodedValue($encoded);
    }

    /**
     * Calculate encoding options
     *
     * @return integer
     */
    protected function calculateEncodeOptions()
    {
        $options = JSON_UNESCAPED_UNICODE;
        if ($this->preserveZeroFractionSupport) {
            $options |= JSON_PRESERVE_ZERO_FRACTION;
        }
        return $options;
    }

    /**
     * Execute post-encoding actions
     *
     * @param string $encoded
     * @return string
     */
    protected function processEncodedValue($encoded)
    {
        if (!$this->preserveZeroFractionSupport) {
            $encoded = preg_replace('/"' . static::FLOAT_ADAPTER . '\((.*?)\)"/', '\1', $encoded);
        }
        return $encoded;
    }

    /**
     * Unserialize the value from JSON
     *
     * @param string $value
     * @return mixed
     */
    public function unserialize($value)
    {
        $this->reset();
        $data = json_decode($value, true);
        if ($data === null && json_last_error() != JSON_ERROR_NONE) {
            throw new JsonSerializerException('Invalid JSON to unserialize.');
        }
        return $this->unserializeData($data);
    }

    /**
     * Parse the data to be json encoded
     *
     * @param mixed $value
     * @return mixed
     * @throws Zumba\JsonSerializer\Exception\JsonSerializerException
     */
    protected function serializeData($value)
    {
        if (is_scalar($value) || $value === null) {
            if (!$this->preserveZeroFractionSupport && is_float($value) && ctype_digit((string)$value)) {
                // Because the PHP bug #50224, the float numbers with no
                // precision numbers are converted to integers when encoded
                $value = static::FLOAT_ADAPTER . '(' . $value . '.0)';
            }
            return $value;
        }
        if (is_resource($value)) {
            throw new JsonSerializerException('Resource is not supported in JsonSerializer');
        }
        if (is_array($value)) {
            return array_map(array($this, __FUNCTION__), $value);
        }
        if ($value instanceof \Closure) {
            if (!$this->closureSerializer) {
                throw new JsonSerializerException('Closure serializer not given. Unable to serialize closure.');
            }
            return array(
                static::CLOSURE_IDENTIFIER_KEY => true,
                'value' => $this->closureSerializer->serialize($value)
            );
        }
        return $this->serializeObject($value);
    }

    /**
     * Extract the data from an object
     *
     * @param object $value
     * @return array
     */
    protected function serializeObject($value)
    {
        $ref = new ReflectionClass($value);

        if ($this->objectStorage->contains($value)) {
            return array(static::CLASS_IDENTIFIER_KEY => '@' . $this->objectStorage[$value]);
        }
        $this->objectStorage->attach($value, $this->objectMappingIndex++);

        $paramsToSerialize = $this->getObjectProperties($ref, $value);
        $data = array(static::CLASS_IDENTIFIER_KEY => $ref->getName());
        $data += array_map(array($this, 'serializeData'), $this->extractObjectData($value, $ref, $paramsToSerialize));
        return $data;
    }

    /**
     * Return the list of properties to be serialized
     *
     * @param ReflectionClass $ref
     * @param object $value
     * @return array
     */
    protected function getObjectProperties($ref, $value)
    {
        if (method_exists($value, '__sleep')) {
            return $value->__sleep();
        }

        $props = array();
        foreach ($ref->getProperties() as $prop) {
            $props[] = $prop->getName();
        }
        return array_unique(array_merge($props, array_keys(get_object_vars($value))));
    }

    /**
     * Extract the object data
     *
     * @param object $value
     * @param ReflectionClass $ref
     * @param array $properties
     * @return array
     */
    protected function extractObjectData($value, $ref, $properties)
    {
        $data = array();
        foreach ($properties as $property) {
            try {
                $propRef = $ref->getProperty($property);
                $propRef->setAccessible(true);
                $data[$property] = $propRef->getValue($value);
            } catch (ReflectionException $e) {
                $data[$property] = $value->$property;
            }
        }
        return $data;
    }

    /**
     * Parse the json decode to convert to objects again
     *
     * @param mixed $value
     * @return mixed
     */
    protected function unserializeData($value)
    {
        if (is_scalar($value) || $value === null) {
            return $value;
        }

        if (isset($value[static::CLASS_IDENTIFIER_KEY])) {
            return $this->unserializeObject($value);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        if (!empty($value[static::CLOSURE_IDENTIFIER_KEY])) {
            if (!$this->closureSerializer) {
                throw new JsonSerializerException('Closure serializer not provided to unserialize closure');
            }
            return $this->closureSerializer->unserialize($value['value']);
        }

        return array_map(array($this, __FUNCTION__), $value);
    }

    /**
     * Convert the serialized array into an object
     *
     * @param aray $value
     * @return object
     * @throws Zumba\JsonSerializer\Exception\JsonSerializerException
     */
    protected function unserializeObject($value)
    {
        $className = $value[static::CLASS_IDENTIFIER_KEY];
        unset($value[static::CLASS_IDENTIFIER_KEY]);

        if ($className[0] === '@') {
            $index = substr($className, 1);
            return $this->objectMapping[$index];
        }

        if (!class_exists($className)) {
            throw new JsonSerializerException('Unable to find class ' . $className);
        }

        if ($className === 'DateTime') {
            $obj = $this->restoreUsingUnserialize($className, $value);
            $this->objectMapping[$this->objectMappingIndex++] = $obj;
            return $obj;
        }

        $ref = new ReflectionClass($className);
        $obj = $ref->newInstanceWithoutConstructor();
        $this->objectMapping[$this->objectMappingIndex++] = $obj;
        foreach ($value as $property => $propertyValue) {
            try {
                $propRef = $ref->getProperty($property);
                $propRef->setAccessible(true);
                $propRef->setValue($obj, $this->unserializeData($propertyValue));
            } catch (ReflectionException $e) {
                $obj->$property = $this->unserializeData($propertyValue);
            }
        }
        if (method_exists($obj, '__wakeup')) {
            $obj->__wakeup();
        }
        return $obj;
    }

    protected function restoreUsingUnserialize($className, $attributes)
    {
        $obj = (object)$attributes;
        $serialized = preg_replace('|^O:\d+:"\w+":|', 'O:' . strlen($className) . ':"' . $className . '":', serialize($obj));
        return unserialize($serialized);
    }

    /**
     * Reset variables
     *
     * @return void
     */
    protected function reset()
    {
        $this->objectStorage = new SplObjectStorage();
        $this->objectMapping = array();
        $this->objectMappingIndex = 0;
    }
}


GitHub Access Token became invalid

Push — master ( 4a67f9...fffa0d )

JsonSerializer B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Complexity

Complex Class

1			<?php
2
3			namespace Zumba\JsonSerializer;
4
5			use ReflectionClass;
6			use ReflectionException;
7			use SplObjectStorage;
8			use Zumba\JsonSerializer\Exception\JsonSerializerException;
9			use SuperClosure\SerializerInterface as ClosureSerializerInterface;
10
11			class JsonSerializer
12			{
13
14			const CLASS_IDENTIFIER_KEY = '@type';
15			const CLOSURE_IDENTIFIER_KEY = '@closure';
16			const FLOAT_ADAPTER = 'JsonSerializerFloatAdapter';
17
18			/**
19			* Storage for object
20			*
21			* Used for recursion
22			*
23			* @var SplObjectStorage
24			*/
25			protected $objectStorage;
26
27			/**
28			* Object mapping for recursion
29			*
30			* @var array
31			*/
32			protected $objectMapping = array();
33
34			/**
35			* Object mapping index
36			*
37			* @var integer
38			*/
39			protected $objectMappingIndex = 0;
40
41			/**
42			* Support PRESERVE_ZERO_FRACTION json option
43			*
44			* @var boolean
45			*/
46			protected $preserveZeroFractionSupport;
47
48			/**
49			* Closure serializer instance
50			*
51			* @var SuperClosure\SerializerInterface
52			*/
53			protected $closureSerializer;
54
55			/**
56			* Constructor.
57			*
58			* @param SuperClosure\SerializerInterface $closureSerializer
59			*/
60			public function __construct(ClosureSerializerInterface $closureSerializer = null)
61			{
62			$this->preserveZeroFractionSupport = defined('JSON_PRESERVE_ZERO_FRACTION');
63			$this->closureSerializer = $closureSerializer;
			0 ignored issues – show Documentation Bug introduced 2016-03-25 22:10 UTC by Report Bug Copy Issue Report It seems like `$closureSerializer` can also be of type `object<SuperClosure\SerializerInterface>`. However, the property `$closureSerializer` is declared as type `object<Zumba\JsonSeriali...re\SerializerInterface>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
64			}
65
66			/**
67			* Serialize the value in JSON
68			*
69			* @param mixed $value
70			* @return string JSON encoded
71			* @throws Zumba\JsonSerializer\Exception\JsonSerializerException
72			*/
73			public function serialize($value)
74			{
75			$this->reset();
76			$encoded = json_encode($this->serializeData($value), $this->calculateEncodeOptions());
77			return $this->processEncodedValue($encoded);
78			}
79
80			/**
81			* Calculate encoding options
82			*
83			* @return integer
84			*/
85			protected function calculateEncodeOptions()
86			{
87			$options = JSON_UNESCAPED_UNICODE;
88			if ($this->preserveZeroFractionSupport) {
89			$options \|= JSON_PRESERVE_ZERO_FRACTION;
90			}
91			return $options;
92			}
93
94			/**
95			* Execute post-encoding actions
96			*
97			* @param string $encoded
98			* @return string
99			*/
100			protected function processEncodedValue($encoded)
101			{
102			if (!$this->preserveZeroFractionSupport) {
103			$encoded = preg_replace('/"' . static::FLOAT_ADAPTER . '\((.*?)\)"/', '\1', $encoded);
104			}
105			return $encoded;
106			}
107
108			/**
109			* Unserialize the value from JSON
110			*
111			* @param string $value
112			* @return mixed
113			*/
114			public function unserialize($value)
115			{
116			$this->reset();
117			$data = json_decode($value, true);
118			if ($data === null && json_last_error() != JSON_ERROR_NONE) {
119			throw new JsonSerializerException('Invalid JSON to unserialize.');
120			}
121			return $this->unserializeData($data);
122			}
123
124			/**
125			* Parse the data to be json encoded
126			*
127			* @param mixed $value
128			* @return mixed
129			* @throws Zumba\JsonSerializer\Exception\JsonSerializerException
130			*/
131			protected function serializeData($value)
132			{
133			if (is_scalar($value) \|\| $value === null) {
134			if (!$this->preserveZeroFractionSupport && is_float($value) && ctype_digit((string)$value)) {
135			// Because the PHP bug #50224, the float numbers with no
136			// precision numbers are converted to integers when encoded
137			$value = static::FLOAT_ADAPTER . '(' . $value . '.0)';
138			}
139			return $value;
140			}
141			if (is_resource($value)) {
142			throw new JsonSerializerException('Resource is not supported in JsonSerializer');
143			}
144			if (is_array($value)) {
145			return array_map(array($this, __FUNCTION__), $value);
146			}
147			if ($value instanceof \Closure) {
148			if (!$this->closureSerializer) {
149			throw new JsonSerializerException('Closure serializer not given. Unable to serialize closure.');
150			}
151			return array(
152			static::CLOSURE_IDENTIFIER_KEY => true,
153			'value' => $this->closureSerializer->serialize($value)
154			);
155			}
156			return $this->serializeObject($value);
157			}
158
159			/**
160			* Extract the data from an object
161			*
162			* @param object $value
163			* @return array
164			*/
165			protected function serializeObject($value)
166			{
167			$ref = new ReflectionClass($value);
168
169			if ($this->objectStorage->contains($value)) {
170			return array(static::CLASS_IDENTIFIER_KEY => '@' . $this->objectStorage[$value]);
171			}
172			$this->objectStorage->attach($value, $this->objectMappingIndex++);
173
174			$paramsToSerialize = $this->getObjectProperties($ref, $value);
175			$data = array(static::CLASS_IDENTIFIER_KEY => $ref->getName());
176			$data += array_map(array($this, 'serializeData'), $this->extractObjectData($value, $ref, $paramsToSerialize));
177			return $data;
178			}
179
180			/**
181			* Return the list of properties to be serialized
182			*
183			* @param ReflectionClass $ref
184			* @param object $value
185			* @return array
186			*/
187			protected function getObjectProperties($ref, $value)
188			{
189			if (method_exists($value, '__sleep')) {
190			return $value->__sleep();
191			}
192
193			$props = array();
194			foreach ($ref->getProperties() as $prop) {
195			$props[] = $prop->getName();
196			}
197			return array_unique(array_merge($props, array_keys(get_object_vars($value))));
198			}
199
200			/**
201			* Extract the object data
202			*
203			* @param object $value
204			* @param ReflectionClass $ref
205			* @param array $properties
206			* @return array
207			*/
208			protected function extractObjectData($value, $ref, $properties)
209			{
210			$data = array();
211			foreach ($properties as $property) {
212			try {
213			$propRef = $ref->getProperty($property);
214			$propRef->setAccessible(true);
215			$data[$property] = $propRef->getValue($value);
216			} catch (ReflectionException $e) {
217			$data[$property] = $value->$property;
218			}
219			}
220			return $data;
221			}
222
223			/**
224			* Parse the json decode to convert to objects again
225			*
226			* @param mixed $value
227			* @return mixed
228			*/
229			protected function unserializeData($value)
230			{
231			if (is_scalar($value) \|\| $value === null) {
232			return $value;
233			}
234
235			if (isset($value[static::CLASS_IDENTIFIER_KEY])) {
236			return $this->unserializeObject($value);
			0 ignored issues – show Documentation introduced 2016-03-25 22:10 UTC by Report Bug Copy Issue Report `$value` is of type `object\|array`, but the function expects a `object<Zumba\JsonSerializer\aray>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
237			}
238
239			if (!empty($value[static::CLOSURE_IDENTIFIER_KEY])) {
240			if (!$this->closureSerializer) {
241			throw new JsonSerializerException('Closure serializer not provided to unserialize closure');
242			}
243			return $this->closureSerializer->unserialize($value['value']);
244			}
245
246			return array_map(array($this, __FUNCTION__), $value);
247			}
248
249			/**
250			* Convert the serialized array into an object
251			*
252			* @param aray $value
253			* @return object
254			* @throws Zumba\JsonSerializer\Exception\JsonSerializerException
255			*/
256			protected function unserializeObject($value)
257			{
258			$className = $value[static::CLASS_IDENTIFIER_KEY];
259			unset($value[static::CLASS_IDENTIFIER_KEY]);
260
261			if ($className[0] === '@') {
262			$index = substr($className, 1);
263			return $this->objectMapping[$index];
264			}
265
266			if (!class_exists($className)) {
267			throw new JsonSerializerException('Unable to find class ' . $className);
268			}
269
270			if ($className === 'DateTime') {
271			$obj = $this->restoreUsingUnserialize($className, $value);
272			$this->objectMapping[$this->objectMappingIndex++] = $obj;
273			return $obj;
274			}
275
276			$ref = new ReflectionClass($className);
277			$obj = $ref->newInstanceWithoutConstructor();
278			$this->objectMapping[$this->objectMappingIndex++] = $obj;
279			foreach ($value as $property => $propertyValue) {
280			try {
281			$propRef = $ref->getProperty($property);
282			$propRef->setAccessible(true);
283			$propRef->setValue($obj, $this->unserializeData($propertyValue));
284			} catch (ReflectionException $e) {
285			$obj->$property = $this->unserializeData($propertyValue);
286			}
287			}
288			if (method_exists($obj, '__wakeup')) {
289			$obj->__wakeup();
290			}
291			return $obj;
292			}
293
294			protected function restoreUsingUnserialize($className, $attributes)
295			{
296			$obj = (object)$attributes;
297			$serialized = preg_replace('\|^O:\d+:"\w+":\|', 'O:' . strlen($className) . ':"' . $className . '":', serialize($obj));
298			return unserialize($serialized);
299			}
300
301			/**
302			* Reset variables
303			*
304			* @return void
305			*/
306			protected function reset()
307			{
308			$this->objectStorage = new SplObjectStorage();
309			$this->objectMapping = array();
310			$this->objectMappingIndex = 0;
311			}
312			}
313

zumba / json-serializer

GitHub Access Token became invalid

Push — master ( 4a67f9...fffa0d )

JsonSerializer B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like