GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#31)
by
unknown
03:24
created

DateTimeEntitySerializer::unserialize()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
c 0
b 0
f 0
rs 10
cc 1
eloc 2
nc 1
nop 1
1
<?php
2
3
namespace Zumba\JsonSerializer\EntitySerializers;
4
5
use Zumba\Contracts\EntitySerializer;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Zumba\JsonSerializer\Ent...lizers\EntitySerializer.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
7
class DateTimeEntitySerializer implements EntitySerializer
8
{
9
    const FORMAT = \DateTime::ATOM;
10
11
    /**
12
     * @return string
13
     */
14
    public function getType()
15
    {
16
        return \DateTime::class;
17
    }
18
19
    /**
20
     * @param $object
21
     * @return array
22
     */
23
    public function serialize($object)
24
    {
25
        return [
26
            'time'     => $object->format(self::FORMAT),
27
            'timezone' => $object->getTimezone()->getName()
28
        ];
29
    }
30
31
    /**
32
     * @param array $data
33
     * @return \DateTime
34
     */
35
    public function unserialize($data)
36
    {
37
        return \DateTime::createFromFormat(self::FORMAT, $data['time'], new \DateTimeZone($data['timezone']));
0 ignored issues
show
Comprehensibility Best Practice introduced by
The expression \DateTime::createFromFor...ne($data['timezone'])); of type DateTime|false adds false to the return on line 37 which is incompatible with the return type documented by Zumba\JsonSerializer\Ent...Serializer::unserialize of type DateTime. It seems like you forgot to handle an error condition.
Loading history...
38
    }
39
}
40